<!DOCTYPE html><html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8" /></head><body><div data-html-editor-font-wrapper="true" style="font-family: arial, sans-serif; font-size: 13px;">sending in my fedora modifications needed to spin up on Fedora 28, removing the Ubuntu specific items, <br>created on my local tree with git format-patch -1 437353d3b108e7a92c0d5c48c81d334f07940dc3 (the git rev is my specific commit to my local tree)<br><br>noted the machine='pc-i440fx-xenial' and seclabel pieces are not required in Fedora, also note in the docs<br><br>Installing Requirements and Dependencies<br>Install the required packages and configure QEMU. This only needs to be done once per host. (NOTE: this script only knows about Ubuntu at this time):<br><br>$SCRIPTS/install_packages.sh<br><br>the above breaks permissions on libvirt in Fedora and most likely others rendering it useless<br><br>we dont use<br>user = "root"<br>group = "root"<br><br>and obviously, we (IMHO) shouldnt be running it as group root anyway, in Fedora there is a libvirt group<br><br><br>0001-fixup-for-fedora.patch<br>From 437353d3b108e7a92c0d5c48c81d334f07940dc3 Mon Sep 17 00:00:00 2001<br>From: OutBack Dingo <outbackdingo@gmail.com><br>Date: Mon, 10 Sep 2018 05:46:58 +0200<br>Subject: [PATCH] fixup for fedora<br><br>---<br> deployment/libvirt/compute.xml | 6 +-----<br> deployment/libvirt/controller.xml | 6 +-----<br> deployment/libvirt/controller_allinone.xml | 6 +-----<br> deployment/libvirt/setup_allinone.sh | 4 ----<br> 4 files changed, 3 insertions(+), 19 deletions(-)<br><br>diff --git a/deployment/libvirt/compute.xml b/deployment/libvirt/compute.xml<br>index 85474c0..4bdc812 100644<br>--- a/deployment/libvirt/compute.xml<br>+++ b/deployment/libvirt/compute.xml<br>@@ -7,7 +7,7 @@<br> <partition>/machine</partition><br> </resource><br> <os><br>- <type arch='x86_64' machine='pc-i440fx-xenial'>hvm</type><br>+ <type arch='x86_64'>hvm</type><br> </os><br> <features><br> <acpi/><br>@@ -108,8 +108,4 @@<br> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/><br> </memballoon><br> </devices><br>- <seclabel type='dynamic' model='apparmor' relabel='yes'><br>- <label>libvirt-608ab5c8-8d11-4bdd-885f-f8b5fee12ff0</label><br>- <imagelabel>libvirt-608ab5c8-8d11-4bdd-885f-f8b5fee12ff0</imagelabel><br>- </seclabel><br> </domain><br>diff --git a/deployment/libvirt/controller.xml b/deployment/libvirt/controller.xml<br>index e346813..65c4d01 100644<br>--- a/deployment/libvirt/controller.xml<br>+++ b/deployment/libvirt/controller.xml<br>@@ -7,7 +7,7 @@<br> <partition>/machine</partition><br> </resource><br> <os><br>- <type arch='x86_64' machine='pc-i440fx-xenial'>hvm</type><br>+ <type arch='x86_64'>hvm</type><br> </os><br> <features><br> <acpi/><br>@@ -122,9 +122,5 @@<br> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/><br> </memballoon><br> </devices><br>- <seclabel type='dynamic' model='apparmor' relabel='yes'><br>- <label>libvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de</label><br>- <imagelabel>libvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de</imagelabel><br>- </seclabel><br> </domain><br> <br>diff --git a/deployment/libvirt/controller_allinone.xml b/deployment/libvirt/controller_allinone.xml<br>index 9249183..83e8fe6 100644<br>--- a/deployment/libvirt/controller_allinone.xml<br>+++ b/deployment/libvirt/controller_allinone.xml<br>@@ -7,7 +7,7 @@<br> <partition>/machine</partition><br> </resource><br> <os><br>- <type arch='x86_64' machine='pc-i440fx-xenial'>hvm</type><br>+ <type arch='x86_64'>hvm</type><br> </os><br> <features><br> <acpi/><br>@@ -122,9 +122,5 @@<br> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/><br> </memballoon><br> </devices><br>- <seclabel type='dynamic' model='apparmor' relabel='yes'><br>- <label>libvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de</label><br>- <imagelabel>libvirt-6afab2ba-0ed0-45cb-b1bd-985e211a48de</imagelabel><br>- </seclabel><br> </domain><br> <br>diff --git a/deployment/libvirt/setup_allinone.sh b/deployment/libvirt/setup_allinone.sh<br>index b228efc..dcf1607 100755<br>--- a/deployment/libvirt/setup_allinone.sh<br>+++ b/deployment/libvirt/setup_allinone.sh<br>@@ -28,10 +28,6 @@ fi<br> <br> ISOIMAGE=$(readlink -f "$ISOIMAGE")<br> FILETYPE=$(file --mime-type -b ${ISOIMAGE})<br>-if ([ "$FILETYPE" != "application/x-iso9660-image" ]); then<br>- echo "$ISOIMAGE is not an application/x-iso9660-image type"<br>- exit -1<br>-fi<br> <br> BRIDGE_INTERFACE=${BRIDGE_INTERFACE:-stxbr}<br> CONTROLLER=${CONTROLLER:-controller-allinone}<br>-- <br>2.17.1<br><br><signature></signature> </div></body></html>