<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-2022-jp">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Microsoft YaHei";
panose-1:2 11 5 3 2 2 4 2 2 4;}
@font-face
{font-family:"\@Microsoft YaHei";
panose-1:2 11 5 3 2 2 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Penny,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Any comment on ntp?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">For nfs-utils, I have updated patch below. Could you pls help to review it?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">https://review.openstack.org/610459<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I just used a new separate package (nfs-utils-config) instead of platform-utils to package
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Config files.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Since the config file in nfs-utils is marked as %config(noreplace) , patching in future will<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Not overwrite it. So there is no issue for patching scenario.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">No need to use kickstart script and patching script for this case.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for your proposal!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Zhipeng<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b>From:</b> Liu, ZhipengS [mailto:zhipengs.liu@intel.com]
<br>
<b>Sent:</b> 2018<span style="font-family:"Microsoft YaHei",sans-serif">年</span>10<span style="font-family:"Microsoft YaHei",sans-serif">月</span>17<span style="font-family:"Microsoft YaHei",sans-serif">日</span> 17:11<br>
<b>To:</b> Penney, Don <Don.Penney@windriver.com><br>
<b>Cc:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> [Starlingx-discuss] Work on reducing config patch for ntp<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Penny,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’d like to discuss with you about this 2 patches.<o:p></o:p></p>
<p class="MsoNormal">ntpd-started-no-g-option.patch //change /etc/sysconfig/ntpd<o:p></o:p></p>
<p class="MsoNormal">ntp-spec-add-TiS-custom-config-files.patch // add ntp.conf file to /etc/<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Can we remove this 2 patches?<o:p></o:p></p>
<p class="MsoNormal">In stx/stx-config/puppet-manifests/src/modules/platform/manifests/ntp.pp,
<o:p></o:p></p>
<p class="MsoNormal">it already generates ntp.conf file by puppet<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">file { 'ntp_config':<o:p></o:p></p>
<p class="MsoNormal"> ensure => file,<o:p></o:p></p>
<p class="MsoNormal"> path => '/etc/ntp.conf',<o:p></o:p></p>
<p class="MsoNormal"> mode => '0640',<o:p></o:p></p>
<p class="MsoNormal"> content => template('platform/ntp.conf.server.erb'),<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">For /etc/sysconfig/ntpd, I’d like to add this custom file in ntp.pp, then we can remove related patch.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Any comment from you? Thanks!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">BTW, I saw some other packages also have pp file in stx/stx-config/puppet-manifests/src/modules/platform/manifests/<o:p></o:p></p>
<p class="MsoNormal">So I can do some modification on existed pp to change/add some config file, right?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">For SW patching scenario, it is OK for non-in-service update. After reboot, puppet will apply config again.<o:p></o:p></p>
<p class="MsoNormal">But for in-service update, without reboot, how to apply this custom file again after patching. That’s why I thought of using patching-script.<o:p></o:p></p>
<p class="MsoNormal">Do you have any other proposal?<o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify"><span style="font-size:10.5pt"><o:p> </o:p></span></p>
<p class="MsoNormal" style="text-align:justify"><span style="font-size:10.5pt">Thanks!<o:p></o:p></span></p>
<p class="MsoNormal" style="text-align:justify"><span style="font-size:10.5pt">zhipeng<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>