<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 2 6 3 5 4 5 2 3 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Don,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">%if %{with_python2}<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">%py2_build_wheel<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Well I tried running it removing the line with the macro “py2_build_wheel” and it worked<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">But whit this line on, it fails with the error message:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">libvirt-python.spec:131: bad %if condition</span><span style="font-size:11.0pt"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:black">From: </span></b><span style="color:black">"Penney, Don" <Don.Penney@windriver.com><br>
<b>Date: </b>Wednesday, October 24, 2018 at 1:38 PM<br>
<b>To: </b>"Martinez Landa, Hayde" <hayde.martinez.landa@intel.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io><br>
<b>Subject: </b>RE: Problems building on master<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I think you meant this update:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"><a href="https://review.openstack.org/#/c/612517/">https://review.openstack.org/#/c/612517/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D">I don’t understand why you’d be seeing an issue, though. It built fine in my environment, and it shouldn’t impact any %if in the spec</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt;color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif"> Martinez Landa, Hayde [mailto:hayde.martinez.landa@intel.com]
<br>
<b>Sent:</b> Wednesday, October 24, 2018 2:31 PM<br>
<b>To:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> [Starlingx-discuss] Problems building on master</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">While trying to build on master I encountered the following issue:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: patching file SPECS/libvirt-python.spec</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ‘/localdisk/designer/haydemtzl/starlingx/cgcs-root/stx/stx-integ/virt/libvirt-python/centos/patches/0001-Fix-setup-import-to-support-building-wheel.patch’ -> ‘/localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SOURCES/./0001-Fix-setup-import-to-support-building-wheel.patch’</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: SPEC file: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: SRPM build directory: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: TIS_PATCH_VER: 2</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: error: parse error in expression</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: error: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec:131: bad %if condition</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ERROR: srpm_assemble (1296): rpmbuild failed: rpmbuild -bs /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec --define='%_topdir /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild'
--define='_tis_dist .tis' --undefine=dist</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ERROR: build_dir_srpm (802): failed to assemble srpm for 'libvirt-python-4.7.0-1.fc28'</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 ERROR: reaper (1302): Failed to build src.rpm from source at 'b4'</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">######## Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Whit the help of Erich for debugging this,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">We think it come from this change [0] that affects the specific line mentioned on the error above:</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">[0]</span> <span style="font-size:11.0pt">
<a href="https://review.openstack.org/#/c/612519/">https://review.openstack.org/#/c/612519/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I was able to reproduce this in 3 diff environments, including our Jenkins automation setup.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span><o:p></o:p></p>
</div>
</body>
</html>