<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style>
<!--
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:Calibri}
@font-face
{font-family:Tahoma}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif}
a:link, span.MsoHyperlink
{color:#0563C1;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:#954F72;
text-decoration:underline}
p.msonormal0, li.msonormal0, div.msonormal0
{margin-right:0in;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
span.EmailStyle18
{font-family:"Calibri",sans-serif;
color:windowtext}
span.EmailStyle19
{font-family:"Calibri",sans-serif;
color:#1F497D}
span.EmailStyle20
{font-family:"Calibri",sans-serif;
color:windowtext}
.MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
-->
</style><style type="text/css" id="owaParaStyle">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body fpstyle="1" ocsi="0" vlink="#954F72" link="#0563C1" lang="EN-US">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<div>Hey,</div>
<div><br>
</div>
<div>For what's worth, I also saw that today in my build env.</div>
<div>I'm building in a centos lxc container.</div>
<div><br>
</div>
<div>Irina</div>
<div><br>
</div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF985375" style="direction: ltr;"><font size="2" face="Tahoma" color="#000000"><b>From:</b> Martinez Landa, Hayde [hayde.martinez.landa@intel.com]<br>
<b>Sent:</b> Wednesday, October 24, 2018 2:48 PM<br>
<b>To:</b> Penney, Don; starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> Re: [Starlingx-discuss] Problems building on master<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Don,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">%if %{with_python2}</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">%py2_build_wheel</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Well I tried running it removing the line with the macro “py2_build_wheel” and it worked</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">But whit this line on, it fails with the error message:</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">libvirt-python.spec:131: bad %if condition</span><span style="font-size:11.0pt"></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:black">From: </span></b><span style="color:black">"Penney, Don" <Don.Penney@windriver.com><br>
<b>Date: </b>Wednesday, October 24, 2018 at 1:38 PM<br>
<b>To: </b>"Martinez Landa, Hayde" <hayde.martinez.landa@intel.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io><br>
<b>Subject: </b>RE: Problems building on master</span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D">I think you meant this update:</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D"><a href="https://review.openstack.org/#/c/612517/" target="_blank" rel="noopener noreferrer">https://review.openstack.org/#/c/612517/</a></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D">I don’t understand why you’d be seeing an issue, though. It built fine in my environment, and it shouldn’t impact any %if in the spec</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt; color:#1F497D"> </span></p>
<div>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma",sans-serif">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma",sans-serif"> Martinez Landa, Hayde [mailto:hayde.martinez.landa@intel.com]
<br>
<b>Sent:</b> Wednesday, October 24, 2018 2:31 PM<br>
<b>To:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> [Starlingx-discuss] Problems building on master</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<p class="MsoNormal"><span style="font-size:11.0pt">While trying to build on master I encountered the following issue:</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: patching file SPECS/libvirt-python.spec</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ‘/localdisk/designer/haydemtzl/starlingx/cgcs-root/stx/stx-integ/virt/libvirt-python/centos/patches/0001-Fix-setup-import-to-support-building-wheel.patch’ -> ‘/localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SOURCES/./0001-Fix-setup-import-to-support-building-wheel.patch’</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: SPEC file: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: SRPM build directory: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: TIS_PATCH_VER: 2</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: error: parse error in expression</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: error: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec:131: bad %if condition</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ERROR: srpm_assemble (1296): rpmbuild failed: rpmbuild -bs /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec --define='%_topdir /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild'
--define='_tis_dist .tis' --undefine=dist</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 b4: ERROR: build_dir_srpm (802): failed to assemble srpm for 'libvirt-python-4.7.0-1.fc28'</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42 ERROR: reaper (1302): Failed to build src.rpm from source at 'b4'</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">17:09:42</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">######## Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Whit the help of Erich for debugging this,</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">We think it come from this change [0] that affects the specific line mentioned on the error above:</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">[0]</span> <span style="font-size:11.0pt">
<a href="https://review.openstack.org/#/c/612519/" target="_blank" rel="noopener noreferrer">https://review.openstack.org/#/c/612519/</a></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I was able to reproduce this in 3 diff environments, including our Jenkins automation setup.</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"> </span></p>
</div>
</div>
</div>
</div>
</body>
</html>