<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
        {font-family:Wingdings;
        panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
        {font-family:SimSun;
        panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:"\@SimSun";
        panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:#0563C1;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:#954F72;
        text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
        {mso-style-priority:34;
        margin-top:0in;
        margin-right:0in;
        margin-bottom:0in;
        margin-left:.5in;
        margin-bottom:.0001pt;
        font-size:11.0pt;
        font-family:"Calibri",sans-serif;}
span.EmailStyle17
        {mso-style-type:personal-compose;
        font-family:"Calibri",sans-serif;
        color:windowtext;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-family:"Calibri",sans-serif;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
/* List Definitions */
@list l0
        {mso-list-id:2901032;
        mso-list-type:hybrid;
        mso-list-template-ids:-1367053056 -1933017258 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
        {mso-level-start-at:0;
        mso-level-number-format:bullet;
        mso-level-text:-;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:"Calibri",sans-serif;
        mso-fareast-font-family:SimSun;}
@list l0:level2
        {mso-level-number-format:bullet;
        mso-level-text:o;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:"Courier New";}
@list l0:level3
        {mso-level-number-format:bullet;
        mso-level-text:\F0A7;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:Wingdings;}
@list l0:level4
        {mso-level-number-format:bullet;
        mso-level-text:\F0B7;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:Symbol;}
@list l0:level5
        {mso-level-number-format:bullet;
        mso-level-text:o;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:"Courier New";}
@list l0:level6
        {mso-level-number-format:bullet;
        mso-level-text:\F0A7;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:Wingdings;}
@list l0:level7
        {mso-level-number-format:bullet;
        mso-level-text:\F0B7;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:Symbol;}
@list l0:level8
        {mso-level-number-format:bullet;
        mso-level-text:o;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:"Courier New";}
@list l0:level9
        {mso-level-number-format:bullet;
        mso-level-text:\F0A7;
        mso-level-tab-stop:none;
        mso-level-number-position:left;
        text-indent:-.25in;
        font-family:Wingdings;}
ol
        {margin-bottom:0in;}
ul
        {margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">repo: cinder<o:p></o:p></p>
<p class="MsoNormal">patch commit id: 2db603a70885823413440c627cace7e3662d0a14<o:p></o:p></p>
<p class="MsoNormal">patch title: Pike Rebase: LVM thin provisioning allocation checks<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m working on upstream this patch, but I cannot reproduce the issue. It was originally submitted in year 2016. Is it still needed?<o:p></o:p></p>
<p class="MsoNormal">If so, could you please provide some info to reproduce this issue?<o:p></o:p></p>
<p class="MsoNormal">If not, I will abandon this patch.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">My experiment on this patch:<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo1"><![if !supportLists]><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">         
</span></span><![endif]><b>When I try to create snapshot, the over allocation will be captured by cinder-scheduler. The over allocation will not happen.<o:p></o:p></b></p>
<p class="MsoListParagraph"><o:p> </o:p></p>
<p class="MsoListParagraph">See:<o:p></o:p></p>
<p class="MsoListParagraph">cinder snapshot-create 8e9dba20-2c10-4334-ac51-a1c99421ddbb  --name snap3 --description desc3<o:p></o:p></p>
<p class="MsoListParagraph">stack@ceph01liang:~/cinder$ cinder snapshot-list<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+--------------------------------------+-----------+-------+------+----------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph">| ID                                   | Volume ID                            | Status    | Name  | Size | User ID                          |<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+--------------------------------------+-----------+-------+------+----------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph">| 6bf19443-9964-48a7-8094-b3345e7f5434 | 8e9dba20-2c10-4334-ac51-a1c99421ddbb | error     | snap3 | 10   | 5255f4922a4340b482b11bbbe7083ee4 |<o:p></o:p></p>
<p class="MsoListParagraph">| 887f8584-21e0-41fe-9d08-0c53d642544b | 4bfb4724-b546-4fe9-ba89-6a1f938bd4d1 | available | snap1 | 1    | 5255f4922a4340b482b11bbbe7083ee4 |<o:p></o:p></p>
<p class="MsoListParagraph">| 8dc12252-2680-4089-b134-7280f037784f | 8e9dba20-2c10-4334-ac51-a1c99421ddbb | error     | snap3 | 10   | 5255f4922a4340b482b11bbbe7083ee4 |<o:p></o:p></p>
<p class="MsoListParagraph">| fd61ff3c-4f58-4fc3-a5bd-219eb9b034a6 | 4bfb4724-b546-4fe9-ba89-6a1f938bd4d1 | available | snap2 | 1    | 5255f4922a4340b482b11bbbe7083ee4 |<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+--------------------------------------+-----------+-------+------+----------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph"><o:p> </o:p></p>
<p class="MsoListParagraph">stack@ceph01liang:~/cinder$ cinder list<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+-----------+------+------+-------------+----------+--------------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph">| ID                                   | Status    | Name | Size | Volume Type | Bootable | Attached to                          |<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+-----------+------+------+-------------+----------+--------------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph">| 25959746-7655-4cf4-a959-6ce8a80eb6fc | in-use    |      | 1    | lvmdriver-1 | true     | 4d963313-4ffc-47fc-a075-6c72082ed121 |<o:p></o:p></p>
<p class="MsoListParagraph">| 4bfb4724-b546-4fe9-ba89-6a1f938bd4d1 | available | vol1 | 1    | lvmdriver-1 | true     |                                      |<o:p></o:p></p>
<p class="MsoListParagraph">| 8e9dba20-2c10-4334-ac51-a1c99421ddbb | available | vol3 | 10   | lvmdriver-1 | true     |                                      |<o:p></o:p></p>
<p class="MsoListParagraph">| de55aad2-8424-4f2b-a769-0da85daa1889 | available | vol2 | 2    | lvmdriver-1 | true     |                                      |<o:p></o:p></p>
<p class="MsoListParagraph">+--------------------------------------+-----------+------+------+-------------+----------+--------------------------------------+<o:p></o:p></p>
<p class="MsoListParagraph"><o:p> </o:p></p>
<p class="MsoListParagraph">(Pdb) pp backends<o:p></o:p></p>
<p class="MsoListParagraph">[host 'ceph01liang@lvmdriver-1#lvmdriver-1':free_capacity_gb: 22.76, total_capacity_gb: 22.8,allocated_capacity_gb: 15, max_over_subscription_ratio: 1.0,reserved_percentage: 0, provisioned_capacity_gb: 17.0,thin_provisioning_support:
 True, thick_provisioning_support: False,pools: None,updated at: 2018-11-01 08:54:58.143006]<o:p></o:p></p>
<p class="MsoListParagraph"><o:p> </o:p></p>
<p class="MsoListParagraph" style="text-indent:-.25in;mso-list:l0 level1 lfo1"><![if !supportLists]><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">         
</span></span><![endif]><b>When I try to create a volume from a volume (a snapshot will be created during this op), what called is create_lv_snapshot, not create_snapshot. So the check in create_snapshot will not be called.<o:p></o:p></b></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal">Liang<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>