<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Penny,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for the explanation.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">This issue is tracked in link [0]. And is already fixed in “resource-agents-3.9.5-116”.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Our current version already contains the fix. So we could drop the patch safely.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">[0]: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1462802">
https://bugzilla.redhat.com/show_bug.cgi?id=1462802</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:#1F497D">Best Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Shuicheng<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Penney, Don [mailto:Don.Penney@windriver.com] <br>
<b>Sent:</b> Wednesday, November 21, 2018 10:37 PM<br>
<b>To:</b> Lin, Shuicheng <shuicheng.lin@intel.com>; Little, Scott <Scott.Little@windriver.com>; Rowsell, Brent <Brent.Rowsell@windriver.com><br>
<b>Cc:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> RE: question about create-var-run-resource-agents.patch in cluster-resource-agent<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">We can’t do this in a spec file, as /var/run is on tmpfs, so the dir would be lost on the subsequent reboot. But we do have the following:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">controller-0:~$ rpm -qf /usr/lib/tmpfiles.d/resource-agents.conf<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">resource-agents-3.9.5-124.el7.tis.12.x86_64<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">controller-0:~$ cat /usr/lib/tmpfiles.d/resource-agents.conf<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">d /var/run/resource-agents/ 1755 root root<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">So we could probably drop patch [1] and safely rely on the tmpfiles.d to create it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma",sans-serif"> Lin, Shuicheng [<a href="mailto:shuicheng.lin@intel.com">mailto:shuicheng.lin@intel.com</a>]
<br>
<b>Sent:</b> Tuesday, November 20, 2018 11:51 PM<br>
<b>To:</b> Little, Scott; Penney, Don; Rowsell, Brent<br>
<b>Cc:</b> <a href="mailto:starlingx-discuss@lists.starlingx.io">starlingx-discuss@lists.starlingx.io</a><br>
<b>Subject:</b> question about create-var-run-resource-agents.patch in cluster-resource-agent<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Scott/Penney,<o:p></o:p></p>
<p class="MsoNormal">I am looking at story [0], which want to remove patches [1] for create directory /var/run/resource-agents.<o:p></o:p></p>
<p class="MsoNormal">And I find another patch [2] disabled explicit requires the directory in spec file.<o:p></o:p></p>
<p class="MsoNormal">(#%dir %attr (1755, root, root) %{_var}/run/resource-agents)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Could you share me the history of patch [1] and [2]?<o:p></o:p></p>
<p class="MsoNormal">I prefer to add back this line in patch [2], and patch [1] could be removed without puppet replacement.<o:p></o:p></p>
<p class="MsoNormal">What’s your suggestion?<o:p></o:p></p>
<p class="MsoNormal">Thanks.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">[0]: <a href="https://storyboard.openstack.org/#!/story/2004019">
https://storyboard.openstack.org/#!/story/2004019</a><o:p></o:p></p>
<p class="MsoNormal">[1]: <a href="https://git.openstack.org/cgit/openstack/stx-integ/tree/base/cluster-resource-agents/centos/patches/create-var-run-resource-agents.patch">
https://git.openstack.org/cgit/openstack/stx-integ/tree/base/cluster-resource-agents/centos/patches/create-var-run-resource-agents.patch</a><o:p></o:p></p>
<p class="MsoNormal">[2]: <a href="https://git.openstack.org/cgit/openstack/stx-integ/tree/base/cluster-resource-agents/centos/meta_patches/spec-avoid-dir-collisions.patch">
https://git.openstack.org/cgit/openstack/stx-integ/tree/base/cluster-resource-agents/centos/meta_patches/spec-avoid-dir-collisions.patch</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best Regards<o:p></o:p></p>
<p class="MsoNormal">Shuicheng<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>