<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Matt<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> Thanks for your advises and I removed the related checks and warnings. After tests the latest version is totally compatible with old *.ini configure file.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> My patch is <a href="https://review.openstack.org/#/c/625018/">
https://review.openstack.org/#/c/625018/</a>, any further comments are welcome~ <o:p>
</o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ran<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b>From:</b> Peters, Matt [mailto:Matt.Peters@windriver.com]
<br>
<b>Sent:</b> Thursday, December 13, 2018 12:17 AM<br>
<b>To:</b> An, Ran1 <ran1.an@intel.com>; starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> Re: [Starlingx-discuss] removing link capacity configuration during controller config<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-CA">Hello Ran,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">We don’t normally maintain special handling for old parameters if they can be safely ignored. I recommend removing the checks and warnings related to this parameter.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Regards, Matt<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-CA" style="font-size:12.0pt;color:black">From:
</span></b><span lang="EN-CA" style="font-size:12.0pt;color:black">"An, Ran1" <</span><a href="mailto:ran1.an@intel.com"><span lang="EN-CA" style="font-size:12.0pt">ran1.an@intel.com</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">><br>
<b>Date: </b>Wednesday, December 12, 2018 at 11:07 AM<br>
<b>To: </b>"Peters, Matt" <</span><a href="mailto:Matt.Peters@windriver.com"><span lang="EN-CA" style="font-size:12.0pt">Matt.Peters@windriver.com</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">>, "</span><a href="mailto:starlingx-discuss@lists.starlingx.io"><span lang="EN-CA" style="font-size:12.0pt">starlingx-discuss@lists.starlingx.io</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">"
<</span><a href="mailto:starlingx-discuss@lists.starlingx.io"><span lang="EN-CA" style="font-size:12.0pt">starlingx-discuss@lists.starlingx.io</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">><br>
<b>Subject: </b>RE: [Starlingx-discuss] removing link capacity configuration during controller config<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"><o:p> </o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D">Hi Matt</span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D"> For considering of compatibility with old *.ini configure files, I kept link speed checks/warnings part in config_validator. It could be removed if nobody need the old format configure file.</span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D"> </span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D">Hi all</span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D"> If anyone need to keep link speed option in *.ini configure file, please let me know.</span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D"> </span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D">Thanks</span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D">Ran </span><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA" style="color:#1F497D"> </span><span lang="EN-CA"><o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-CA">From:</span></b><span lang="EN-CA"> Peters, Matt [</span><a href="mailto:Matt.Peters@windriver.com"><span lang="EN-CA">mailto:Matt.Peters@windriver.com</span></a><span lang="EN-CA">]
<br>
<b>Sent:</b> Wednesday, December 12, 2018 8:31 PM<br>
<b>To:</b> An, Ran1 <</span><a href="mailto:ran1.an@intel.com"><span lang="EN-CA">ran1.an@intel.com</span></a><span lang="EN-CA">>;
</span><a href="mailto:starlingx-discuss@lists.starlingx.io"><span lang="EN-CA">starlingx-discuss@lists.starlingx.io</span></a><span lang="EN-CA"><br>
<b>Subject:</b> Re: [Starlingx-discuss] removing link capacity configuration during controller config<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">The link speed checks/warnings should also be removed when the input parameter is removed since it will no longer be provided during config_controller, and therefore not available for validation.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Regards, Matt<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span lang="EN-CA" style="font-size:12.0pt;color:black">From:
</span></b><span lang="EN-CA" style="font-size:12.0pt;color:black">"An, Ran1" <</span><a href="mailto:ran1.an@intel.com"><span lang="EN-CA" style="font-size:12.0pt">ran1.an@intel.com</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">><br>
<b>Date: </b>Wednesday, December 12, 2018 at 3:57 AM<br>
<b>To: </b>"</span><a href="mailto:starlingx-discuss@lists.starlingx.io"><span lang="EN-CA" style="font-size:12.0pt">starlingx-discuss@lists.starlingx.io</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">" <</span><a href="mailto:starlingx-discuss@lists.starlingx.io"><span lang="EN-CA" style="font-size:12.0pt">starlingx-discuss@lists.starlingx.io</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">>,
"Peters, Matt" <</span><a href="mailto:Matt.Peters@windriver.com"><span lang="EN-CA" style="font-size:12.0pt">Matt.Peters@windriver.com</span></a><span lang="EN-CA" style="font-size:12.0pt;color:black">><br>
<b>Subject: </b>[Starlingx-discuss] removing link capacity configuration during controller config</span><span lang="EN-CA"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-CA">Hi All:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> I am working on bug [1] removing “link capacity of interface” configuration in config_controller, config_validator and config_gui.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Reason: the link capacity is set to 10G only when doing traffic control[2], it is unnecessary to input ‘link capacity’ during controller configure.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Impact: 1) all ‘link capacity’ related configure input option is removed.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> 2) it is compatibility with old *.ini configure file:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> when “INTERFACE_LINK_CAPACITY=10000”, it is compatible.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> For other values, you will see following errors: “Invalid link-capacity value for XXX”. Relax. Just edit “INTERFACE_LINK_CAPACITY” to 10000 and retry “config_controller”.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> Feel free to reply if you any idea about this. Any response is welcome.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">[1] </span><a href="https://bugs.launchpad.net/starlingx/+bug/1805320"><span lang="EN-CA">https://bugs.launchpad.net/starlingx/+bug/1805320</span></a><span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">[2] </span><a href="https://storyboard.openstack.org/#!/story/2003087"><span lang="EN-CA">https://storyboard.openstack.org/#!/story/2003087</span></a>
<span lang="EN-CA"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA"> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-CA">Ran<o:p></o:p></span></p>
</div>
</body>
</html>