<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style>
<!--
@font-face
{font-family:SimSun}
@font-face
{font-family:"Cambria Math"}
@font-face
{font-family:"Bookman Old Style"}
@font-face
{font-family:FangSong}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif}
a:link, span.MsoHyperlink
{color:#0563C1;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:#954F72;
text-decoration:underline}
span.EmailStyle17
{font-family:"Bookman Old Style",serif;
color:#1F4E79;
letter-spacing:0pt;
text-decoration:none none}
.MsoChpDefault
{font-family:"Calibri",sans-serif}
@page WordSection1
{margin:1.0in 1.0in 1.0in 1.0in}
-->
</style><style type="text/css" id="owaParaStyle">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body fpstyle="1" ocsi="0" vlink="#954F72" link="#0563C1" lang="EN-US">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<div>Hi Liu,</div>
<div><br>
</div>
<div>That code should work correctly as the first element in the list (index 0) is not of type 'host'.<br>
</div>
<div><br>
</div>
<div>Two notes here:</div>
<div>1. That code in <span lang="en-US"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="2" face="Courier New" color="#1F4E79"><span style="font-size:10pt;">cgcs-root/stx/stx-metal/inventory</span></font></span></font></span>
is not executed in a normal stx install as it is part of an sysinv in-progress refactoring. You should better look in
<b>cgcs-root/stx/stx-config</b>/sysinv/sysinv/sysinv/sysinv/common/ceph.py</div>
<div>2. You shouldn't bother too much with that function (<span lang="en-US"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt;"><font size="2" face="Courier New"><span style="font-size:10pt;">check_osds_down_up)</span></font></span></font></span>
as it was used at upgrades and we don't support upgrades in stx - it may get removed. Testing its output in small script (or even the python interpreter) should be enough at this stage.<br>
</div>
<div><br>
</div>
<div>Ovidiu<br>
</div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF514809" style="direction: ltr;"><font size="2" face="Tahoma" color="#000000"><b>From:</b> Liu, Changcheng [changcheng.liu@intel.com]<br>
<b>Sent:</b> Wednesday, January 23, 2019 7:37 AM<br>
<b>To:</b> Kung, John<br>
<b>Cc:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> [Starlingx-discuss] check_osds_down_up check range<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79">Hi John,</span></p>
<p class="MsoNormal" style="text-indent:12.0pt"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79">Could you help check whether there’s something wrong with below code?</span></p>
<p class="MsoNormal" style="text-indent:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New"; color:#1F4E79"> File: cgcs-root/stx/stx-metal/inventory/inventory/inventory/common/ceph.py</span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 96 def check_osds_down_up(self, hostname, upgrade):</span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 97 # check if osds from a storage are down/up</span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 98 response, body = self._ceph_api.osd_tree(body='json')</span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 99 osd_tree = body['output']['nodes']</span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 100
<b>size = len(osd_tree)</b></span></p>
<p class="MsoNormal" style="margin-left:12.0pt"><span style="font-size:10.0pt; font-family:"Courier New""> 101
<b>for i in range(1, size):</b></span></p>
<p class="MsoNormal" style="text-indent:12.0pt"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79">Is there something special reason to not range from 0? i.e. range(0, size)</span></p>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79"> </span></p>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79">B.R.</span></p>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Bookman Old Style",serif; color:#1F4E79">Changcheng</span></p>
</div>
</div>
</div>
</div>
</body>
</html>