<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle27
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle28
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle29
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle30
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle31
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1856915234;
mso-list-type:hybrid;
mso-list-template-ids:-399732350 1734270402 67698691 67698693 67698689 67698691 67698693 67698689 67698691 67698693;}
@list l0:level1
{mso-level-start-at:0;
mso-level-number-format:bullet;
mso-level-text:-;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-font-family:Calibri;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Shuicheng,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">With those two changes in place, I can now build. Thanks!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">-Jason<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Lin, Shuicheng <shuicheng.lin@intel.com> <br>
<b>Sent:</b> January 30, 2019 2:21 AM<br>
<b>To:</b> McKenna, Jason <Jason.McKenna@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Xie, Cindy <cindy.xie@intel.com>; Cabrales, Ada <ada.cabrales@intel.com><br>
<b>Cc:</b> starlingx-discuss@lists.starlingx.io<br>
<b>Subject:</b> RE: CentOS 7.6 rebase feature testing<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Jason,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for the detail sharing. I have fixed both issue with below patches:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a href="https://review.openstack.org/633870">https://review.openstack.org/633870</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a href="https://review.openstack.org/633872">https://review.openstack.org/633872</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please help have a try with it. Sorry for the trouble caused.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="color:#1F497D">Best Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Shuicheng<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> McKenna, Jason [<a href="mailto:Jason.McKenna@windriver.com">mailto:Jason.McKenna@windriver.com</a>]
<br>
<b>Sent:</b> Tuesday, January 29, 2019 10:40 PM<br>
<b>To:</b> Lin, Shuicheng <<a href="mailto:shuicheng.lin@intel.com">shuicheng.lin@intel.com</a>>; Khalil, Ghada <<a href="mailto:Ghada.Khalil@windriver.com">Ghada.Khalil@windriver.com</a>>; Xie, Cindy <<a href="mailto:cindy.xie@intel.com">cindy.xie@intel.com</a>>;
Cabrales, Ada <<a href="mailto:ada.cabrales@intel.com">ada.cabrales@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:starlingx-discuss@lists.starlingx.io">starlingx-discuss@lists.starlingx.io</a><br>
<b>Subject:</b> RE: CentOS 7.6 rebase feature testing<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Shuicheng,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Inline responses as well. Symptoms persist as of a pull done today.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">-Jason<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b>From:</b> Lin, Shuicheng <<a href="mailto:shuicheng.lin@intel.com">shuicheng.lin@intel.com</a>>
<br>
<b>Sent:</b> January 28, 2019 8:50 PM<br>
<b>To:</b> McKenna, Jason <<a href="mailto:Jason.McKenna@windriver.com">Jason.McKenna@windriver.com</a>>; Khalil, Ghada <<a href="mailto:Ghada.Khalil@windriver.com">Ghada.Khalil@windriver.com</a>>; Xie, Cindy <<a href="mailto:cindy.xie@intel.com">cindy.xie@intel.com</a>>;
Cabrales, Ada <<a href="mailto:ada.cabrales@intel.com">ada.cabrales@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:starlingx-discuss@lists.starlingx.io">starlingx-discuss@lists.starlingx.io</a><br>
<b>Subject:</b> RE: CentOS 7.6 rebase feature testing<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Jason,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please check my comments inline.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Best Regards<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Shuicheng<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b>From:</b> McKenna, Jason [<a href="mailto:Jason.McKenna@windriver.com">mailto:Jason.McKenna@windriver.com</a>]
<br>
<b>Sent:</b> Tuesday, January 29, 2019 9:18 AM<br>
<b>To:</b> Lin, Shuicheng <<a href="mailto:shuicheng.lin@intel.com">shuicheng.lin@intel.com</a>>; Khalil, Ghada <<a href="mailto:Ghada.Khalil@windriver.com">Ghada.Khalil@windriver.com</a>>; Xie, Cindy <<a href="mailto:cindy.xie@intel.com">cindy.xie@intel.com</a>>;
Cabrales, Ada <<a href="mailto:ada.cabrales@intel.com">ada.cabrales@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:starlingx-discuss@lists.starlingx.io">starlingx-discuss@lists.starlingx.io</a><br>
<b>Subject:</b> RE: CentOS 7.6 rebase feature testing<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Shuicheng, Cindy,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I am currently observing a few build issue with the f/centos76 branch +
</span><a href="https://review.openstack.org/633431">https://review.openstack.org/633431</a><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="color:#1F497D"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="color:#1F497D">The .lst file in stx-tools which downloads the Mellanox driver is currently downloading the old version, but the source code in stx-integ/networking/mellanox is assuming the new version<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:18.0pt">[lin]: could you help confirm stx-tools switched to centos76 feature branch before mirror creation? The Mellanox driver is upgraded with below patch:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:18.0pt"><a href="https://review.openstack.org/628099">https://review.openstack.org/628099</a><span style="color:#1F497D">
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> [jm] I misspoke when I said “.lst” files -- the issue is not in the downloading of package, it’s in the stx-tools/toCOPY/populate_downloads.sh script which populates the stx/downloads directory from the
downloaded packages. The script still copies the 4.3 versions (search for “extra_downloads” in the script file)<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="color:#1F497D"><span style="mso-list:Ignore">-<span style="font:7.0pt "Times New Roman"">
</span></span></span><![endif]><span style="color:#1F497D">The integrity-kmod package (stx-integ/kernel/kernel-modules/integrity) do not build – at build-rpms time, the patches cannot be applied to the source code.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:18.0pt">[lin]: do you use clean build? Could you have a try with “build-pkgs --clean integrity-kmod” and “build-pkgs integrity-kmod”?<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:18.0pt">[jm]: Clean build fails. I’ve pasted a segment of the generated error log below. It appears that the Changes-for-CentOS-7.6-support.patch is failing to apply to the code:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:18.0pt"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ cd integrity<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/0001-integrity-kcompat-support.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/0002-integrity-expose-module-params.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/0003-integrity-restrict-by-iversion.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/0004-integrity-disable-set-xattr-on-imasig.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.4-support.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.6-support.patch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">The text leading up to this was:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|diff --git a/integrity/ima/ima_crypto.c b/integrity/ima/ima_crypto.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|index 802d5d2..3371d13 100644<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|--- a/integrity/ima/ima_crypto.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|+++ b/integrity/ima/ima_crypto.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">File to patch:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">Skip this patch? [y]<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">1 out of 1 hunk ignored<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">The text leading up to this was:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|diff --git a/integrity/ima/ima_init.c b/integrity/ima/ima_init.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|index 2967d49..29b72cd 100644<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|--- a/integrity/ima/ima_init.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|+++ b/integrity/ima/ima_init.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">File to patch:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">Skip this patch? [y]<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">1 out of 1 hunk ignored<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">The text leading up to this was:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|diff --git a/integrity/ima/ima_queue.c b/integrity/ima/ima_queue.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|index d9aa5ab..9946363 100644<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|--- a/integrity/ima/ima_queue.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">|+++ b/integrity/ima/ima_queue.c<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">--------------------------<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">File to patch:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">Skip this patch? [y]<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">1 out of 1 hunk ignored<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">RPM build errors:<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">error: Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep)<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt"> Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep)<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:23.25pt">Child return code was: 1<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:18.0pt">EXCEPTION: [Error()]<o:p></o:p></p>
</div>
</div>
</body>
</html>