<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.com-google-gerrit-client-change-changescreenbinderimplgencssstyle-labeluser
{mso-style-name:com-google-gerrit-client-change-changescreen_binderimpl_gencss_style-label_user;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">When I update my patch for stx-integ, it report below errors, which causes
<o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:SimSun">“</span><span style="font-size:12.0pt;font-family:"Times New Roman",serif">Verified
<span style="color:red">-1 <span style="border:solid #EEF3F5 1.0pt;padding:1.0pt;background:#EEF3F5">Zuul”</span></span><o:p></o:p></span></p>
<p class="MsoNormal">Not sure why we have this issue now<span style="font-size:12.0pt;font-family:"Times New Roman",serif">.
<o:p></o:p></span></p>
<p class="MsoNormal">It is a common issue that I also saw in other patches submitted recently.<span style="font-size:12.0pt;font-family:"Times New Roman",serif"><o:p></o:p></span></p>
<p class="MsoNormal">Do we need a new ticket to fix this pep8 issue or just disable B009 and B010? Any comment?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="mso-element:para-border-div;border:solid #CCCCCC 1.0pt;padding:7.0pt 7.0pt 7.0pt 7.0pt;background:#FAFAFA">
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">pep8 run-test: commands[0] | flake8<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">setting PATH=/home/zuul/src/git.openstack.org/openstack/stx-integ/.tox/pep8/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">[4871] /home/zuul/src/git.openstack.org/openstack/stx-integ$ /home/zuul/src/git.openstack.org/openstack/stx-integ/.tox/pep8/bin/flake8<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/storage-topology/storage-topology/storage_topology/exec/storage_topology.py:339:50: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/storage-topology/storage-topology/storage_topology/exec/storage_topology.py:340:50: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/storage-topology/storage-topology/storage_topology/exec/storage_topology.py:345:50: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/vm-topology/vm-topology/vm_topology/exec/vm_topology.py:400:13: B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/vm-topology/vm-topology/vm_topology/exec/vm_topology.py:401:34: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/vm-topology/vm-topology/vm_topology/exec/vm_topology.py:403:13: B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/vm-topology/vm-topology/vm_topology/exec/vm_topology.py:405:13: B009 Do not call getattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">./tools/vm-topology/vm-topology/vm_topology/exec/vm_topology.py:407:13: B010 Do not call setattr with a constant attribute value, it is not any safer than normal property access.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:7.5pt;background:#FAFAFA;word-break:break-all;border:none;padding:0cm">
<span style="font-size:8.5pt;font-family:Consolas;color:#363636">ERROR: InvocationError for command /home/zuul/src/git.openstack.org/openstack/stx-integ/.tox/pep8/bin/flake8 (exited with code 1)<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks!<o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-justify:inter-ideograph"><span style="font-size:10.5pt">zhipeng<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>