<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I uploaded a fix, by clamping pylint (same as I did for 2 other repos that hit the same issue).</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a href="https://bugs.launchpad.net/starlingx/+bug/1875705">https://bugs.launchpad.net/starlingx/+bug/1875705</a><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">Your review will merge through a 'recheck' after this one merges.</span><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">If someone wants to keep pylint floating on its latest release (which could cause another break the next time one is released), they could update the 'is_ceph_healthy'
method, and/or the 2 places it is called to resolve the issue. </span><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Al</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Saul Wold <sgw@linux.intel.com><br>
<b>Sent:</b> Tuesday, April 28, 2020 12:07 PM<br>
<b>To:</b> starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io><br>
<b>Subject:</b> Re: [Starlingx-discuss] Need help with commit</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><br>
<br>
On 4/28/20 8:52 AM, Trica, Mihail-Laurentiu wrote:<br>
> Hello,<br>
> <br>
> I have made a few commits and there is just one that is up for review: <br>
> <a href="https://review.opendev.org/#/c/716554/">https://review.opendev.org/#/c/716554/</a>. I have modified the commit
<br>
> following commit review. Yang Liu has been the one that reviewed my <br>
> commit and the commits of my fellow Intel colleagues. Yang gave it a <br>
> Code Review +2 and a Workflow +1 and Zuul started its checks again. What <br>
> I can see now is that Zuul gave it a -2 because one of its pylint check <br>
> failed(logs are available HERE <br>
> <<a href="https://zuul.opendev.org/t/openstack/build/d39f574ea3bb4b9089981af9c169b294">https://zuul.opendev.org/t/openstack/build/d39f574ea3bb4b9089981af9c169b294</a>>).
<br>
> The only problem is that it had give it a +1 after I made my final <br>
> changes. Basically the history for the last patchset is this one:<br>
> <br>
> - I uploaded patchset 6, Zuul started its jobs, gave it +1<br>
> <br>
> - Yang did the code review and gave it a Code Review +2 and a Workflow +1<br>
> <br>
> - finally Zuul restarted its checks, but it had an error for the pylint <br>
> job and it gave it a -2<br>
> <br>
pylint was changed recently to a newer / stricter version that's why <br>
your getting new errors.<br>
<br>
> From the logs the error is not on any of the files that I modified in <br>
> the commit, but on: <br>
> “automated-pytest-suite/keywords/storage_helper.py:424:8: E0633: <br>
> Attempting to unpack a non-sequence defined at line 52 <br>
> (unpacking-non-sequence)”. My code is not even using storage-helper. How <br>
> can subsequent checks fail on code that has not been modified? Is there <br>
> a way to re-trigger Zuul checks? In the meantime I have rebased the commit.<br>
><br>
It's failing not because of the code you added, but because pylint is <br>
checking all the code and found an issue since it's running with <br>
stricter rules now.<br>
<br>
you can add a "recheck" reply to your commit from review.opendev.org.<br>
<br>
Hope that helps<br>
<br>
Sau!<br>
<br>
> Toate cele bune/Kind regards/Mit freundlichen <br>
> Grüßen/Cordialement/Cordiali saluti/с уважением/z poważaniem<br>
> <br>
> よろしくお願いいたします<br>
> <br>
> 此致<br>
> <br>
> 敬礼<br>
> <br>
> *Mihail-Laurenţiu Trică*, Software Engineer<br>
> <br>
> <br>
> _______________________________________________<br>
> Starlingx-discuss mailing list<br>
> Starlingx-discuss@lists.starlingx.io<br>
> <a href="http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss">
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss</a><br>
> <br>
<br>
_______________________________________________<br>
Starlingx-discuss mailing list<br>
Starlingx-discuss@lists.starlingx.io<br>
<a href="http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss">http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss</a><br>
</div>
</span></font></div>
</body>
</html>