<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">From you comment, I have one concern. Kickstart will remove boot device and rootfs vg, lv and pv.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">In currently ks script, it will only check “vda vdb sda sdb dda ddb hda hdb nvme0n1 nvme1n1” in /dev/<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">But if user add host by such command, “system host-add -n <host name> -m <mgm mac> -b sdc -r sdd”, by set boot device as sdc and rootfs as sdd.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Ks will not remove vg and lv on these disk.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">BR!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">Martin, Chen<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">IOTG, Software Engineer<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">021-61164330<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> Chen, Haochuan Z
<br>
<b>Sent:</b> Wednesday, October 14, 2020 12:06 PM<br>
<b>To:</b> 'Poncea, Ovidiu' <Ovidiu.Poncea@windriver.com>; Hu, Yong <yong.hu@intel.com>; Sun, Austin <austin.sun@intel.com><br>
<b>Cc:</b> Penney, Don <Don.Penney@windriver.com>; Waines, Greg <Greg.Waines@windriver.com>; Jones, Bruce E <bruce.e.jones@intel.com><br>
<b>Subject:</b> RE: please review this patch - https://review.opendev.org/#/c/737228/ for Rook-Ceph<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks Ovidiu! I updated patch.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Currently for rook, rook backup and restore only support not wipe osd.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">For rook, there is a rook-ceph-operator, which manage all the ceph cluster, such as launching mon, mgr, osd deployment, creating cephfs filesystem, pool and manage crushmap.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">So during restore, after k8s cluster restore, it will restore rook-ceph-operator’s status, which means re-deploy mon, mgr and osd deployment as it used to be, such restore is operator’s behavior, not by starlingx.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">If osd disk wiped, osd pods will launch fail.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">If force rook-ceph restore to enable wipe-osd, so there will be such process.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">1, ansible restore k8s cluster (launch by starlingx)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">2, k8s cluster resotre rook-ceph-operator(by k8s cluster)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">3, rook-ceph-operator re-deploy osd pod, and launch fail<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">4, ansible restore script, read rook-ceph-operator status about osd deployment and cleanup these info and request rook-ceph-operator to exit osd deployment<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">5, ansible restore script, use read osd deployment info to re-launch osd-prepare job to initialization and launch osd deployment by rook-ceph-operator.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I prefer rook-ceph only support not wipe osd case. If user want to wipe osd disk, they can remove rook-ceph application after restore.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">BR!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">Martin, Chen<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">IOTG, Software Engineer<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">021-61164330<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> Poncea, Ovidiu <<a href="mailto:Ovidiu.Poncea@windriver.com">Ovidiu.Poncea@windriver.com</a>>
<br>
<b>Sent:</b> Tuesday, October 13, 2020 5:34 PM<br>
<b>To:</b> Hu, Yong <<a href="mailto:yong.hu@intel.com">yong.hu@intel.com</a>>; Sun, Austin <<a href="mailto:austin.sun@intel.com">austin.sun@intel.com</a>><br>
<b>Cc:</b> Penney, Don <<a href="mailto:Don.Penney@windriver.com">Don.Penney@windriver.com</a>>; Waines, Greg <<a href="mailto:Greg.Waines@windriver.com">Greg.Waines@windriver.com</a>>; Jones, Bruce E <<a href="mailto:bruce.e.jones@intel.com">bruce.e.jones@intel.com</a>>;
Chen, Haochuan Z <<a href="mailto:haochuan.z.chen@intel.com">haochuan.z.chen@intel.com</a>><br>
<b>Subject:</b> RE: please review this patch - <a href="https://review.opendev.org/#/c/737228/">
https://review.opendev.org/#/c/737228/</a> for Rook-Ceph<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;mso-fareast-language:EN-US">Done, sorry for the required rework, we must be careful with this area as issues can be very problematic.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt">From:</span></b><span style="font-size:11.0pt"> Hu, Yong <<a href="mailto:yong.hu@intel.com">yong.hu@intel.com</a>>
<br>
<b>Sent:</b> marți, 13 octombrie 2020 04:19<br>
<b>To:</b> Poncea, Ovidiu <<a href="mailto:Ovidiu.Poncea@windriver.com">Ovidiu.Poncea@windriver.com</a>>; Sun, Austin <<a href="mailto:austin.sun@intel.com">austin.sun@intel.com</a>><br>
<b>Cc:</b> Penney, Don <<a href="mailto:Don.Penney@windriver.com">Don.Penney@windriver.com</a>>; Waines, Greg <<a href="mailto:Greg.Waines@windriver.com">Greg.Waines@windriver.com</a>>; Jones, Bruce E <<a href="mailto:bruce.e.jones@intel.com">bruce.e.jones@intel.com</a>>;
Chen, Haochuan Z <<a href="mailto:haochuan.z.chen@intel.com">haochuan.z.chen@intel.com</a>><br>
<b>Subject:</b> please review this patch - <a href="https://review.opendev.org/#/c/737228/">
https://review.opendev.org/#/c/737228/</a> for Rook-Ceph<br>
<b>Importance:</b> High<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-GB"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Hi Ovidiu,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Could you please review this patch? Don wanted to get your feedback back to Sept 14 in order to move forward for merge.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><a href="https://review.opendev.org/#/c/737228/">https://review.opendev.org/#/c/737228/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">If you have any concerns, <a id="OWAAM9FBAE5DA9E0376409681E43EFB3D5BF6" href="mailto:austin.sun@intel.com">
<span style="font-family:"Calibri",sans-serif;text-decoration:none">@Sun, Austin</span></a> will book a half-hour meeting today (in your morning).<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Yong<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>