Dean - for larger changes, do you recommend we adopt a spec writing (Blueprint) process? If so, how would that be done? brucej -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Thursday, June 21, 2018 8:21 AM To: Arce Moreno, Abraham <abraham.arce.moreno@intel.com> Cc: Jones, Bruce E <bruce.e.jones@intel.com>; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Proposal: Basic development guidelines / rules On Wed, Jun 20, 2018 at 10:14 PM, Arce Moreno, Abraham <abraham.arce.moreno@intel.com> wrote:
What is the usual way in OpenStack to review a proposal of a change?
You push it to Gerrit. Often times people will put [WIP] at the beginning of the commit message to indicate it is not ready to be merged but you want comments or want to run the test jobs against it. There is also the "Workflow -1" (aka -W) that you can put on your own review that has the same effect. And comments are always helpful to clarify intent. Except for the -W part we can do exactly the same thing in the github repos. dt -- Dean Troyer dtroyer@gmail.com