On Mon, Nov 12, 2018 at 3:19 AM Saul Wold <sgw@linux.intel.com> wrote:
Folks,
I noticed something today when I was reviewing one of the refactor patches and it got me thinking (which is never a good thing when jet-lagged).
Why don't we use the RPM macro %{_bindir} which is /usr/bin by default?
I am not very fan of RPM macros , whoever for the multi OS target that we have it might work :) +1 from my side
I did a quick grep in the spec files and patches for spec files and found that we current use systemctl, /bin/systemctl and /usr/bin/systemctl. Not all OSes have a /bin/systemctl, so this might fail later.
I am going to recommend that we have a standard of using the RPM macros when calling executables inside of RPM Spec files so that we have some consistency.
I am not saying we should to a mass find/replace right now, but as we touch/update move to a consistent format, this will help later with multi-os.
If needed we can get a specification written around this concept.
Thoughts, flames?
Sau!
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss