Hello Kailun,

I agree that the change looks like it should address the same issue.  The change from e5712fe may have been carried forward between rebases without realizing that it was addressed on the server side.

Have you retested the scenario without the change for e5712fe?  If things are working as expected, than it can be dropped.

Regards, Matt

From: "Qin, Kailun" <kailun.qin@intel.com>
Date: Friday, October 12, 2018 at 6:33 AM
To: "Peters, Matt" <Matt.Peters@windriver.com>
Cc: "Le, Huifeng" <huifeng.le@intel.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io>
Subject: Question about patch upstreaming for e5712fe

Hi Matt,

We’re looking into the patch e5712fe, which indicates a possible inconsistency/mismatch of tag values between dnsmasq option files and dnsmasq command line.

From the commit message: “This seems to be happening because of how dhcp_rpc.py::_group_by_network_id would behave if the list of subnets coming from the database was ordered different or contained different values.” After checking, we found that the latest Neutron seems to already have subnets sorted: https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/dhcp_rpc.py#L150L154.

Would you please kindly help double check on this? Let me know if any question. Thank you!

BR,

Kailun