Hi Scott .

         For your modification of this code: https://review.opendev.org/730122

In the case of kmods without any source code changes, why we need to change the version number of kmods,

According to normal development guidelines, we believe that the version info should not be modified.

 

         We understand the macro value of TIS_PATCH_VER, which marks kmod's own change information,

It is not prepared for other modules changes. Looking forward to your review.

We sincerely thanks for your hard work for the community. nice friend 🤝

 

 

Best Regards

----------------------

From: Neusoft - Shuai

 

-----邮件原件-----
发件人: Scott Little <scott.little@windriver.com>
发送时间: 2020522 4:49
收件人: Saul Wold <saul.wold@intel.com>; Jascanu, Nicolae <nicolae.jascanu@intel.com>; Penney, Don <Don.Penney@windriver.com>; Miller, Frank <Frank.Miller@windriver.com>; starlingx-discuss@lists.starlingx.io
主题: Re: [Starlingx-discuss] FW: StarlingX - fails at setup

 

Posted review https://review.opendev.org/730122 to implement the short term fix

 

Scott

 

 

On 2020-05-21 4:34 p.m., Scott Little wrote:

> The update that broke layered build was

> https://review.opendev.org/#/c/727908

> 

> It upversioned the kernels, but failed to follow the guidance to

> upversion all external kmods.

> 

> Build avoidance is in use for layered builds, seeing no source or

> metadata changes for the kmod, it elected to reuse the previous build

> of the kmod.  The previous kmod is only valid for the previous kernel

> due to embedded paths that include the kernel version.  A kernel/kmod

> mismatch that results in unusable kmods, no network drivers, and an

> install failure on many pieces of hardware.

> 

> Build avoidance is not in use for the monolithic build.

> 

> Short term fix.  Upversion the kmods

 

_______________________________________________

Starlingx-discuss mailing list

Starlingx-discuss@lists.starlingx.io

http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss

---------------------------------------------------------------------------------------------------
Confidentiality Notice: The information contained in this e-mail and any accompanying attachment(s)
is intended only for the use of the intended recipient and may be confidential and/or privileged of
Neusoft Corporation, its subsidiaries and/or its affiliates. If any reader of this communication
is not the intended recipient,unauthorized use,forwarding, printing, storing, disclosure or copying
is strictly prohibited, and may be unlawful.If you have received this communication in error,please
immediately notify the sender by return e-mail, and delete the original message and all copies from
your system. Thank you.
---------------------------------------------------------------------------------------------------