Is it possible to add a zuul check to look for this malformed tag ? and also warn the committer about use of deprecated tags?

Dariush

From: Penney, Don [mailto:Don.Penney@windriver.com]
Sent: November-12-19 1:15 PM
To: 'starlingx-discuss@lists.starlingx.io' (starlingx-discuss@lists.starlingx.io) <starlingx-discuss@lists.starlingx.io>
Subject: [Starlingx-discuss] Malformed Depends-On tag can cause unexpected merge

Hi all,

Please be careful when adding dependencies to your commit messages to ensure the formatting is correct. If it is not, then Gerrit/Zuul may not properly handle the dependency and allow a commit to merge before the dependency is merged. It appears that a space is mandatory after the “Depends-On:” tag.

Proper formatting:

Depends-On: https://review.opendev.org/XXXXXX

Improper:

Depends-On:https://review.opendev.org/XXXXXX

We saw updates merge this morning prematurely, apparently due to a commit message that was missing this space after the Depends-On tag.

As a side note, I believe the syntax of “Depends-On: CHANGE-ID” is deprecated, maybe due to the potential for CHANGE-ID matching multiple reviews. The suggested syntax is to use the Gerrit review URL.

Cheers,

Don.

Don Penney, Developer, Wind River