Saul wrote:
While editing the kernel cmdline is a workaround for this issue, does it also make sense to have a launchpad issue and work to fix the logic in selecting an appropriate boot/rootfs device target.
+1 this sounds like a great idea! -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Tuesday, March 12, 2019 5:24 PM To: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] about NVME disk as the boot disk On 3/12/19 6:54 AM, Penney, Don wrote:
Hi Yong,
Please see the following reference:
https://docs.starlingx.io/installation_guide/index.html#nvme-drive-as- boot-drive
Edit the kernel boot parameter. After you are presented with the StarlingX ISO boot options and after you have selected the preferred installation option (e.g. Standard Configuration / All-in-One Controller Configuration), press the TAB key to edit the Kernel boot parameters. Modify the *boot_device* and *rootfs_device* from the default *sda* so that it is the correct device name for the NVMe drive (e.g. “nvme0n1”).
While editing the kernel cmdline is a workaround for this issue, does it also make sense to have a launchpad issue and work to fix the logic in selecting an appropriate boot/rootfs device target. There already is some logic to check for a USB device and fail out, so why not move that into the loop and have it auto detect nvme devices. Another option would be to change the ordering in pre_disk_setup_common code. Sau!
Cheers,
Don.
*From:*Hu, Yong [mailto:yong.hu@intel.com] *Sent:* Tuesday, March 12, 2019 8:51 AM *To:* starlingx-discuss@lists.starlingx.io *Subject:* [Starlingx-discuss] about NVME disk as the boot disk
Hi folks,
I was installing StarlingX in a NUC with 2 NVME disks (without other HD or SATA disks), and the installation was ended up with an issue as follows:
“ERROR: Specified installation (sda) or boot (sda) device is a USB drive.”
It seemed NVME disk was not recognized as valid boot disk.
With the help from @Saul, we found in “bsp-files/grub.cfg”, “boot_device” and “rootfs_device” were by default set as “sda” in ks cmdline:
/linuxefi /vmlinuz inst.ks=hd:LABEL=oe_iso_boot:/smallsystem_ks.cfg boot_device=sda rootfs_device=sda biosdevname=0 usbcore.autosuspend=-1 console=tty0 inst.text inst.stage2=hd:LABEL=oe_iso_boot inst.gpt security_profile=standard user_namespace.enable=1/
So, there are 2 ways to make NVME disks work as boot disk:
1. to change the grub cmdline, with “nvme0n1” for “rootfs_device” and “boot_device” accordingly, during the installation. 2. Not to set “rootfs_device” and “boot_device” in ks cmdline, and let “bsp-files/kickstarts/pre_disk_setup_common.cfg” detect “nvme0n1” dynamically.
Though, I wonder if there are other better ways in such a case.
Regards,
Yong
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss