Thanks Dan and John review for my patch. I already update and verified for review comment. Welcome more review idea!
https://review.opendev.org/c/starlingx/config/+/720637 https://review.opendev.org/c/starlingx/rook-ceph/+/771741
Thanks!
Martin, Chen IOTG, Software Engineer 021-61164330
From: Chen, Haochuan Z Sent: Friday, January 22, 2021 4:05 PM To: 'Bailey, Henry Albert (Al)' Al.Bailey@windriver.com; 'Bart Wensley' barton.wensley@windriver.com; 'Church, Robert' Robert.Church@windriver.com; 'Chris Friesen' chris.friesen@windriver.com; 'Penney, Don' Don.Penney@windriver.com; 'Kung, John' John.Kung@windriver.com; 'Waines, Greg' Greg.Waines@windriver.com; 'Voiculeasa, Dan' Dan.Voiculeasa@windriver.com Cc: Sun, Austin austin.sun@intel.com; Hu, Yong yong.hu@intel.com; Jones, Bruce E bruce.e.jones@intel.com; 'starlingx-discuss@lists.starlingx.io' starlingx-discuss@lists.starlingx.io Subject: RE: review patch to enable rook-ceph in config project.
Thanks Dan review for my patch. Welcome more review idea!
https://review.opendev.org/c/starlingx/config/+/720637 https://review.opendev.org/c/starlingx/rook-ceph/+/771741
Thanks!
Martin, Chen IOTG, Software Engineer 021-61164330
From: Chen, Haochuan Z Sent: Thursday, January 21, 2021 10:32 PM To: 'Bailey, Henry Albert (Al)' <Al.Bailey@windriver.commailto:Al.Bailey@windriver.com>; 'Bart Wensley' <barton.wensley@windriver.commailto:barton.wensley@windriver.com>; 'Church, Robert' <Robert.Church@windriver.commailto:Robert.Church@windriver.com>; 'Chris Friesen' <chris.friesen@windriver.commailto:chris.friesen@windriver.com>; 'Penney, Don' <Don.Penney@windriver.commailto:Don.Penney@windriver.com>; 'Kung, John' <John.Kung@windriver.commailto:John.Kung@windriver.com>; 'Waines, Greg' <Greg.Waines@windriver.commailto:Greg.Waines@windriver.com>; 'Voiculeasa, Dan' <Dan.Voiculeasa@windriver.commailto:Dan.Voiculeasa@windriver.com> Cc: Sun, Austin <austin.sun@intel.commailto:austin.sun@intel.com>; Hu, Yong <yong.hu@intel.commailto:yong.hu@intel.com>; Jones, Bruce E <bruce.e.jones@intel.commailto:bruce.e.jones@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.iomailto:starlingx-discuss@lists.starlingx.io> Subject: RE: review patch to enable rook-ceph in config project.
Hi Bob and Dan
I update patch for story about lifecycle. And finish verification.
https://review.opendev.org/c/starlingx/config/+/720637 https://review.opendev.org/c/starlingx/rook-ceph/+/771741
1, add lifecycle for rook-ceph 2, add a function in sysinv-conductor, update_config_for_rook_ceph, which is called in application rook-ceph hook function, in operation post stage 3, cleanup some code as function already move to rook-ceph application's hook
Thanks!
Martin, Chen IOTG, Software Engineer 021-61164330
From: Chen, Haochuan Z Sent: Tuesday, January 19, 2021 9:03 PM To: Bailey, Henry Albert (Al) <Al.Bailey@windriver.commailto:Al.Bailey@windriver.com>; Bart Wensley <barton.wensley@windriver.commailto:barton.wensley@windriver.com>; Church, Robert <Robert.Church@windriver.commailto:Robert.Church@windriver.com>; Chris Friesen <chris.friesen@windriver.commailto:chris.friesen@windriver.com>; Penney, Don <Don.Penney@windriver.commailto:Don.Penney@windriver.com>; Kung, John <John.Kung@windriver.commailto:John.Kung@windriver.com>; Waines, Greg <Greg.Waines@windriver.commailto:Greg.Waines@windriver.com> Cc: Sun, Austin <austin.sun@intel.commailto:austin.sun@intel.com>; Hu, Yong <yong.hu@intel.commailto:yong.hu@intel.com>; Jones, Bruce E <bruce.e.jones@intel.commailto:bruce.e.jones@intel.com>; starlingx-discuss@lists.starlingx.iomailto:starlingx-discuss@lists.starlingx.io Subject: RE: review patch to enable rook-ceph in config project.
Hi
Thanks, John, AL and Penny review for my patch. I l already updated and make verification.
Please go on review my patch for config project https://review.opendev.org/c/starlingx/config/+/720637
Thanks
Martin, Chen IOTG, Software Engineer 021-61164330
From: Chen, Haochuan Z Sent: Monday, December 7, 2020 2:02 PM To: 'Bailey, Henry Albert (Al)' <Al.Bailey@windriver.commailto:Al.Bailey@windriver.com>; 'Bart Wensley' <barton.wensley@windriver.commailto:barton.wensley@windriver.com>; 'Church, Robert' <Robert.Church@windriver.commailto:Robert.Church@windriver.com>; 'Chris Friesen' <chris.friesen@windriver.commailto:chris.friesen@windriver.com>; 'Penney, Don' <Don.Penney@windriver.commailto:Don.Penney@windriver.com>; 'Kung, John' <John.Kung@windriver.commailto:John.Kung@windriver.com>; 'Waines, Greg' <Greg.Waines@windriver.commailto:Greg.Waines@windriver.com> Cc: Sun, Austin <austin.sun@intel.commailto:austin.sun@intel.com>; Hu, Yong <yong.hu@intel.commailto:yong.hu@intel.com>; Jones, Bruce E <bruce.e.jones@intel.commailto:bruce.e.jones@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.iomailto:starlingx-discuss@lists.starlingx.io> Subject: review patch to enable rook-ceph in config project.
Hi folks
Please review my patch and bob patch to enable rook-ceph in config project. https://review.opendev.org/c/starlingx/config/+/720637 https://review.opendev.org/c/starlingx/config/+/758935
BR!
Martin, Chen IOTG, Software Engineer 021-61164330