Hi Don,

%if %{with_python2}

CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build

%py2_build_wheel

Well I tried running it removing the line with the macro “py2_build_wheel” and it worked

But whit this line on, it fails with the error message:

libvirt-python.spec:131: bad %if condition

From: "Penney, Don" <Don.Penney@windriver.com>
Date: Wednesday, October 24, 2018 at 1:38 PM
To: "Martinez Landa, Hayde" <hayde.martinez.landa@intel.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io>
Subject: RE: Problems building on master

I think you meant this update:

https://review.openstack.org/#/c/612517/

I don’t understand why you’d be seeing an issue, though. It built fine in my environment, and it shouldn’t impact any %if in the spec

From: Martinez Landa, Hayde [mailto:hayde.martinez.landa@intel.com]
Sent: Wednesday, October 24, 2018 2:31 PM
To: starlingx-discuss@lists.starlingx.io
Subject: [Starlingx-discuss] Problems building on master

While trying to build on master I encountered the following issue:

17:09:42 b4: patching file SPECS/libvirt-python.spec

17:09:42 b4: ‘/localdisk/designer/haydemtzl/starlingx/cgcs-root/stx/stx-integ/virt/libvirt-python/centos/patches/0001-Fix-setup-import-to-support-building-wheel.patch’ -> ‘/localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SOURCES/./0001-Fix-setup-import-to-support-building-wheel.patch’

17:09:42 b4: SPEC file: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec

17:09:42 b4: SRPM build directory: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild

17:09:42 b4: TIS_PATCH_VER: 2

17:09:42 b4: error: parse error in expression

17:09:42 b4: error: /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec:131: bad %if condition

17:09:42 b4: ERROR: srpm_assemble (1296): rpmbuild failed: rpmbuild -bs /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild/SPECS/libvirt-python.spec --define='%_topdir /localdisk/loadbuild/haydemtzl/starlingx/std/srpm_assemble/libvirt-python/rpmbuild' --define='_tis_dist .tis' --undefine=dist

17:09:42 b4: ERROR: build_dir_srpm (802): failed to assemble srpm for 'libvirt-python-4.7.0-1.fc28'

17:09:42 ERROR: reaper (1302): Failed to build src.rpm from source at 'b4'

17:09:42

######## Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1

Wed Oct 24 17:09:42 UTC 2018: build-srpm-parallel --std failed with rc=1

Whit the help of Erich for debugging this,

We think it come from this change [0] that affects the specific line mentioned on the error above:

[0] https://review.openstack.org/#/c/612519/

I was able to reproduce this in 3 diff environments, including our Jenkins automation setup.