Hi Jason,
Thanks very much for such detail feedback.
I added some comments inline, and will check the issue in my environment also.
Feel free to submit patch if you have to fix them.
J
Best Regards
Shuicheng
From: McKenna, Jason [mailto:Jason.McKenna@windriver.com]
Sent: Saturday, September 8, 2018 3:47 AM
To: McKenna, Jason <Jason.McKenna@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Lin, Shuicheng <shuicheng.lin@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io>; Xie, Cindy <cindy.xie@intel.com>; Waheed,
Numan <Numan.Waheed@windriver.com>
Subject: RE: CentOS 7.5 upgrade status update
Hi Shuicheng,
I’ve completed a build of the code. We have not yet run run-time tests, but here are the build-time issues I encountered:
-
The .lst file contains lighttpd-1.4.49, but this is no longer available for download, and the download_mirrors.sh step fails. It appears than CentOS has updated to lighttpd-1.4.50. I manually built
a lighttpd-1.4.49-1.src.rpm to satisfy the .lst
-
Even though the .lst file specifies lighttpd-1.4.49, the code still references 1.4.45
-
At build-pkgs time (the build-srpms step), the meta-patches to openstack-aodh do not apply, as two of them are malformed.
https://review.openstack.org/#/c/598388/6/openstack/openstack-aodh/centos/meta_patches/0001-Modify-service-files-and-create-expirer-cron-script.patch -- In the new version, on line 190, the patch states that the old code covered 6 lines, and the new code
covers 9 lines (-283,6 +286,9). But there are only two lines inserted by the patch. There is also a new blank line in the patch at line 194. Removing this blank line and editing the hunk description to only insert 2 lines resolves the issue for this hunk
(there are other similar issues in this patch, and in 0001-meta-modify-aodh-api.patch)
[slin14]: Let me double check it.
-
At binary build time, I had build failures on python-django-horizon and some magnum packages. I had to pull in
https://review.openstack.org/#/c/596855/2 (from the master branch, but not in the centos75 branch of stx-upstream) to get past this.
[slin14]: It is due to I have not synced latest master code, so I don’t have this issue. I used last week’s master code.
-
After building all packages, I attempted to build the ISO. The tpm2-tss-1.3.0-2.el7.x86_64.rpm package were missing, and should be added to the .lst files.
[slin14]: This package is already in the lst.
-
Furthermore, the tpm2-tools package was requesting version tpm2-tss-1.3.0-2.el7.centos (rather than tpm2-tss-1.3.0-2.el7). I hacked the spec file for tpm2-tools and rebuilt it to require the version
mentioned, but there is some rework to be done there.
[slin14]: I have the same issue also. Let’s further check it to find the root cause. I use rebuild tpm2-tools/tss2 to workaround it without any code.
After these changes, I was able to produce a .iso
-Jason
From: McKenna, Jason <Jason.McKenna@windriver.com>
Sent: September 7, 2018 10:08 AM
To: Khalil, Ghada <Ghada.Khalil@windriver.com>; Lin, Shuicheng <shuicheng.lin@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io>;
Xie, Cindy <cindy.xie@intel.com>; Waheed, Numan <Numan.Waheed@windriver.com>
Subject: Re: [Starlingx-discuss] CentOS 7.5 upgrade status update
Hi Shuicheng,
As a download_mirrors.sh time issue, the version of lighttpd has been changed from 1.4.45 to 1.4.49. The lighttpd-1.4.49-1.el7.src.rpm file no longer exists on EPEL or CentOS servers, as they’ve moved to 1.4.50.
I am attempting to locate an archived version of the 1.4.49 .src rpm.
-Jason
From: Khalil, Ghada <Ghada.Khalil@windriver.com>
Sent: September 7, 2018 9:36 AM
To: Lin, Shuicheng <shuicheng.lin@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io>; Xie, Cindy <cindy.xie@intel.com>;
Waheed, Numan <Numan.Waheed@windriver.com>
Subject: Re: [Starlingx-discuss] CentOS 7.5 upgrade status update
Thanks Shuicheng. We’ll run some tests in Wind River. Numan will be priming this activity. He’ll share the results with the team sometime next week.
Regards,
Ghada
From: Lin, Shuicheng [mailto:shuicheng.lin@intel.com]
Sent: Friday, September 07, 2018 1:32 AM
To: 'starlingx-discuss@lists.starlingx.io'; Khalil, Ghada; Xie, Cindy
Subject: CentOS 7.5 upgrade status update
Hi all,
Most task of CentOS7.5 upgrade in
story 2003389 is done. Please go ahead to have a try and verify it.
I expect there should be some issue due to we just did limited deploy test yet.
Here is the detail status update of this week.
For the total 44 srpm we plan to upgrade:
38 already merged in feature branch.
3 kept as original version.
Anaconda upgrade is not needed. python-os-vif
has higher version than 7.5. python-eventlet
kept due to new src rpm itself have known issue.
2 under review with code ready.
Puppet-haproxy and openstack-aodh.
1 under debug. Lighttpd.
Besides srpm, we also upgraded 260+ rpm packages to 7.5 version.
Here is the build instruction:
1.
Switch to
f/centos75 branch for stx-tools/stx-integ/stx-upstream/stx-root.
Cherry-pick below un-merged patch:
For puppet-haproxy:
https://review.openstack.org/600369
https://review.openstack.org/600359
For openstack-aodh:
https://review.openstack.org/598388
https://review.openstack.org/600591
For build-iso:
https://review.openstack.org/599892
For build-pkgs:
https://review.openstack.org/599901
https://review.openstack.org/600639
2.
Run mirror script to get the upgraded src rpm and related rpm.
3.
Try to build packages and ISO.
For the detail status of CentOS7.5 upgrade, please check below story:
https://storyboard.openstack.org/#!/story/2003389
Feel free to contact me if you have trouble on it.
Best Regards
Shuicheng