On 2018-12-05 9:51 a.m., Dean Troyer wrote:
On Tue, Dec 4, 2018 at 3:13 PM Jim Somerville <jim.somerville@windriver.com> wrote:
The update to 3.0.0 consists of two parts, a pull request for the stx-qemu repo, and the piece in stx-integ which deals with the compilation. Like last time with libvirt, we have to commit these two parts at the same time.
Since the 3.0 work is going in to a new branch I think we are OK to go ahead and commit that to stx-qemu before the stx-integ change unless I am forgetting something? It will be the change to stx-manifest switching to the new branch that will need to be coordinated with 622583 in stx-integ and that can be done with a Depends-On footer.
That's correct, the branch creation is fine, it is the switching over to it that has to be coordinated.
The new qemu is here, and I will push a new branch and issue a pull request to it once I'm done dealing with feedback. https://github.com/jsomervi/stx-qemu/commits/working-3.0.0-noavp-12
I have created stx-qemu branch stx/v3.0.0 from upstream qemu at sha 38441756b70eec5807b5f60dad11a93a91199866 "Update version for v3.0.0 release", matching what you have in [0]. Target your PRs at that and we should be good to go.
Thanks, will do.
The stx-integ part for review is here: https://review.openstack.org/#/c/622583/
As I mentioned above, we should also queue up a review to stx-manifest that adds revision="stx/v3.0.0" to stx-qemu. This should depend on 622583 and be +W before 622583, it will go through the gate test but be blocked from merging until 622583 merges so the window between them merging will be fairly small.
OK, I'll go ahead and do that. -Jim
dt
[0] https://review.openstack.org/#/c/622583/1/virt/qemu/centos/build_srpm.data