I don't understand why we would mark this patch "Abandoned". If the code is not required, then it should be deleted and marked as "deleted", no? Regards JimE -----Original Message----- From: starlingx-discuss-request@lists.starlingx.io [mailto:starlingx-discuss-request@lists.starlingx.io] Sent: Tuesday, November 06, 2018 9:39 AM To: starlingx-discuss@lists.starlingx.io Subject: Starlingx-discuss Digest, Vol 6, Issue 20 Send Starlingx-discuss mailing list submissions to starlingx-discuss@lists.starlingx.io To subscribe or unsubscribe via the World Wide Web, visit http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss or, via email, send a message with subject or body 'help' to starlingx-discuss-request@lists.starlingx.io You can reach the person managing the list at starlingx-discuss-owner@lists.starlingx.io When replying, please edit your Subject line so it is more specific than "Re: Contents of Starlingx-discuss digest..." Today's Topics: 1. Re: Analysis of patch 294a63c for StarlingX Upstreaming (Badea, Daniel) 2. Re: Analysis of patch 294a63c for StarlingX Upstreaming (Fang, Liang A) 3. Re: Analysis of patch 039705e for StarlingX upstreaming (Qin, Kailun) ---------------------------------------------------------------------- Message: 1 Date: Tue, 6 Nov 2018 14:02:47 +0000 From: "Badea, Daniel" <Daniel.Badea@windriver.com> To: "Fang, Liang A" <liang.a.fang@intel.com>, "Poncea, Ovidiu" <Ovidiu.Poncea@windriver.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Analysis of patch 294a63c for StarlingX Upstreaming Message-ID: <9174DAE490321844AE273F6AD001E3EA9D804C36@ALA-MBD.corp.ad.wrs.com> Content-Type: text/plain; charset="windows-1252" Hi Liang, No objections here, mark this patch as abandoned. Regards, Daniel ________________________________ From: Fang, Liang A [liang.a.fang@intel.com] Sent: Tuesday, November 06, 2018 10:55 To: Badea, Daniel; Poncea, Ovidiu Cc: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] Analysis of patch 294a63c for StarlingX Upstreaming Hi Daniel and Ovidiu Repo: cinder Commit: 294a63c821233e3307f142965f366e8eb3d0c1de Title: Pike Rebase: Fix Cinder memory leak This patch is to call novaclient’s API “set_timings_max_len”, to limit the max timing logs, so that the log list will not be to huge. But novaclient(both the upstream version and stx- version) don’t contain the API set_timings_max_len, I also cannot find in repo history. It seems this patch may co-worked with some private version of novaclient previously, but not the public version. In fact current novaclient contains an API “reset_timings” which can be called to purge the timing logs. I want to mark this patch as abandoned, do you have any comments? Regards Liang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181106/4ba310e8/attachment-0001.html> ------------------------------ Message: 2 Date: Tue, 6 Nov 2018 14:17:29 +0000 From: "Fang, Liang A" <liang.a.fang@intel.com> To: "Badea, Daniel" <Daniel.Badea@windriver.com>, "Poncea, Ovidiu" <Ovidiu.Poncea@windriver.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Analysis of patch 294a63c for StarlingX Upstreaming Message-ID: <C9290FC03A9EED4B8F7FA2B8265C7CA875D34CAB@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset="utf-8" Thanks Daniel. Regards Liang From: Badea, Daniel [mailto:Daniel.Badea@windriver.com] Sent: Tuesday, November 6, 2018 10:03 PM To: Fang, Liang A <liang.a.fang@intel.com>; Poncea, Ovidiu <Ovidiu.Poncea@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: [Starlingx-discuss] Analysis of patch 294a63c for StarlingX Upstreaming Hi Liang, No objections here, mark this patch as abandoned. Regards, Daniel ________________________________ From: Fang, Liang A [liang.a.fang@intel.com] Sent: Tuesday, November 06, 2018 10:55 To: Badea, Daniel; Poncea, Ovidiu Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] Analysis of patch 294a63c for StarlingX Upstreaming Hi Daniel and Ovidiu Repo: cinder Commit: 294a63c821233e3307f142965f366e8eb3d0c1de Title: Pike Rebase: Fix Cinder memory leak This patch is to call novaclient's API "set_timings_max_len", to limit the max timing logs, so that the log list will not be to huge. But novaclient(both the upstream version and stx- version) don't contain the API set_timings_max_len, I also cannot find in repo history. It seems this patch may co-worked with some private version of novaclient previously, but not the public version. In fact current novaclient contains an API "reset_timings" which can be called to purge the timing logs. I want to mark this patch as abandoned, do you have any comments? Regards Liang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181106/69a1fa1f/attachment-0001.html> ------------------------------ Message: 3 Date: Tue, 6 Nov 2018 14:38:25 +0000 From: "Qin, Kailun" <kailun.qin@intel.com> To: "Legacy, Allain" <Allain.Legacy@windriver.com>, "Peters, Matt" <Matt.Peters@windriver.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Analysis of patch 039705e for StarlingX upstreaming Message-ID: <B79033180B571C49888593DE9D1AB78E05967D23@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset="utf-8" Allain, Thanks a lot for the confirmation and clarification. Yes, the host driver is being redesigned. I'll drop the patch accordingly. BR, Kailun From: Legacy, Allain [mailto:Allain.Legacy@windriver.com] Sent: Tuesday, November 6, 2018 8:16 PM To: Qin, Kailun <kailun.qin@intel.com>; Peters, Matt <Matt.Peters@windriver.com>; starlingx-discuss@lists.starlingx.io Subject: RE: [Starlingx-discuss] Analysis of patch 039705e for StarlingX upstreaming I agree. These changes can all be dropped. The keystone config opts change was needed for the host driver to communicate back to our sysinv subsystem, but, as far as I know, that is being redesigned to avoid this requirement. Regards, Allain Allain Legacy, Software Developer, Wind River direct 613.270.2279 fax 613.492.7870 skype allain.legacy 350 Terry Fox Drive, Suite 200, Ottawa, Ontario, K2K 2W5 [WIND]<http://www.windriver.com/> From: Qin, Kailun [mailto:kailun.qin@intel.com] Sent: Tuesday, November 06, 2018 2:10 AM To: Peters, Matt; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] Analysis of patch 039705e for StarlingX upstreaming Hi Matt, We're looking into the patch 039705e for upstreaming, which contains several base changes. 1. For the oslo.db related change, upstream has already dropped this override in neutron-server to make it use default values from oslo.db (see https://review.openstack.org/456419/ for detailed information). 2. For the keystone opts registration, I guess it is used for connecting to external services. From upstream's perspective, this should be maintained along with the specific service to extend rather than make it globally. 3. For the others, I think they're StarlingX specific. Thus, I suggest that we should not upstream these changes. What do you think? Let me know if any question, thanks! BR, Kailun -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181106/3aeefeb9/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.png Type: image/png Size: 1807 bytes Desc: image001.png URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181106/3aeefeb9/attachment.png> ------------------------------ Subject: Digest Footer _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss ------------------------------ End of Starlingx-discuss Digest, Vol 6, Issue 20 ************************************************