Done. Code is merged. Thanks, Bob From: "Liu, ZhipengS" <zhipengs.liu@intel.com> Date: Friday, June 26, 2020 at 7:13 PM To: "'starlingx-discuss@lists.starlingx.io'" <starlingx-discuss@lists.starlingx.io>, "Friesen, Chris" <Chris.Friesen@windriver.com>, Robert Church <Robert.Church@windriver.com> Subject: RE: [Starlingx-discuss] [OpenStack Ussuri Upgrade Task] Call for patch review!! Hi Bob and Chris, Could you help add W+1 for the first patch below, so that we can merge all patches together. https://review.opendev.org/731461 https://review.opendev.org/#/q/topic:for_ussuri+(status:open) Thanks! Zhipeng From: Liu, ZhipengS Sent: 2020年6月26日 8:42 To: 'Scott Little' <scott.little@windriver.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io>; 'Friesen, Chris' <Chris.Friesen@windriver.com>; 'Church, Robert' <Robert.Church@windriver.com> Subject: RE: [Starlingx-discuss] [OpenStack Ussuri Upgrade Task] Call for patch review!! Hi all, Now we have passed cengn build for ussuri! http://mirror.starlingx.cengn.ca/mirror/starlingx/ussuri/centos/monolithic/2... http://mirror.starlingx.cengn.ca/mirror/starlingx/ussuri/centos/monolithic/2... Thanks for the great help from Scott and Chant! Nicolae also reported latest EB passed sanity test this Monday! Thanks! We need core guys to push rest 5 Ussuri patches to be merged now. @'Scott Little'<mailto:scott.little@windriver.com> @Friesen, Chris<mailto:Chris.Friesen@windriver.com>@Church, Robert<mailto:Robert.Church@windriver.com> https://review.opendev.org/731461 https://review.opendev.org/712862 https://review.opendev.org/#/c/712880/ https://review.opendev.org/#/c/719427/ https://review.opendev.org/737456 https://review.opendev.org/#/q/topic:for_ussuri+(status:open) Thanks! Zhipeng From: Liu, ZhipengS Sent: 2020年6月23日 18:56 To: 'Scott Little' <scott.little@windriver.com<mailto:scott.little@windriver.com>>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: RE: [Starlingx-discuss] [OpenStack Ussuri Upgrade Task] Call for patch review!! Hi Scott, I have submitted one patch according to your proposal, please review and add your comment. https://review.opendev.org/#/c/737456/ The patch has been verified by Chant, thanks! You can cherry-pick it and trigger Cengn build again if no problem. Thanks! Zhipeng From: Liu, ZhipengS Sent: 2020年6月23日 7:59 To: 'Scott Little' <scott.little@windriver.com<mailto:scott.little@windriver.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: [Starlingx-discuss] [OpenStack Ussuri Upgrade Task] Call for patch review!! Hi Scott and Frank, So far, we have merged 5 patches. They are for openstack-helm/helm-infra rebasing patch set. So, it should be OK not to revert below 5 patches now. It will not block daily build and sanity test. Upgrade openstack-helm-infra Upgrade openstack-helm Update manifest.yaml file for openstack-helm upgrade. Update download list for openstack-helm upgrade Fix render error in cinder during openstack-helm rebase For rest 4 patches. 3 unmerged patches are for ussuri OpenStack upgrade. 1 unmerged patch for ipv6 fix @Scott Little<mailto:scott.little@windriver.com> For your script change proposal, I will consider it today and add you to review. Thanks! Zhipeng -----Original Message----- From: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>> Sent: 2020年6月23日 2:57 To: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] [OpenStack Ussuri Upgrade Task] Call for patch review!! In short, ussuri should not be merged. Scott On 2020-06-22 1:32 p.m., Scott Little wrote:
The ussuri build only passed because I created customized build
scripts for that feature branch. This was to prove that the python2/3
issues were the only issues with the build. I was in no way
committing to deliver those customizations into the master branch build.
1) We would loose the ability to build on older branches without
significant extra effort.
2) It would be very fragile. It relies on hard code list of packages
that are to be compiled for python3 vs python2. I'm sure that list
will be changing over time.
What I would like to see is build-stx-images.sh modified to look for
and consume a config file that tells it how to partition wheels and
images into two separate builds. Externally, the command remains a
single invocation with no new arguments. The config file could then be
modified to individually shift images from python2 to python3 build
method without having to tinker with cengn build scripts every time
there is a change.
Scott
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io<mailto:Starlingx-discuss@lists.starlingx.io> http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss