I had comments on the following two reviews, one of which has been W+1'd already by Scott: https://review.openstack.org/#/c/605687/ https://review.openstack.org/#/c/605686/ My comments were providing the original author of the patches that were being revised, since a name was being added to a couple of patches where there was none before. I didn't -1 for this, but also didn't +2. -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Thursday, September 27, 2018 5:07 PM To: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] stx.2018.10 code freeze status On 09/27/2018 12:49 PM, Khalil, Ghada wrote:
Updates as of a few minutes ago are inline (prefixed with [[GK]]). Info requested inline from Saul, Abraham.
-----Original Message----- From: Khalil, Ghada [mailto:Ghada.Khalil@windriver.com] Sent: Thursday, September 27, 2018 11:24 AM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] stx.2018.10 code freeze status
Hello all, The starlingx master branch is under a "limited" merge window. This is a reminder to core reviewers NOT to workflow + 1 any commits that don't fall under the following categories:
- CentOS 7.5 patch de-fuzzing: https://review.openstack.org/#/q/topic:patch_fuzz+(status:open+OR+status:mer...) [[GK]] There are 5 commits still not merged. 2 require W+1. Saul, can you please look at those.
I believe we are down to 1 pending due to comments about changes in the body of the patch beyond de-fuzzing, I will let Scott and/or Don comment on that. There are 2 others marked +W pending merge.
- Documentation updates required https://review.openstack.org/#/q/status:open+branch:master+topic:documentati... [[GK]] There are 3 commits still not merged. They just seem to need W+1 to merge. Abraham, are these the only ones left to finish off the doc updates?
I added my +2 where appropriate
Build-Related Bugs - build-srpms-serial is broken: https://bugs.launchpad.net/starlingx/+bug/1790583 Looking for Austin, Erich & Saul to summarize the status. There are two proposed commits: one from Austin & one from Erich. [[GK]] The Launchpad is now marked as Fix Released, so I'll assume this is no longer an issue.
- build-pkgs cannot complete std build: https://bugs.launchpad.net/starlingx/+bug/1791127 Needs re-test after the CentOS 7.5 patch de-fuzzing. Any other updates on this one? [[GK]] The only report I've seen is related to ceph failures from Saul. Any more info? A WR STX build passed this afternoon.
No more information, it built when I ran it a 3rd time, we need to get a better root cause of this as it will be bad user interaction. I am not sure it's a blocker for the branching.
- Corrupt mirror causes missing lshell src rpm: https://bugs.launchpad.net/starlingx/+bug/1793615 This one just got re-opened by Erich. I will let him comment on it further [[GK]] Any updates on this? The thread discussing the replacement of lshell is beyond the scope of the October release.
Correct, lshell stays for 2018.10 Sau!
Is anyone else aware of any other serious issues that should gate the branch creation for the October release?
Regards, Ghada
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss