Hi Matt

  Thanks for your advises and I removed the related checks and warnings. After tests the latest version is totally compatible with old *.ini configure file.

  My patch is https://review.openstack.org/#/c/625018/, any further comments are welcome~

 

Thanks

Ran

 

From: Peters, Matt [mailto:Matt.Peters@windriver.com]
Sent: Thursday, December 13, 2018 12:17 AM
To: An, Ran1 <ran1.an@intel.com>; starlingx-discuss@lists.starlingx.io
Subject: Re: [Starlingx-discuss] removing link capacity configuration during controller config

 

Hello Ran,

We don’t normally maintain special handling for old parameters if they can be safely ignored.   I recommend removing the checks and warnings related to this parameter.

 

Regards, Matt

 

From: "An, Ran1" <ran1.an@intel.com>
Date: Wednesday, December 12, 2018 at 11:07 AM
To: "Peters, Matt" <
Matt.Peters@windriver.com>, "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io>
Subject: RE: [Starlingx-discuss] removing link capacity configuration during controller config

 

Hi Matt

  For considering of compatibility with old *.ini configure files, I kept link speed checks/warnings part in config_validator. It could be removed if nobody need the old format configure file.

 

Hi all

  If anyone need to keep link speed option in *.ini configure file, please let me know.

 

Thanks

Ran 

 

From: Peters, Matt [mailto:Matt.Peters@windriver.com]
Sent: Wednesday, December 12, 2018 8:31 PM
To: An, Ran1 <
ran1.an@intel.com>; starlingx-discuss@lists.starlingx.io
Subject: Re: [Starlingx-discuss] removing link capacity configuration during controller config

 

The link speed checks/warnings should also be removed when the input parameter is removed since it will no longer be provided during config_controller, and therefore not available for validation.

 

Regards, Matt

 

From: "An, Ran1" <ran1.an@intel.com>
Date: Wednesday, December 12, 2018 at 3:57 AM
To: "
starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io>, "Peters, Matt" <Matt.Peters@windriver.com>
Subject: [Starlingx-discuss] removing link capacity configuration during controller config

 

Hi All:

  I am working on bug [1] removing  “link capacity of interface” configuration in config_controller, config_validator and config_gui.

 

Reason:  the link capacity is set to 10G only when doing traffic control[2], it is unnecessary to input ‘link capacity’ during controller configure.

Impact:  1) all ‘link capacity’ related configure input option is removed.

                  2) it is compatibility with old *.ini configure file:

                      when “INTERFACE_LINK_CAPACITY=10000”, it is compatible. 

                      For other values, you will see following errors:   “Invalid link-capacity value for XXX”. Relax.  Just edit “INTERFACE_LINK_CAPACITY” to 10000 and retry “config_controller”.

 

  Feel free to reply if you any idea about this. Any response is welcome.

 

[1] https://bugs.launchpad.net/starlingx/+bug/1805320

[2] https://storyboard.openstack.org/#!/story/2003087

 

Thanks

Ran