Hi folks Thank Bob, Penney and AL review for stx-puppet project. I update comment and welcome more review. https://review.opendev.org/c/starlingx/stx-puppet/+/739363 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, December 7, 2020 2:03 PM To: 'Bailey, Henry Albert (Al)' <Al.Bailey@windriver.com>; 'Bart Wensley' <barton.wensley@windriver.com>; 'Church, Robert' <Robert.Church@windriver.com>; 'Chris Friesen' <chris.friesen@windriver.com>; 'Penney, Don' <Don.Penney@windriver.com>; 'Kung, John' <John.Kung@windriver.com>; 'Waines, Greg' <Greg.Waines@windriver.com> Cc: Sun, Austin <austin.sun@intel.com>; Hu, Yong <yong.hu@intel.com>; Jones, Bruce E <bruce.e.jones@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io> Subject: RE: review patch to enable rook-ceph in stx-puppet project + Greg Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, December 7, 2020 2:00 PM To: Bailey, Henry Albert (Al) <Al.Bailey@windriver.com<mailto:Al.Bailey@windriver.com>>; Bart Wensley <barton.wensley@windriver.com<mailto:barton.wensley@windriver.com>>; Church, Robert <Robert.Church@windriver.com<mailto:Robert.Church@windriver.com>>; Chris Friesen <chris.friesen@windriver.com<mailto:chris.friesen@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Kung, John <John.Kung@windriver.com<mailto:John.Kung@windriver.com>> Cc: Sun, Austin <austin.sun@intel.com<mailto:austin.sun@intel.com>>; Hu, Yong <yong.hu@intel.com<mailto:yong.hu@intel.com>>; Jones, Bruce E <bruce.e.jones@intel.com<mailto:bruce.e.jones@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: review patch to enable rook-ceph in stx-puppet project Hi folks Please review my patch to enable rook-ceph in stx-puppet project. https://review.opendev.org/c/starlingx/stx-puppet/+/739363 BR! Martin, Chen IOTG, Software Engineer 021-61164330