+Al since Tao is OOO. Best Regards Shuicheng From: Lin, Shuicheng Sent: Tuesday, February 19, 2019 9:56 AM To: Liu, Tao (Wind River) <tao.liu@windriver.com<mailto:tao.liu@windriver.com>>; 'eric.macdonald@windriver.com' <eric.macdonald@windriver.com<mailto:eric.macdonald@windriver.com>> Cc: Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>> Subject: Improve FM's Python API return data Hi Tao/Eric, For story 2004859<https://storyboard.openstack.org/#!/story/2004859>, I plan to modify the get_fault api return value as a tuple. (True/False, Alarm) Alarm is valid only when the 1st item is True. Sample code is uploaded for you early review: Stx-fault: https://review.openstack.org/637655 Stx-integ: https://review.openstack.org/637656 Could you help review it and share your thought? If you agree on it, I will implement the code and test it. For test, I will try to kill fmManager/modify its listening port to simulate the failure case. For the api call outside of stx-fault, I may try to call it manually to verify. Please share me if there is better verify method. Thanks. Best Regards Shuicheng