On Wed, Oct 31, 2018 at 5:47 AM Penney, Don <Don.Penney@windriver.com> wrote:
I’m seeing a couple of reviews in stx-integ failing the tox linter job on a bashate error, while most others are successful. Happy in this test: 2018-10-31 03:06:25.270134 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh
But failing in this one: 2018-10-31 08:21:56.690432 | ubuntu-xenial | Running bashate on /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh 2018-10-31 08:21:56.690706 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/stx-integ/base/setup/files/custom.sh:1:1: E004 File did not end with a newline
So I guess we just fix the script and rebase any failing reviews? It seems very odd that bashate would not always be reporting this error. The tox.ini bashate invocation has not changed recently, either.
Yeah, that is odd. Can you send links tot he reviews those came from? I think it would be interesting to see what is different between the job runs, ie cloud provider and such. There _shouldn't_ be anything that matters different... dt -- Dean Troyer dtroyer@gmail.com