[Starlingx-discuss] Launchpad status not updating automatically
Hello all, I noticed that stx launchpads are not getting automatically updated when gerrit reviews merge even when the "Closes-Bug" is used correctly in the code review comment. At this point, I'm not sure if this issue is reported/known to the opendev infrastructure team or not. @Ildiko Vancsa<mailto:ildiko@openstack.org> can you help report this issue or let me know how to do that myself? Until the issue is resolved, please update your LPs manually: put a link to the review and mark the LP as Fix Released when it's merged. Example: https://bugs.launchpad.net/starlingx/+bug/2028302 https://bugs.launchpad.net/starlingx/+bug/2027827 Regards, Ghada
Hi Ghada, Thank you for raising this issue. I just did a quick check. It was reported to the OpenDev community a little while back. The suspected cause for the issue was a check that was matching the Gerrit and Launchpad project names, which for StarlingX don’t always line up. There was a fix merged for this particular issue: https://review.opendev.org/888321 The OpenDev team needs to build and upload a new Gerrit image that contains the fix, and then restart the service. They will look into scheduling that this week. Please see the logs of the related conversation in #opendev on the OFTC IRC network here: https://meetings.opendev.org/irclogs/%23opendev/%23opendev.2023-07-24.log.ht... Best Regards, Ildikó ——— Ildikó Váncsa Director of Community Open Infrastructure Foundation
On Jul 24, 2023, at 09:54, Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
Hello all, I noticed that stx launchpads are not getting automatically updated when gerrit reviews merge even when the “Closes-Bug” is used correctly in the code review comment.
At this point, I’m not sure if this issue is reported/known to the opendev infrastructure team or not.@Ildiko Vancsa can you help report this issue or let me know how to do that myself?
Until the issue is resolved, please update your LPs manually: put a link to the review and mark the LP as Fix Released when it's merged.
Example: https://bugs.launchpad.net/starlingx/+bug/2028302 https://bugs.launchpad.net/starlingx/+bug/2027827
Regards, Ghada
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io
On 2023-07-24 11:27:46 -0700 (-0700), Ildiko Vancsa wrote: [...]
The OpenDev team needs to build and upload a new Gerrit image that contains the fix, and then restart the service. They will look into scheduling that this week. [...]
To be clear, the fixed image is already built and uploaded, it's just that we need to schedule some brief downtime to restart the service on the new image. However, we've also got a pending point release for Gerrit and a fix for how we're persisting Gerrit's commit replication queue, so would ideally work those in before the restart as well to minimize the number of planned outages in the near future. -- Jeremy Stanley
On 2023-07-24 19:20:40 +0000 (+0000), Jeremy Stanley wrote: [...]
we need to schedule some brief downtime to restart the service on the new image. [...]
We restarted Gerrit yesterday for a version upgrade, which also resulted in the fix for the bug updating hook script taking effect. Any changes merged after 2023-07-26 21:05 UTC should close corresponding bugtasks in Launchpad as expected. Changes which merged prior to that, since about 2023-05-12 when the service was originally restarted onto the broken hook script change, may need their bugtasks manually set to fix committed or fix released. -- Jeremy Stanley
Hi Jeremy, I don't think this is working. I have included a couple of examples below, but there are many based on the recent code merges in the StarlingX repo. - https://review.opendev.org/c/starlingx/ansible-playbooks/+/889994 merged Aug 2 - Corresponding LP is not automatically updated: https://bugs.launchpad.net/starlingx/+bug/2028975 - https://review.opendev.org/c/starlingx/config/+/889875 merged Aug 1 - Corresponding LP is not automatically updated: https://bugs.launchpad.net/starlingx/+bug/2028173 Regards, Ghada -----Original Message----- From: Jeremy Stanley <fungi@yuggoth.org> Sent: Thursday, July 27, 2023 7:53 AM To: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Launchpad status not updating automatically CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On 2023-07-24 19:20:40 +0000 (+0000), Jeremy Stanley wrote: [...]
we need to schedule some brief downtime to restart the service on the new image. [...]
We restarted Gerrit yesterday for a version upgrade, which also resulted in the fix for the bug updating hook script taking effect. Any changes merged after 2023-07-26 21:05 UTC should close corresponding bugtasks in Launchpad as expected. Changes which merged prior to that, since about 2023-05-12 when the service was originally restarted onto the broken hook script change, may need their bugtasks manually set to fix committed or fix released. -- Jeremy Stanley
On 2023-08-03 03:00:18 +0000 (+0000), Khalil, Ghada wrote:
I don't think this is working. I have included a couple of examples below, but there are many based on the recent code merges in the StarlingX repo. [...]
Thanks for the heads up! I instrumented some additional debug logging in the hook scripts responsible for Gerrit-to-Launchpad integration and discovered that, in addition to the earlier issue, we also were apparently broken by an incident[*] with the Launchpad API dating back to June 23. After performing[**] the cache cleanup they recommended, I'm no longer seeing tracebacks from the scripts, so expect they should finally be working as of a few minutes ago. Please double-check any changes you merge in the near future, just to be extra sure. [*] https://ubuntu.social/@launchpadstatus/110594525393361192 [**] https://fosstodon.org/@opendevinfra/110826029948394419 -- Jeremy Stanley
I think there is still an issue The merger of https://review.opendev.org/c/starlingx/tools/+/890427 failed to update https://bugs.launchpad.net/starlingx/+bug/2029499 Scott On 2023-08-03 10:06, Jeremy Stanley wrote:
CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.
On 2023-08-03 03:00:18 +0000 (+0000), Khalil, Ghada wrote:
I don't think this is working. I have included a couple of examples below, but there are many based on the recent code merges in the StarlingX repo. [...]
Thanks for the heads up! I instrumented some additional debug logging in the hook scripts responsible for Gerrit-to-Launchpad integration and discovered that, in addition to the earlier issue, we also were apparently broken by an incident[*] with the Launchpad API dating back to June 23. After performing[**] the cache cleanup they recommended, I'm no longer seeing tracebacks from the scripts, so expect they should finally be working as of a few minutes ago. Please double-check any changes you merge in the near future, just to be extra sure.
[*] https://ubuntu.social/@launchpadstatus/110594525393361192 [**] https://fosstodon.org/@opendevinfra/110826029948394419 -- Jeremy Stanley
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io
I think there is still an issue The merger of https://review.opendev.org/c/starlingx/tools/+/890427 failed to update https://bugs.launchpad.net/starlingx/+bug/2029499 Scott On 2023-08-03 10:06, Jeremy Stanley wrote:
CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.
On 2023-08-03 03:00:18 +0000 (+0000), Khalil, Ghada wrote:
I don't think this is working. I have included a couple of examples below, but there are many based on the recent code merges in the StarlingX repo. [...]
Thanks for the heads up! I instrumented some additional debug logging in the hook scripts responsible for Gerrit-to-Launchpad integration and discovered that, in addition to the earlier issue, we also were apparently broken by an incident[*] with the Launchpad API dating back to June 23. After performing[**] the cache cleanup they recommended, I'm no longer seeing tracebacks from the scripts, so expect they should finally be working as of a few minutes ago. Please double-check any changes you merge in the near future, just to be extra sure.
[*] https://ubuntu.social/@launchpadstatus/110594525393361192 [**] https://fosstodon.org/@opendevinfra/110826029948394419 -- Jeremy Stanley
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io
I think there is still an issue The merger of https://review.opendev.org/c/starlingx/tools/+/890427 failed to update https://bugs.launchpad.net/starlingx/+bug/2029499 Scott On 2023-08-03 10:06, Jeremy Stanley wrote:
CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe.
On 2023-08-03 03:00:18 +0000 (+0000), Khalil, Ghada wrote:
I don't think this is working. I have included a couple of examples below, but there are many based on the recent code merges in the StarlingX repo. [...]
Thanks for the heads up! I instrumented some additional debug logging in the hook scripts responsible for Gerrit-to-Launchpad integration and discovered that, in addition to the earlier issue, we also were apparently broken by an incident[*] with the Launchpad API dating back to June 23. After performing[**] the cache cleanup they recommended, I'm no longer seeing tracebacks from the scripts, so expect they should finally be working as of a few minutes ago. Please double-check any changes you merge in the near future, just to be extra sure.
[*] https://ubuntu.social/@launchpadstatus/110594525393361192 [**] https://fosstodon.org/@opendevinfra/110826029948394419 -- Jeremy Stanley
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io
On 2023-08-03 14:14:41 -0400 (-0400), Scott.Little wrote:
I think there is still an issue
The merger of https://review.opendev.org/c/starlingx/tools/+/890427
failed to update https://bugs.launchpad.net/starlingx/+bug/2029499 [...]
It looks like the hook scripts are once again commenting on the indicated bug report when the change is proposed or merged. It doesn't appear to have updated the bugtask's status from new to in-progress or fix-released, but I see other bugs[*] where it did successfully change a bugtask status. Looking at the examples and the source code[**] for the script, I think what you're going to find is that if the branch name for the change doesn't contain a "/" then the hook assumes the default project bugtask is what should have its status updated. If it finds a "/" in the branch name then it looks for a specific bugtask for a series ending in a substring that matches whatever comes after that. So in the case of change 890427 for the r/stx.7.0 branch of the starlingx/tools project it's going to check the linked bug 2029499 to see if it has a bugtask for a series whose name ends in "stx.7.0" and then update its status to in-progress or fix-released as appropriate. If 890427 had been for the "master" branch of starlingx/tools, then I think it would have adjusted the status of the default bugtask on 2029499. If we need to carve out some exceptions or additional per-project configurable behaviors (within reason), I'm sure it can be accommodated, just let me know. [*] https://bugs.launchpad.net/starlingx/+bug/2029425 [**] https://opendev.org/opendev/jeepyb/src/commit/8fd3fda/jeepyb/cmd/update_bug.... -- Jeremy Stanley
participants (5)
-
Ildiko Vancsa
-
Jeremy Stanley
-
Khalil, Ghada
-
Scott Little
-
Scott.Little