[Starlingx-discuss] Questions about patch ab1baac upstreaming
Matt, I am looking at patch#ab1baac (US106501: Change to Titanium's handling Neutron Extensions) which targets to remove wrs-fields from the response to non-wrs client (e.g. no 'wrs-header' in the client request), suppose this is STX special feature and not need for upstream, could you please help to confirm? Thanks much! Best Regards, Le, Huifeng
Hello Huifeng, You are correct. This commit should not be upstreamed since the underlying features are being upstreamed, refactored or abandoned. Regards, Matt From: "Le, Huifeng" <huifeng.le@intel.com> Date: Tuesday, November 20, 2018 at 3:54 AM To: "Peters, Matt" <Matt.Peters@windriver.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: Questions about patch ab1baac upstreaming Matt, I am looking at patch#ab1baac (US106501: Change to Titanium’s handling Neutron Extensions) which targets to remove wrs-fields from the response to non-wrs client (e.g. no ‘wrs-header’ in the client request), suppose this is STX special feature and not need for upstream, could you please help to confirm? Thanks much! Best Regards, Le, Huifeng
Cool. One more resolved. There has been some confusion on what happens next once we get to this state. Do we: 1) Mark this patch as abandoned in the spreadsheet and wait to remove it until we rebase? 2) Mark the patch as abandoned and remove it from the code base? 3) Mark the patch as deleted and remove it from the code base now? 4) Something else? brucej From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Tuesday, November 20, 2018 9:42 AM To: Le, Huifeng <huifeng.le@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Questions about patch ab1baac upstreaming Hello Huifeng, You are correct. This commit should not be upstreamed since the underlying features are being upstreamed, refactored or abandoned. Regards, Matt From: "Le, Huifeng" <huifeng.le@intel.com<mailto:huifeng.le@intel.com>> Date: Tuesday, November 20, 2018 at 3:54 AM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Questions about patch ab1baac upstreaming Matt, I am looking at patch#ab1baac (US106501: Change to Titanium’s handling Neutron Extensions) which targets to remove wrs-fields from the response to non-wrs client (e.g. no ‘wrs-header’ in the client request), suppose this is STX special feature and not need for upstream, could you please help to confirm? Thanks much! Best Regards, Le, Huifeng
Hi Bruce, This particular one is tricky since it covers several other underlying patches/features. I would say that it falls within the category of #1. We need the other work to complete so this would need to be held until the underlying patches are either upstreamed or refactored. Regards, Matt From: "Jones, Bruce E" <bruce.e.jones@intel.com> Date: Tuesday, November 20, 2018 at 12:50 PM To: "Peters, Matt" <Matt.Peters@windriver.com>, "Le, Huifeng" <huifeng.le@intel.com>, "Chilcote Bacco, Derek A" <derek.a.chilcote.bacco@intel.com> Cc: "starlingx-discuss@lists.starlingx.io" <starlingx-discuss@lists.starlingx.io> Subject: RE: Questions about patch ab1baac upstreaming Cool. One more resolved. There has been some confusion on what happens next once we get to this state. Do we: 1. Mark this patch as abandoned in the spreadsheet and wait to remove it until we rebase? 2. Mark the patch as abandoned and remove it from the code base? 3. Mark the patch as deleted and remove it from the code base now? 4. Something else? brucej From: Peters, Matt [mailto:Matt.Peters@windriver.com] Sent: Tuesday, November 20, 2018 9:42 AM To: Le, Huifeng <huifeng.le@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] Questions about patch ab1baac upstreaming Hello Huifeng, You are correct. This commit should not be upstreamed since the underlying features are being upstreamed, refactored or abandoned. Regards, Matt From: "Le, Huifeng" <huifeng.le@intel.com<mailto:huifeng.le@intel.com>> Date: Tuesday, November 20, 2018 at 3:54 AM To: "Peters, Matt" <Matt.Peters@windriver.com<mailto:Matt.Peters@windriver.com>> Cc: "starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>" <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Questions about patch ab1baac upstreaming Matt, I am looking at patch#ab1baac (US106501: Change to Titanium’s handling Neutron Extensions) which targets to remove wrs-fields from the response to non-wrs client (e.g. no ‘wrs-header’ in the client request), suppose this is STX special feature and not need for upstream, could you please help to confirm? Thanks much! Best Regards, Le, Huifeng
participants (3)
-
Jones, Bruce E
-
Le, Huifeng
-
Peters, Matt