Hi all, To workaround the patch list management, I forked the working project to my private account in github. And we will work on it verify the patch, then submit code review in gerrit. So branch should be not needed now. Best Regards Shuicheng From: Xie, Cindy [mailto:cindy.xie@intel.com] Sent: Tuesday, August 14, 2018 2:46 PM To: Xie, Cindy <cindy.xie@intel.com>; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5 Dean, What is your recommendation for creating a feature branch for CentOS 7.5 upgrade? Right now, as the work is going to have many patches generated, and they have dependencies, it'd difficult to maintain each patches in the mainline with multiple engineers working on the same mainline without actually merge them. Please advise if you can create the feature branch or you can grant Shuicheng to create it? Then the code review can happen in feature branch and we will generate a build from feature branch for Ada for validation. The merge back to mainline can be done after all sRPM update and test passed with accelerated CR+2 path. Thanks. - cindy From: Xie, Cindy [mailto:cindy.xie@intel.com] Sent: Tuesday, August 14, 2018 1:13 PM To: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5 All, Shuicheng has one story with many tasks open for SRPM (and its dependent RPM) upgrade to CentOS 7.5: https://storyboard.openstack.org/#!/story/2003389 Please provide your code review feedback actively (CR+1, CR+2). However, please hold to have W+1 at this moment. We will do a test build when all 47 sRPM upgrade has been done and mirror upgrade to 7.5 done. @Ada, please can you kindly support the validation for the build when we are ready? Thanks. - cindy

On rare occasions it can produce an issue.  Would likely requires a case where our patches modify a -devel rpm in a way that changes how other packages compile. While I'd prefer to see the competing binary rpms removed sooner rather than later, I can settle on a follow up story. Scott On 18-08-14 07:38 AM, Lin, Shuicheng wrote:

Hi Scott,

I created below story to track the rpm compete you mentioned in comments. I prefer to do it after CentOS7.5 upgrade, since it is a minor refine, not an issue fix.

Is my understand correct?

https://storyboard.openstack.org/#!/story/2003435 <https://storyboard.openstack.org/#%21/story/2003435>

On 08/14/2018 04:38 AM, Lin, Shuicheng wrote:

Hi Scott,

I created below story to track the rpm compete you mentioned in comments. I prefer to do it after CentOS7.5 upgrade, since it is a minor refine, not an issue fix.

Is my understand correct?

https://storyboard.openstack.org/#!/story/2003435

Hi Saul,

For the configuration related patch move out of src rpm, I also prefer to do it after the upgrade.

That's fine, it can wait for the upgrade patch set to be validated and merged.

You mentioned it for package pam and openldap. I could follow up them after you share your thought later.

There are many packages that have configuration changes., I just happened on pam and openldap. We need to do the analysis and then understand what's the best approach to providing the modified config outside of the primary packages. Sau!

Best Regards

Shuicheng

*From:* Xie, Cindy [mailto:cindy.xie@intel.com] *Sent:* Tuesday, August 14, 2018 1:13 PM *To:* starlingx-discuss@lists.starlingx.io *Subject:* [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5

All,

Shuicheng has one story with many tasks open for SRPM (and its dependent RPM) upgrade to CentOS 7.5: https://storyboard.openstack.org/#!/story/2003389

Please provide your code review feedback actively (CR+1, CR+2). However, please hold to have W+1 at this moment. We will do a test build when all 47 sRPM upgrade has been done and mirror upgrade to 7.5 done.

@Ada, please can you kindly support the validation for the build when we are ready?

Thanks. - cindy

_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss

Shuicheng who submitted most of the patches in mainline is now on vacation till next week. So please bear those for a while before he came back. Thx. - cindy -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Thursday, August 23, 2018 8:59 AM To: starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5 On 08/22/2018 05:41 PM, Xie, Cindy wrote:

All,

As we moved all CentOS7.5 patches from mainline to feature branch: f/centos75, please do the review in feature branch for the new coming patches:

https://review.openstack.org/#/q/status:open+project:openstack/stx-int eg+branch:f/centos75

https://review.openstack.org/#/q/status:open+project:openstack/stx-too ls+branch:f/centos75

https://review.openstack.org/#/q/status:open+project:openstack/stx-ups tream+branch:f/centos75

for those already have CR+2, appreciate that Cores can provide W+1 so that they can be merged into feature branch.

I have been working my way through that list. I just +W most of them. Please have your team mark the ones for Master as abandoned at this point also. Sau!

Thx. - cindy

*From:* Xie, Cindy [mailto:cindy.xie@intel.com] *Sent:* Tuesday, August 14, 2018 1:13 PM *To:* starlingx-discuss@lists.starlingx.io *Subject:* [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5

All,

Shuicheng has one story with many tasks open for SRPM (and its dependent RPM) upgrade to CentOS 7.5: https://storyboard.openstack.org/#!/story/2003389

Please provide your code review feedback actively (CR+1, CR+2). However, please hold to have W+1 at this moment. We will do a test build when all 47 sRPM upgrade has been done and mirror upgrade to 7.5 done.

@Ada, please can you kindly support the validation for the build when we are ready?

Thanks. - cindy

_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss

_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss

Thanks - it works! - cindy -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Thursday, August 23, 2018 12:34 PM To: Xie, Cindy <cindy.xie@intel.com> Cc: Saul Wold <sgw@linux.intel.com>; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] patches for SRPM upgrade to CentOS 7.5 On Wed, Aug 22, 2018 at 9:29 PM, Xie, Cindy <cindy.xie@intel.com> wrote:

Shuicheng who submitted most of the patches in mainline is now on vacation till next week. So please bear those for a while before he came back.

Any core reviewer can abandon reviews in addition to the owner, I went through and got the ones where the f/centos75 version has merged. dt -- Dean Troyer dtroyer@gmail.com