[Starlingx-discuss] [build] Pending Gerrit PR that need review from Cores
Folks, There are some pending reviews in many of the repos that reviewed and possibly merged before the code freeze tomorrow. Can you all please take a few minutes to review the incoming reviews, we all probably have different views and dashboards, so I am not sure what the best dashboard URL would be. I guess folks should start with: https://review.openstack.org/#/dashboard/self Dean provided me with this more complex search: https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fstx-clients+OR+project%3Aopenstack%2Fstx-config+OR+project%3Aopenstack%2Fstx-fault+OR+project%3Aopenstack%2Fstx-gplv2+OR+project%3Aopenstack%2Fstx-gplv3+OR+project%3Aopenstack%2Fstx-gui+OR+project%3Aopenstack%2Fstx-ha+OR+project%3Aopenstack%2Fstx-integ+OR+project%3Aopenstack%2Fstx-manifest+OR+project%3Aopenstack%2Fstx-metal+OR+project%3Aopenstack%2Fstx-nfv+OR+project%3Aopenstack%2Fstx-root+OR+project%3Aopenstack%2Fstx-tis-repo+OR+project%3Aopenstack%2Fstx-tools+OR+project%3Aopenstack%2Fstx-update+OR+project%3Aopenstack%2Fstx-upstream+OR+project%3Aopenstack%2Fstx-utils%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Czuul+NOT+reviewedby%3Aself&title=StarlingX+Review+Inbox&Needs+final+%2B2=label%3ACode-Review%3E%3D2+limit%3A50+NOT+label%3ACode-Review%3C%3D-1%2Cself&Passed+Zuul%2C+No+Negative+Feedback+%28Small+Fixes%29=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3C%3D10&Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3E10&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A5d&You+are+a+reviewer%2C+but+haven't+voted+in+the+current+revision=NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself+reviewer%3Aself&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+is%3Areviewed+age%3A2d Thanks Sau!
The big query below now has a link on the Wiki - it's in the Code section called "StarlingX Gerrit Review Dashboard by Status". There are a lot of pending reviews. It's a day before our code freeze. If any of that code needs to hit the release, it needs to be reviewed and approved asap. brucej -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Tuesday, September 25, 2018 11:41 AM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] [build] Pending Gerrit PR that need review from Cores Folks, There are some pending reviews in many of the repos that reviewed and possibly merged before the code freeze tomorrow. Can you all please take a few minutes to review the incoming reviews, we all probably have different views and dashboards, so I am not sure what the best dashboard URL would be. I guess folks should start with: https://review.openstack.org/#/dashboard/self Dean provided me with this more complex search: https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fstx-clients+OR+project%3Aopenstack%2Fstx-config+OR+project%3Aopenstack%2Fstx-fault+OR+project%3Aopenstack%2Fstx-gplv2+OR+project%3Aopenstack%2Fstx-gplv3+OR+project%3Aopenstack%2Fstx-gui+OR+project%3Aopenstack%2Fstx-ha+OR+project%3Aopenstack%2Fstx-integ+OR+project%3Aopenstack%2Fstx-manifest+OR+project%3Aopenstack%2Fstx-metal+OR+project%3Aopenstack%2Fstx-nfv+OR+project%3Aopenstack%2Fstx-root+OR+project%3Aopenstack%2Fstx-tis-repo+OR+project%3Aopenstack%2Fstx-tools+OR+project%3Aopenstack%2Fstx-update+OR+project%3Aopenstack%2Fstx-upstream+OR+project%3Aopenstack%2Fstx-utils%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Czuul+NOT+reviewedby%3Aself&title=StarlingX+Review+Inbox&Needs+final+%2B2=label%3ACode-Review%3E%3D2+limit%3A50+NOT+label%3ACode-Review%3C%3D-1%2Cself&Passed+Zuul%2C+No+Negative+Feedback+%28Small+Fixes%29=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3C%3D10&Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3E10&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A5d&You+are+a+reviewer%2C+but+haven't+voted+in+the+current+revision=NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself+reviewer%3Aself&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+is%3Areviewed+age%3A2d Thanks Sau! _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Just to clarify, not all these reviews are required for the code freeze. Items required for the code freeze will have a story or bug with the "stx.2018.10" tag. -----Original Message----- From: Jones, Bruce E [mailto:bruce.e.jones@intel.com] Sent: Tuesday, September 25, 2018 3:25 PM To: Saul Wold; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] [build] Pending Gerrit PR that need review from Cores The big query below now has a link on the Wiki - it's in the Code section called "StarlingX Gerrit Review Dashboard by Status". There are a lot of pending reviews. It's a day before our code freeze. If any of that code needs to hit the release, it needs to be reviewed and approved asap. brucej -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Tuesday, September 25, 2018 11:41 AM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] [build] Pending Gerrit PR that need review from Cores Folks, There are some pending reviews in many of the repos that reviewed and possibly merged before the code freeze tomorrow. Can you all please take a few minutes to review the incoming reviews, we all probably have different views and dashboards, so I am not sure what the best dashboard URL would be. I guess folks should start with: https://review.openstack.org/#/dashboard/self Dean provided me with this more complex search: https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Fstx-clients+OR+project%3Aopenstack%2Fstx-config+OR+project%3Aopenstack%2Fstx-fault+OR+project%3Aopenstack%2Fstx-gplv2+OR+project%3Aopenstack%2Fstx-gplv3+OR+project%3Aopenstack%2Fstx-gui+OR+project%3Aopenstack%2Fstx-ha+OR+project%3Aopenstack%2Fstx-integ+OR+project%3Aopenstack%2Fstx-manifest+OR+project%3Aopenstack%2Fstx-metal+OR+project%3Aopenstack%2Fstx-nfv+OR+project%3Aopenstack%2Fstx-root+OR+project%3Aopenstack%2Fstx-tis-repo+OR+project%3Aopenstack%2Fstx-tools+OR+project%3Aopenstack%2Fstx-update+OR+project%3Aopenstack%2Fstx-upstream+OR+project%3Aopenstack%2Fstx-utils%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Czuul+NOT+reviewedby%3Aself&title=StarlingX+Review+Inbox&Needs+final+%2B2=label%3ACode-Review%3E%3D2+limit%3A50+NOT+label%3ACode-Review%3C%3D-1%2Cself&Passed+Zuul%2C+No+Negative+Feedback+%28Small+Fixes%29=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3C%3D10&Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1%2Cstarlingx-core+delta%3A%3E10&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A5d&You+are+a+reviewer%2C+but+haven't+voted+in+the+current+revision=NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself+reviewer%3Aself&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+is%3Areviewed+age%3A2d Thanks Sau! _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
On Tue, Sep 25, 2018 at 2:30 PM, Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
Just to clarify, not all these reviews are required for the code freeze. Items required for the code freeze will have a story or bug with the "stx.2018.10" tag.
One way to track these directly in Gerrit would be to set the review topic to that tag, then you can just query the tag to see the status... Also, don't forget that CI is still running with a deep backlog and at least 4 hours waiting to get test nodes in the check queue is still common; the gate queue has priority so isn't so bad. dt -- Dean Troyer dtroyer@gmail.com
participants (4)
-
Dean Troyer
-
Jones, Bruce E
-
Khalil, Ghada
-
Saul Wold