[Starlingx-discuss] code review workflow
HI all, I have a bunch of reviews pending today. If you happened to review my changes, could you please do NOT +1 Workflow? I would like to run a script later after all reviews are approved to apply workflow in sequence to avoid conflicts and mismatch among multiple repos. Thanks, Jack
Excerpts from 's message of 2018-06-29 14:11:29 +0000:
HI all, I have a bunch of reviews pending today. If you happened to review my changes, could you please do NOT +1 Workflow? I would like to run a script later after all reviews are approved to apply workflow in sequence to avoid conflicts and mismatch among multiple repos. Thanks, Jack
If you include a "Depends-On" link in your commit messages, Zuul will tie the commits together in a way that forces them to land in order, even across repositories. See https://docs.openstack.org/infra/manual/developers.html#cross-repository-dep... for more details. Doug
On Fri, Jun 29, 2018 at 11:57 AM, Doug Hellmann <doug@doughellmann.com> wrote:
If you include a "Depends-On" link in your commit messages, Zuul will tie the commits together in a way that forces them to land in order, even across repositories. See https://docs.openstack.org/infra/manual/developers.html#cross-repository-dep... for more details.
I didn't initially put these repos into the same gate queue, so that's work across repos once https://review.openstack.org/578532 merges... dt -- Dean Troyer dtroyer@gmail.com
Excerpts from Dean Troyer's message of 2018-06-29 12:08:49 -0500:
On Fri, Jun 29, 2018 at 11:57 AM, Doug Hellmann <doug@doughellmann.com> wrote:
If you include a "Depends-On" link in your commit messages, Zuul will tie the commits together in a way that forces them to land in order, even across repositories. See https://docs.openstack.org/infra/manual/developers.html#cross-repository-dep... for more details.
I didn't initially put these repos into the same gate queue, so that's work across repos once https://review.openstack.org/578532 merges...
dt
OK, I thought depends-on worked even if things weren't in the same queue (at least in terms of not being able to merge a commit until its dependencies had merged). Doug
participants (3)
-
Dean Troyer
-
Ding, Jack
-
Doug Hellmann