[Starlingx-discuss] [stx-nova] Stein branch rebase
I have done a preliminary rebase of the stx-nova Stein branch into stx/stein.2 [0]. It is passing unit and functional tests but since some changes were required from the current upstream reviews it really needs to be checked out further. * I started with upstream stable/stein acd2daa9 (current as of yesterday noon-ish) * Artom rebased the upstream NUMA patches in master so I pulled the current patchset of those * There is a missing import in 635229 that is causing the test failures, I inserted the commit adding that inline in the PR * There were conflicts in 634605 and 634606 due to ongoing development in master since stable/stein was branched. I made the obvious corrections, there may be more required that someone who is not familiar with this code (me) would likely miss. The final pep, unit and functional jobs are running under https://review.opendev.org/#/c/656065/8 and I expect them to pass. I do believe this requires the extraced placement to be merged so we may not be able to test it in StarlingX until that is complete. I am hoping this can be tested with just replacing the Nova docker image but I do not have the time to run through that. dt [0] PR: https://github.com/starlingx-staging/stx-nova/pull/25 -- Dean Troyer dtroyer@gmail.com
FYI. The external placement service code merged earlier today: https://review.opendev.org/#/c/662614/ https://review.opendev.org/#/c/662371/ Cheers, Ghada -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Wednesday, June 19, 2019 6:53 PM To: starlingx Subject: [Starlingx-discuss] [stx-nova] Stein branch rebase I have done a preliminary rebase of the stx-nova Stein branch into stx/stein.2 [0]. It is passing unit and functional tests but since some changes were required from the current upstream reviews it really needs to be checked out further. * I started with upstream stable/stein acd2daa9 (current as of yesterday noon-ish) * Artom rebased the upstream NUMA patches in master so I pulled the current patchset of those * There is a missing import in 635229 that is causing the test failures, I inserted the commit adding that inline in the PR * There were conflicts in 634605 and 634606 due to ongoing development in master since stable/stein was branched. I made the obvious corrections, there may be more required that someone who is not familiar with this code (me) would likely miss. The final pep, unit and functional jobs are running under https://review.opendev.org/#/c/656065/8 and I expect them to pass. I do believe this requires the extraced placement to be merged so we may not be able to test it in StarlingX until that is complete. I am hoping this can be tested with just replacing the Nova docker image but I do not have the time to run through that. dt [0] PR: https://github.com/starlingx-staging/stx-nova/pull/25 -- Dean Troyer dtroyer@gmail.com _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
On Wed, Jun 19, 2019 at 6:26 PM Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
FYI. The external placement service code merged earlier today: https://review.opendev.org/#/c/662614/ https://review.opendev.org/#/c/662371/
And to close the loop, the Github PR is merged, stx-nova branch stx/stein.2 is now ready to be pulled for further testing. dt -- Dean Troyer dtroyer@gmail.com
Thanks for the update Dean. We'll need our nova docker image to be rebuilt to pick up this branch. The docker images are built weekly on Monday nights. Don can you update the appropriate file to point to this new branch? Frank -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Thursday, June 27, 2019 1:32 PM To: starlingx <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] [stx-nova] Stein branch rebase On Wed, Jun 19, 2019 at 6:26 PM Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
FYI. The external placement service code merged earlier today: https://review.opendev.org/#/c/662614/ https://review.opendev.org/#/c/662371/
And to close the loop, the Github PR is merged, stx-nova branch stx/stein.2 is now ready to be pulled for further testing. dt -- Dean Troyer dtroyer@gmail.com _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Hi Frank, This update should be done by whoever is responsible for the change. It requires updating the image directives file to reference the new branch as the PROJECT_REF value: https://opendev.org/starlingx/upstream/src/branch/master/openstack/python-no... Instructions on building images can be found here: https://wiki.openstack.org/wiki/StarlingX/Containers/BuildingImages#Image_Bu... If I wanted to test the build of this updated directives file, I can use the latest CENGN-built base and wheels, and run: BUILD_STREAM=stable BRANCH=master CENTOS_BASE=starlingx/stx-centos:${BRANCH}-${BUILD_STREAM}-latest WHEELS=http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/latest_docker_image_build/outputs/wheels//stx-centos-${BUILD_STREAM}-wheels.tar time $MY_REPO/build-tools/build-docker-images/build-stx-images.sh \ --stream ${BUILD_STREAM} \ --base ${CENTOS_BASE} \ --wheels ${WHEELS} \ --only stx-nova Cheers, Don. -----Original Message----- From: Miller, Frank [mailto:Frank.Miller@windriver.com] Sent: Thursday, June 27, 2019 2:30 PM To: Dean Troyer; starlingx Subject: Re: [Starlingx-discuss] [stx-nova] Stein branch rebase Thanks for the update Dean. We'll need our nova docker image to be rebuilt to pick up this branch. The docker images are built weekly on Monday nights. Don can you update the appropriate file to point to this new branch? Frank -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Thursday, June 27, 2019 1:32 PM To: starlingx <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] [stx-nova] Stein branch rebase On Wed, Jun 19, 2019 at 6:26 PM Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
FYI. The external placement service code merged earlier today: https://review.opendev.org/#/c/662614/ https://review.opendev.org/#/c/662371/
And to close the loop, the Github PR is merged, stx-nova branch stx/stein.2 is now ready to be pulled for further testing. dt -- Dean Troyer dtroyer@gmail.com _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
Thanks Don. I'll bring this up next week at the weekly distro-openstack call and we'll decide who makes this final change. Frank -----Original Message----- From: Penney, Don Sent: Thursday, June 27, 2019 4:32 PM To: Miller, Frank <Frank.Miller@windriver.com>; Dean Troyer <dtroyer@gmail.com>; starlingx <starlingx-discuss@lists.starlingx.io> Subject: RE: [Starlingx-discuss] [stx-nova] Stein branch rebase Hi Frank, This update should be done by whoever is responsible for the change. It requires updating the image directives file to reference the new branch as the PROJECT_REF value: https://opendev.org/starlingx/upstream/src/branch/master/openstack/python-no... Instructions on building images can be found here: https://wiki.openstack.org/wiki/StarlingX/Containers/BuildingImages#Image_Bu... If I wanted to test the build of this updated directives file, I can use the latest CENGN-built base and wheels, and run: BUILD_STREAM=stable BRANCH=master CENTOS_BASE=starlingx/stx-centos:${BRANCH}-${BUILD_STREAM}-latest WHEELS=http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/latest_docker_image_build/outputs/wheels//stx-centos-${BUILD_STREAM}-wheels.tar time $MY_REPO/build-tools/build-docker-images/build-stx-images.sh \ --stream ${BUILD_STREAM} \ --base ${CENTOS_BASE} \ --wheels ${WHEELS} \ --only stx-nova Cheers, Don. -----Original Message----- From: Miller, Frank [mailto:Frank.Miller@windriver.com] Sent: Thursday, June 27, 2019 2:30 PM To: Dean Troyer; starlingx Subject: Re: [Starlingx-discuss] [stx-nova] Stein branch rebase Thanks for the update Dean. We'll need our nova docker image to be rebuilt to pick up this branch. The docker images are built weekly on Monday nights. Don can you update the appropriate file to point to this new branch? Frank -----Original Message----- From: Dean Troyer [mailto:dtroyer@gmail.com] Sent: Thursday, June 27, 2019 1:32 PM To: starlingx <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] [stx-nova] Stein branch rebase On Wed, Jun 19, 2019 at 6:26 PM Khalil, Ghada <Ghada.Khalil@windriver.com> wrote:
FYI. The external placement service code merged earlier today: https://review.opendev.org/#/c/662614/ https://review.opendev.org/#/c/662371/
And to close the loop, the Github PR is merged, stx-nova branch stx/stein.2 is now ready to be pulled for further testing. dt -- Dean Troyer dtroyer@gmail.com _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
participants (4)
-
Dean Troyer
-
Khalil, Ghada
-
Miller, Frank
-
Penney, Don