[Starlingx-discuss] Fault Containerization: Enable FM panels in Openstack Dashboard
Hello Tyler & Don, We have started looking into the remaining work in Fault Containerization and looked into the earlier abandoned patch implementation (https://review.opendev.org/#/c/661423/). As we have joined the team newly, we would like to understand GUI and Horizon implementation and next steps to move forward regarding this pending activity. We had a initial discussion regarding this with Saul and Austin and based on their inputs, we would like to have a discussion. Please let me know if you need any clarification. Thanks & regards, Ambarish/Sanjay
Hi Ambarish & Sanjay There were two approaches that were being looked at. The first was to use the same GUI plugin for both the platform horizon and containerized horizon, but only copy over the horizon 'enabled' files corresponding to the panels that we want to enable (fault panels in the containerized case). This is the approach that was tried but it ended up not working and required lots of hacks during the docker image build step, such as modifying the code, which we really want to avoid. The reasons it wasn't working weren't really clear to me, I didn't spend time debugging etc. Attached is some background on what was being discussed then. The decision was made to instead split our plugin into two, one for the platform panels, and one for just the fault panels. This will involve creating a new package next to starlingx-dashboard (in the same repo though) that has a similar structure but only has the relevant fault components. Including: Api/fm.py Api/rest/fm.py Dashboards/admin/active_alarms/ Static/dashboard/fault_management/ Enabled/ -> need the fm related enabled files in here, along with the banner view header section definition (see ADD_HEADER_SECTIONS). These files will get copied over in the docker image build step. The only other instruction in this step should be the csrftoken customization command from the attached email, which I think unfortunately is required. As for the settings for the containerized horizon, they are stored in the openstack helm application manifest here: openstack-armada-app/stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml My understanding is fault management will remain in the platform as well. A distributed cloud deployment will also have to be tested, as the dc_admin dashboard also queries fm. There's decent documentation on the plugin structure upstream: https://docs.openstack.org/horizon/latest/contributor/tutorials/plugin.html Let me know if you need more details Tyler From: Das, Ambarish [mailto:ambarish.das@intel.com] Sent: Wednesday, May 13, 2020 2:22 AM To: Penney, Don <Don.Penney@windriver.com>; Smith, Tyler <tyler.smith@windriver.com> Cc: Wold, Saul <saul.wold@intel.com>; Jones, Bruce E <bruce.e.jones@intel.com>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com>; starlingx-discuss@lists.starlingx.io; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com>; Sun, Austin <austin.sun@intel.com> Subject: Fault Containerization: Enable FM panels in Openstack Dashboard Hello Tyler & Don, We have started looking into the remaining work in Fault Containerization and looked into the earlier abandoned patch implementation (https://review.opendev.org/#/c/661423/). As we have joined the team newly, we would like to understand GUI and Horizon implementation and next steps to move forward regarding this pending activity. We had a initial discussion regarding this with Saul and Austin and based on their inputs, we would like to have a discussion. Please let me know if you need any clarification. Thanks & regards, Ambarish/Sanjay
Hi Tyler, Thanks for explaining the details and we have few queries inline Thanks & regards, Ambarish/Sanjay From: Smith, Tyler <tyler.smith@windriver.com> Sent: Friday, May 15, 2020 1:35 AM To: Das, Ambarish <ambarish.das@intel.com>; Penney, Don <Don.Penney@windriver.com>; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com> Cc: Wold, Saul <saul.wold@intel.com>; Jones, Bruce E <bruce.e.jones@intel.com>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com>; starlingx-discuss@lists.starlingx.io; Sun, Austin <austin.sun@intel.com>; Eslimi, Dariush <Dariush.Eslimi@windriver.com> Subject: RE: Fault Containerization: Enable FM panels in Openstack Dashboard Hi Ambarish & Sanjay There were two approaches that were being looked at. The first was to use the same GUI plugin for both the platform horizon and containerized horizon, but only copy over the horizon 'enabled' files corresponding to the panels that we want to enable (fault panels in the containerized case). This is the approach that was tried but it ended up not working and required lots of hacks during the docker image build step, such as modifying the code, which we really want to avoid. The reasons it wasn't working weren't really clear to me, I didn't spend time debugging etc. Attached is some background on what was being discussed then. [AD/SM]: We are clear with this approach and I believe the abandoned patch has the required hack for this implementation (https://review.opendev.org/#/c/661423/4). We are able to reproduce this step with docker image build for stx-horizon and FM Panel is visible in openstack dashboard. Please let us know if anything wrong in this understanding/reproduction steps. The decision was made to instead split our plugin into two, one for the platform panels, and one for just the fault panels. This will involve creating a new package next to starlingx-dashboard (in the same repo though) that has a similar structure but only has the relevant fault components. Including: Api/fm.py Api/rest/fm.py Dashboards/admin/active_alarms/ Static/dashboard/fault_management/ Enabled/ -> need the fm related enabled files in here, along with the banner view header section definition (see ADD_HEADER_SECTIONS). These files will get copied over in the docker image build step. The only other instruction in this step should be the csrftoken customization command from the attached email, which I think unfortunately is required. [AD/SM]: As per our understanding all these changes will be part of stx-gui module. Need more information regarding stx-gui component to understand better. Please let us know if any documentation link there to refer for this module ( It would be really helpful if we can approach a POC/module expert for this). Also was there any patch created with these changes earlier? As for the settings for the containerized horizon, they are stored in the openstack helm application manifest here: openstack-armada-app/stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml My understanding is fault management will remain in the platform as well. A distributed cloud deployment will also have to be tested, as the dc_admin dashboard also queries fm. There's decent documentation on the plugin structure upstream: https://docs.openstack.org/horizon/latest/contributor/tutorials/plugin.html Let me know if you need more details Tyler From: Das, Ambarish [mailto:ambarish.das@intel.com] Sent: Wednesday, May 13, 2020 2:22 AM To: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Smith, Tyler <tyler.smith@windriver.com<mailto:tyler.smith@windriver.com>> Cc: Wold, Saul <saul.wold@intel.com<mailto:saul.wold@intel.com>>; Jones, Bruce E <bruce.e.jones@intel.com<mailto:bruce.e.jones@intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com<mailto:gopalkrishna.bhat@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com<mailto:sanjay.k.mukherjee@intel.com>>; Sun, Austin <austin.sun@intel.com<mailto:austin.sun@intel.com>> Subject: Fault Containerization: Enable FM panels in Openstack Dashboard Hello Tyler & Don, We have started looking into the remaining work in Fault Containerization and looked into the earlier abandoned patch implementation (https://review.opendev.org/#/c/661423/). As we have joined the team newly, we would like to understand GUI and Horizon implementation and next steps to move forward regarding this pending activity. We had a initial discussion regarding this with Saul and Austin and based on their inputs, we would like to have a discussion. Please let me know if you need any clarification. Thanks & regards, Ambarish/Sanjay
Responses inline Thanks, Tyler From: Das, Ambarish [mailto:ambarish.das@intel.com] Sent: Friday, May 29, 2020 7:39 AM To: Smith, Tyler <tyler.smith@windriver.com>; Penney, Don <Don.Penney@windriver.com>; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com> Cc: Wold, Saul <saul.wold@intel.com>; Jones, Bruce E <bruce.e.jones@intel.com>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com>; starlingx-discuss@lists.starlingx.io; Sun, Austin <austin.sun@intel.com>; Eslimi, Dariush <Dariush.Eslimi@windriver.com> Subject: RE: Fault Containerization: Enable FM panels in Openstack Dashboard Hi Tyler, Thanks for explaining the details and we have few queries inline Thanks & regards, Ambarish/Sanjay From: Smith, Tyler <tyler.smith@windriver.com<mailto:tyler.smith@windriver.com>> Sent: Friday, May 15, 2020 1:35 AM To: Das, Ambarish <ambarish.das@intel.com<mailto:ambarish.das@intel.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com<mailto:sanjay.k.mukherjee@intel.com>> Cc: Wold, Saul <saul.wold@intel.com<mailto:saul.wold@intel.com>>; Jones, Bruce E <bruce.e.jones@intel.com<mailto:bruce.e.jones@intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com<mailto:gopalkrishna.bhat@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>; Sun, Austin <austin.sun@intel.com<mailto:austin.sun@intel.com>>; Eslimi, Dariush <Dariush.Eslimi@windriver.com<mailto:Dariush.Eslimi@windriver.com>> Subject: RE: Fault Containerization: Enable FM panels in Openstack Dashboard Hi Ambarish & Sanjay There were two approaches that were being looked at. The first was to use the same GUI plugin for both the platform horizon and containerized horizon, but only copy over the horizon 'enabled' files corresponding to the panels that we want to enable (fault panels in the containerized case). This is the approach that was tried but it ended up not working and required lots of hacks during the docker image build step, such as modifying the code, which we really want to avoid. The reasons it wasn't working weren't really clear to me, I didn't spend time debugging etc. Attached is some background on what was being discussed then. [AD/SM]: We are clear with this approach and I believe the abandoned patch has the required hack for this implementation (https://review.opendev.org/#/c/661423/4). We are able to reproduce this step with docker image build for stx-horizon and FM Panel is visible in openstack dashboard. Please let us know if anything wrong in this understanding/reproduction steps. [TS] Yes, the abandoned patch was working, but need to find a way to do it without those kinds of hacks The decision was made to instead split our plugin into two, one for the platform panels, and one for just the fault panels. This will involve creating a new package next to starlingx-dashboard (in the same repo though) that has a similar structure but only has the relevant fault components. Including: Api/fm.py Api/rest/fm.py Dashboards/admin/active_alarms/ Static/dashboard/fault_management/ Enabled/ -> need the fm related enabled files in here, along with the banner view header section definition (see ADD_HEADER_SECTIONS). These files will get copied over in the docker image build step. The only other instruction in this step should be the csrftoken customization command from the attached email, which I think unfortunately is required. [AD/SM]: As per our understanding all these changes will be part of stx-gui module. Need more information regarding stx-gui component to understand better. Please let us know if any documentation link there to refer for this module ( It would be really helpful if we can approach a POC/module expert for this). Also was there any patch created with these changes earlier? [TS] Yes, the changes will be to stx-gui, there's no specific documentation on that module, but as it is a horizon plugin it will roughly follow the structure and features in the openstack plugin documentation mentioned below. If you have specific questions feel free to ask me. There has been no prior attempt at this approach As for the settings for the containerized horizon, they are stored in the openstack helm application manifest here: openstack-armada-app/stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml My understanding is fault management will remain in the platform as well. A distributed cloud deployment will also have to be tested, as the dc_admin dashboard also queries fm. There's decent documentation on the plugin structure upstream: https://docs.openstack.org/horizon/latest/contributor/tutorials/plugin.html Let me know if you need more details Tyler From: Das, Ambarish [mailto:ambarish.das@intel.com] Sent: Wednesday, May 13, 2020 2:22 AM To: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Smith, Tyler <tyler.smith@windriver.com<mailto:tyler.smith@windriver.com>> Cc: Wold, Saul <saul.wold@intel.com<mailto:saul.wold@intel.com>>; Jones, Bruce E <bruce.e.jones@intel.com<mailto:bruce.e.jones@intel.com>>; Bhat, Gopalkrishna <gopalkrishna.bhat@intel.com<mailto:gopalkrishna.bhat@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>; Mukherjee, Sanjay K <sanjay.k.mukherjee@intel.com<mailto:sanjay.k.mukherjee@intel.com>>; Sun, Austin <austin.sun@intel.com<mailto:austin.sun@intel.com>> Subject: Fault Containerization: Enable FM panels in Openstack Dashboard Hello Tyler & Don, We have started looking into the remaining work in Fault Containerization and looked into the earlier abandoned patch implementation (https://review.opendev.org/#/c/661423/). As we have joined the team newly, we would like to understand GUI and Horizon implementation and next steps to move forward regarding this pending activity. We had a initial discussion regarding this with Saul and Austin and based on their inputs, we would like to have a discussion. Please let me know if you need any clarification. Thanks & regards, Ambarish/Sanjay
participants (2)
-
Das, Ambarish
-
Smith, Tyler