[Starlingx-discuss] PCI Interrupt affinity task
Hi all
Recently, I have being working on pci interrupt affinity task (https://storyboard.openstack.org/#!/story/2004600) So far I have finished coding, basic deployment test and function test. Now, I'm preparing for uploading my patch for code review. However, I need to decide where to put code folder.
From my point, there are two options below.
1) stx-integ/utilities/nova-utils/pci-affinity-agent
2) stx-config/sysinv/pci-affinity-agent (I put code here currently) I prefer option 1 as nova-utils is just used to install nova-sriov script only and pci affinity is also an extended feature for nova. We can reuse nova-utils package with additional RPM for pci-affinity-agent
Any comment from you? Thanks!
zhipeng
Zhipeng, Option 1) is a reasonable choice. I agree with your reasoning. FYI, I don't think we depend on nova-sriov script anymore, but we haven't actually tested with that removed.
Please add me to your code inspection. -Jim
From: Liu, ZhipengS [mailto:zhipengs.liu@intel.com] Sent: February-21-19 10:24 PM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] PCI Interrupt affinity task
Hi all
Recently, I have being working on pci interrupt affinity task (https://storyboard.openstack.org/#!/story/2004600) So far I have finished coding, basic deployment test and function test. Now, I'm preparing for uploading my patch for code review. However, I need to decide where to put code folder.
From my point, there are two options below.
1) stx-integ/utilities/nova-utils/pci-affinity-agent
2) stx-config/sysinv/pci-affinity-agent (I put code here currently) I prefer option 1 as nova-utils is just used to install nova-sriov script only and pci affinity is also an extended feature for nova. We can reuse nova-utils package with additional RPM for pci-affinity-agent
Any comment from you? Thanks!
zhipeng
Jim,
Thanks for your comment! I will add you to review my patch after my patch submitted.
Zhipeng
From: Gauld, James [mailto:James.Gauld@windriver.com] Sent: 2019年2月26日 22:07 To: Liu, ZhipengS zhipengs.liu@intel.com; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] PCI Interrupt affinity task
Zhipeng, Option 1) is a reasonable choice. I agree with your reasoning. FYI, I don’t think we depend on nova-sriov script anymore, but we haven't actually tested with that removed.
Please add me to your code inspection. -Jim
From: Liu, ZhipengS [mailto:zhipengs.liu@intel.com] Sent: February-21-19 10:24 PM To: starlingx-discuss@lists.starlingx.iomailto:starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] PCI Interrupt affinity task
Hi all
Recently, I have being working on pci interrupt affinity task (https://storyboard.openstack.org/#!/story/2004600) So far I have finished coding, basic deployment test and function test. Now, I’m preparing for uploading my patch for code review. However, I need to decide where to put code folder.
From my point, there are two options below.
1) stx-integ/utilities/nova-utils/pci-affinity-agent
2) stx-config/sysinv/pci-affinity-agent (I put code here currently) I prefer option 1 as nova-utils is just used to install nova-sriov script only and pci affinity is also an extended feature for nova. We can reuse nova-utils package with additional RPM for pci-affinity-agent
Any comment from you? Thanks!
zhipeng
Hi Jim and all,
I have submitted all my patches for PCI Interrupt affinity feature as below link.
https://review.openstack.org/#/c/640264/
https://review.openstack.org/#/c/640263/ Below one is the patch for removing pci-irq-affinity function from nova. https://github.com/hustlzp1981/stx-nova/commit/c52432b3e7a240817a2de06321a24...
Your comments are appreciated!
Thanks! Zhipeng
From: Gauld, James [mailto:James.Gauld@windriver.com] Sent: 2019年2月26日 22:07 To: Liu, ZhipengS zhipengs.liu@intel.com; starlingx-discuss@lists.starlingx.io Subject: Re: [Starlingx-discuss] PCI Interrupt affinity task
Zhipeng, Option 1) is a reasonable choice. I agree with your reasoning. FYI, I don’t think we depend on nova-sriov script anymore, but we haven't actually tested with that removed.
Please add me to your code inspection. -Jim
From: Liu, ZhipengS [mailto:zhipengs.liu@intel.com] Sent: February-21-19 10:24 PM To: starlingx-discuss@lists.starlingx.iomailto:starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] PCI Interrupt affinity task
Hi all
Recently, I have being working on pci interrupt affinity task (https://storyboard.openstack.org/#!/story/2004600) So far I have finished coding, basic deployment test and function test. Now, I’m preparing for uploading my patch for code review. However, I need to decide where to put code folder.
From my point, there are two options below.
1) stx-integ/utilities/nova-utils/pci-affinity-agent
2) stx-config/sysinv/pci-affinity-agent (I put code here currently) I prefer option 1 as nova-utils is just used to install nova-sriov script only and pci affinity is also an extended feature for nova. We can reuse nova-utils package with additional RPM for pci-affinity-agent
Any comment from you? Thanks!
zhipeng
participants (2)
-
Gauld, James
-
Liu, ZhipengS