Re: [Starlingx-discuss] Status of f/centos8 pending reviews
Oops, /me forgot to add the discuss list! Sau! On 11/9/20 5:27 PM, Saul Wold wrote:
Cores & Centos8 Team members
There are many pending f/centos8 patches pending review [0] still, some as old as mid-May!
We we start to spin this work up again, I have already put out a request from the original community team to do the initial rebase, but we also need to understand why some of these pending reviews have not been merged. Should they be merged before the rebase or after?
Many of these have at least 1 +2 and need a second +2 and +W. I have CC'ed the cores of the STX-Upstream Project where many of these are pending in.
Please take some time to review these.
[0] https://review.opendev.org/#/q/projects:starlingx/+AND+topic:centos8+AND+sta...
Thanks Sau!
-- Sau!
I have posted two updates for review that introduce into the master branch build tool changes to support a Centos8 build environment. This only covers generate-centos-repo.sh, build-pkgs and build-iso. https://review.opendev.org/#/c/762701/ https://review.opendev.org/#/c/762700/ I have not yet defined the Centos8 Docker file. Scott On 2020-11-10 12:01 a.m., Saul Wold wrote:
Oops, /me forgot to add the discuss list!
Sau!
On 11/9/20 5:27 PM, Saul Wold wrote:
Cores & Centos8 Team members
There are many pending f/centos8 patches pending review [0] still, some as old as mid-May!
We we start to spin this work up again, I have already put out a request from the original community team to do the initial rebase, but we also need to understand why some of these pending reviews have not been merged. Should they be merged before the rebase or after?
Many of these have at least 1 +2 and need a second +2 and +W. I have CC'ed the cores of the STX-Upstream Project where many of these are pending in.
Please take some time to review these.
[0] https://review.opendev.org/#/q/projects:starlingx/+AND+topic:centos8+AND+sta...
Thanks Sau!
Scott, Thanks for starting to take a work on this. I am taking a look at this, will this make merging master with the existing f/centos8 branches harder or easier? Should we do the merge of master first and then make the changes and merge again? I know we are going to have do more merges to keep f/centos8 current with master. Thanks for the support! Sau! On 11/13/20 10:31 AM, Scott Little wrote:
I have posted two updates for review that introduce into the master branch build tool changes to support a Centos8 build environment. This only covers generate-centos-repo.sh, build-pkgs and build-iso.
https://review.opendev.org/#/c/762701/ https://review.opendev.org/#/c/762700/
I have not yet defined the Centos8 Docker file.
Scott
On 2020-11-10 12:01 a.m., Saul Wold wrote:
Oops, /me forgot to add the discuss list!
Sau!
On 11/9/20 5:27 PM, Saul Wold wrote:
Cores & Centos8 Team members
There are many pending f/centos8 patches pending review [0] still, some as old as mid-May!
We we start to spin this work up again, I have already put out a request from the original community team to do the initial rebase, but we also need to understand why some of these pending reviews have not been merged. Should they be merged before the rebase or after?
Many of these have at least 1 +2 and need a second +2 and +W. I have CC'ed the cores of the STX-Upstream Project where many of these are pending in.
Please take some time to review these.
[0] https://review.opendev.org/#/q/projects:starlingx/+AND+topic:centos8+AND+sta...
Thanks Sau!
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
-- Sau!
participants (2)
-
Saul Wold
-
Scott Little