[Starlingx-discuss] patch review for docker image build
Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com>; Penney, Don <Don.Penney@windriver.com> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com>; Penney, Don <Don.Penney@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
Hi Penney I update again. Please go on review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Penney, Don <Don.Penney@windriver.com> Sent: Wednesday, March 31, 2021 11:20 AM To: Chen, Haochuan Z <haochuan.z.chen@intel.com>; Little, Scott <Scott.Little@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: patch review for docker image build I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
Hi scott Please review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Thursday, April 1, 2021 10:40 AM To: Penney, Don <Don.Penney@windriver.com>; Little, Scott <Scott.Little@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: patch review for docker image build Hi Penney I update again. Please go on review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Sent: Wednesday, March 31, 2021 11:20 AM To: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
Hi scott Please review my patch for docker image build https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Friday, April 2, 2021 9:01 AM To: Little, Scott <Scott.Little@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: patch review for docker image build Hi scott Please review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Thursday, April 1, 2021 10:40 AM To: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build Hi Penney I update again. Please go on review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Sent: Wednesday, March 31, 2021 11:20 AM To: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
Hi AL, scott and John Please review my patch for docker image build https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Saturday, April 3, 2021 10:01 AM To: 'Little, Scott' <Scott.Little@windriver.com> Cc: 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build Hi scott Please review my patch for docker image build https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Friday, April 2, 2021 9:01 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build Hi scott Please review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Thursday, April 1, 2021 10:40 AM To: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build Hi Penney I update again. Please go on review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Sent: Wednesday, March 31, 2021 11:20 AM To: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
Hi AL, scott and John Please review my patch for docker image build. There is already get one +2 https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Tuesday, April 6, 2021 7:38 AM To: Little, Scott <Scott.Little@windriver.com>; Church, Robert <Robert.Church@windriver.com>; Kung, John <John.Kung@windriver.com>; Bailey, Henry Albert (Al) <Al.Bailey@windriver.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: patch review for docker image build Hi AL, scott and John Please review my patch for docker image build https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Saturday, April 3, 2021 10:01 AM To: 'Little, Scott' <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: RE: patch review for docker image build Hi scott Please review my patch for docker image build https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Friday, April 2, 2021 9:01 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build Hi scott Please review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 Thanks! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Thursday, April 1, 2021 10:40 AM To: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build Hi Penney I update again. Please go on review my patch. https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Sent: Wednesday, March 31, 2021 11:20 AM To: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: patch review for docker image build I've been reviewing your patch, thanks. My last review added a comment with multiple points and a question. You dealt with the first part of the comment, but not the second, and didn't respond to the comment or question. But I can certainly add that second part again in another comment. Cheers, Don. From: Chen, Haochuan Z <haochuan.z.chen@intel.com<mailto:haochuan.z.chen@intel.com>> Sent: Tuesday, March 30, 2021 8:33 PM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: patch review for docker image build [Please note: This e-mail is from an EXTERNAL e-mail address] Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330 From: Chen, Haochuan Z Sent: Monday, March 29, 2021 7:37 PM To: Scott Little <scott.little@windriver.com<mailto:scott.little@windriver.com>>; Penney, Don <Don.Penney@windriver.com<mailto:Don.Penney@windriver.com>> Subject: patch review for docker image build Hi Don Penney & Scott Please review my patch. Thanks! https://review.opendev.org/c/starlingx/utilities/+/783128 BR! Martin, Chen IOTG, Software Engineer 021-61164330
participants (2)
-
Chen, Haochuan Z
-
Penney, Don