[Starlingx-discuss] Makefile Standardization Spec
Ian & reset of TSC: Erich just pushed a fixed version of the Makefile spec (https://review.openstack.org/#/c/610672/) , there was no content change, just the update to fix Tox Lint issues and moving it to the 2019.03 directory. Will this restart the 2 day timers? Thanks Sau!
On Thu, Oct 25, 2018 at 2:27 PM Saul Wold <sgw@linux.intel.com> wrote:
Erich just pushed a fixed version of the Makefile spec (https://review.openstack.org/#/c/610672/) , there was no content change, just the update to fix Tox Lint issues and moving it to the 2019.03 directory.
Will this restart the 2 day timers?
I don't think it should need to but at least one of us should verify that it was only format-type changes then +W it again. If content changed then I would think the review cycle starts over. dt -- Dean Troyer dtroyer@gmail.com
On 10/25/2018 01:24 PM, Dean Troyer wrote:
On Thu, Oct 25, 2018 at 2:27 PM Saul Wold <sgw@linux.intel.com> wrote:
Erich just pushed a fixed version of the Makefile spec (https://review.openstack.org/#/c/610672/) , there was no content change, just the update to fix Tox Lint issues and moving it to the 2019.03 directory.
Will this restart the 2 day timers?
I don't think it should need to but at least one of us should verify that it was only format-type changes then +W it again. If content changed then I would think the review cycle starts over.
It's white space and fixing a couple of URL's to the stx-*, no actual content changes. Sau!
dt
On 10/25/2018 01:24 PM, Dean Troyer wrote: > On Thu, Oct 25, 2018 at 2:27 PM Saul Wold <sgw@linux.intel.com> wrote: >> Erich just pushed a fixed version of the Makefile spec >> (https://review.openstack.org/#/c/610672/) , there was no content >> change, just the update to fix Tox Lint issues and moving it to the >> 2019.03 directory. >> >> Will this restart the 2 day timers? > > I don't think it should need to but at least one of us should verify > that it was only format-type changes then +W it again. If content > changed then I would think the review cycle starts over. > It's white space and fixing a couple of URL's to the stx-*, no actual content changes. Sau! I will have a look and push it through for formatting only Ian > dt >
Thank you all :) On Thu, 2018-10-25 at 20:35 +0000, Jolliffe, Ian wrote:
On 10/25/2018 01:24 PM, Dean Troyer wrote: > On Thu, Oct 25, 2018 at 2:27 PM Saul Wold <sgw@linux.intel.com> wrote: >> Erich just pushed a fixed version of the Makefile spec >> (https://review.openstack.org/#/c/610672/) , there was no content >> change, just the update to fix Tox Lint issues and moving it to the >> 2019.03 directory. >> >> Will this restart the 2 day timers? > > I don't think it should need to but at least one of us should verify > that it was only format-type changes then +W it again. If content > changed then I would think the review cycle starts over. > It's white space and fixing a couple of URL's to the stx-*, no actual content changes.
Sau!
I will have a look and push it through for formatting only
Ian
> dt >
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
participants (4)
-
Cordoba Malibran, Erich
-
Dean Troyer
-
Jolliffe, Ian
-
Saul Wold