[Starlingx-discuss] Help needed to add patch to openstackclient
Hi Folks: What is the steps to add patch to openstackclient for stx.1.0. Currently we have some problems with the openstack cli, and already find solutions, but stuck in the commit steps. Any help will be appreciated! Best Regards Song.Gao
Currently the manifest for starlingx openstackclient builds from stable/stein. https://opendev.org/starlingx/manifest/src/branch/master/default.xml#L51 So if your fix is merged in vanilla openstackclient, and back-ported to the stable stein branch, it will get picked up automatically. If you need to temporarily diverge from vanilla openstack, we typically request that the gerrit review be submitted to the openstack community, and then we can temporarily merge it as a patch until the two environments are able to become in sync. We do that with openstack-helm https://opendev.org/starlingx/upstream/src/branch/master/openstack/openstack... Al From: Song Gao song (高松) [mailto:gaosong.lc@inspur.com] Sent: Thursday, July 04, 2019 8:38 AM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] Help needed to add patch to openstackclient Hi Folks: What is the steps to add patch to openstackclient for stx.1.0. Currently we have some problems with the openstack cli, and already find solutions, but stuck in the commit steps. Any help will be appreciated! Best Regards Song.Gao
Thanks for your timely response! But, per starlingx 2018.10 how the openstackclient package built, is it built from the repo hosted in starlingx/upstream? And if it’s right, I can make ti straight to commit to upstream. 发件人: Bailey, Henry Albert (Al) [mailto:Al.Bailey@windriver.com] 发送时间: 2019年7月4日 21:13 收件人: Song Gao song (高松) <gaosong.lc@inspur.com>; starlingx-discuss@lists.starlingx.io 主题: RE: Help needed to add patch to openstackclient Currently the manifest for starlingx openstackclient builds from stable/stein. https://opendev.org/starlingx/manifest/src/branch/master/default.xml#L51 So if your fix is merged in vanilla openstackclient, and back-ported to the stable stein branch, it will get picked up automatically. If you need to temporarily diverge from vanilla openstack, we typically request that the gerrit review be submitted to the openstack community, and then we can temporarily merge it as a patch until the two environments are able to become in sync. We do that with openstack-helm https://opendev.org/starlingx/upstream/src/branch/master/openstack/openstack -helm Al From: Song Gao song (高松) [mailto:gaosong.lc@inspur.com] Sent: Thursday, July 04, 2019 8:38 AM To: starlingx-discuss@lists.starlingx.io <mailto:starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] Help needed to add patch to openstackclient Hi Folks: What is the steps to add patch to openstackclient for stx.1.0. Currently we have some problems with the openstack cli, and already find solutions, but stuck in the commit steps. Any help will be appreciated! Best Regards Song.Gao
My mistake, my response was based on the current codebase and release. I don’t know what the procedure is for porting or supporting fixes in older STX releases. Al From: Song Gao song (高松) [mailto:gaosong.lc@inspur.com] Sent: Thursday, July 04, 2019 9:27 AM To: Bailey, Henry Albert (Al); starlingx-discuss@lists.starlingx.io Subject: 答复: Help needed to add patch to openstackclient Thanks for your timely response! But, per starlingx 2018.10 how the openstackclient package built, is it built from the repo hosted in starlingx/upstream? And if it’s right, I can make ti straight to commit to upstream. 发件人: Bailey, Henry Albert (Al) [mailto:Al.Bailey@windriver.com] 发送时间: 2019年7月4日 21:13 收件人: Song Gao song (高松) <gaosong.lc@inspur.com>; starlingx-discuss@lists.starlingx.io 主题: RE: Help needed to add patch to openstackclient Currently the manifest for starlingx openstackclient builds from stable/stein. https://opendev.org/starlingx/manifest/src/branch/master/default.xml#L51 So if your fix is merged in vanilla openstackclient, and back-ported to the stable stein branch, it will get picked up automatically. If you need to temporarily diverge from vanilla openstack, we typically request that the gerrit review be submitted to the openstack community, and then we can temporarily merge it as a patch until the two environments are able to become in sync. We do that with openstack-helm https://opendev.org/starlingx/upstream/src/branch/master/openstack/openstack... Al From: Song Gao song (高松) [mailto:gaosong.lc@inspur.com] Sent: Thursday, July 04, 2019 8:38 AM To: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: [Starlingx-discuss] Help needed to add patch to openstackclient Hi Folks: What is the steps to add patch to openstackclient for stx.1.0. Currently we have some problems with the openstack cli, and already find solutions, but stuck in the commit steps. Any help will be appreciated! Best Regards Song.Gao
On 7/4/19 8:27 AM, Song Gao song (高松) wrote:
Thanks for your timely response!
But, per starlingx 2018.10 how the openstackclient package built, is it built from the repo hosted in starlingx/upstream?
IIRC the 2018.10 build is based on OSC's stable/pike branch, which is now out of maintenance. OSC is designed to be usable from master with every cloud going back to Juno or so. The issue will be if it needs to be co-installed with other Python dependencies. If you can run OSC from another system or from a virtual env to should be able to use the current 3.19.0 release with StarlingX.
And if it’s right, I can make ti straight to commit to upstream.
Is this an issue that has been fixed upstream? dt -- Dean Troyer dtroyer@gmail.com
Yes, it has been fixed, but cannot be directly used because maybe the related novaclient or cinderclient project need to upgrade at the same time. It seems that the only solution is to add patch to the starlingx/upstream r2018.10 branch, isn't it?
-----The Original----- project: [lists.starlingx.io] Re: [Starlingx-discuss] RE: Help needed to add patch to openstackclient
On 7/4/19 8:27 AM, Song Gao song wrote:
Thanks for your timely response!
But, per starlingx 2018.10 how the openstackclient package built, is it built from the repo hosted in starlingx/upstream?
IIRC the 2018.10 build is based on OSC's stable/pike branch, which is now out of maintenance.
OSC is designed to be usable from master with every cloud going back to Juno or so. The issue will be if it needs to be co-installed with other Python dependencies. If you can run OSC from another system or from a virtual env to should be able to use the current 3.19.0 release with StarlingX.
And if it’s right, I can make ti straight to commit to upstream.
Is this an issue that has been fixed upstream?
dt
-- Dean Troyer dtroyer@gmail.com
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
On 7/4/19 10:16 AM, Song Gao song (高松) wrote:
Yes, it has been fixed, but cannot be directly used because maybe the related novaclient or cinderclient project need to upgrade at the same time. It seems that the only solution is to add patch to the starlingx/upstream r2018.10 branch, isn't it?
If you need to continue with that release, yes you will need to backport whatever patches you need. pike is on 'extended maintenance' upstream so nothing that is not a CVE will get fixed there now. If the fix also depends on other client libs you will need to bring those down too. Is this fix required for the internal operations of StarlingX? ie, is it the puppet or other internal code that needs it, or is it for your administrative uses that you need it? If it is for admin use, you can install OSC 3.19.0 into a virtual env, even on a controller if necessary, and use it directly. dt -- Dean Troyer dtroyer@gmail.com
as Dean mentioned, there might be other way to resolve the problems you see. Probably you can paste your patch here to community so that guys can come up with some suggestions? On 04/07/2019 8:42 AM, Dean Troyer wrote:
On 7/4/19 10:16 AM, Song Gao song (高松) wrote:
Yes, it has been fixed, but cannot be directly used because maybe the related novaclient or cinderclient project need to upgrade at the same time. It seems that the only solution is to add patch to the starlingx/upstream r2018.10 branch, isn't it?
If you need to continue with that release, yes you will need to backport whatever patches you need. pike is on 'extended maintenance' upstream so nothing that is not a CVE will get fixed there now.
If the fix also depends on other client libs you will need to bring those down too.
Is this fix required for the internal operations of StarlingX? ie, is it the puppet or other internal code that needs it, or is it for your administrative uses that you need it? If it is for admin use, you can install OSC 3.19.0 into a virtual env, even on a controller if necessary, and use it directly.
dt
It's an error in openstackclient/volume/v2/backup.py, line 322, the return value of the "take_action" is an object which is incorrect for the command line return info. I just modify it to the value of _info()
-----邮件原件----- 发件人: Yong Hu [mailto:yong.hu@intel.com] 发送时间: 2019年7月8日 11:52 收件人: starlingx-discuss@lists.starlingx.io 主题: [lists.starlingx.io代发]Re: [Starlingx-discuss] 答复: [lists.starlingx.io代 发]Re: 答复: Help needed to add patch to openstackclient
as Dean mentioned, there might be other way to resolve the problems you see. Probably you can paste your patch here to community so that guys can come up with some suggestions?
On 04/07/2019 8:42 AM, Dean Troyer wrote:
On 7/4/19 10:16 AM, Song Gao song (高松) wrote:
Yes, it has been fixed, but cannot be directly used because maybe the related novaclient or cinderclient project need to upgrade at the same time. It seems that the only solution is to add patch to the starlingx/upstream r2018.10 branch, isn't it?
If you need to continue with that release, yes you will need to backport whatever patches you need. pike is on 'extended maintenance' upstream so nothing that is not a CVE will get fixed there now.
If the fix also depends on other client libs you will need to bring those down too.
Is this fix required for the internal operations of StarlingX? ie, is it the puppet or other internal code that needs it, or is it for your administrative uses that you need it? If it is for admin use, you can install OSC 3.19.0 into a virtual env, even on a controller if necessary, and use it directly.
dt
_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss
participants (4)
-
Bailey, Henry Albert (Al)
-
Dean Troyer
-
Song Gao song (高松)
-
Yong Hu