Thanks Erich. Al will be updating the stx-manifest to set horizon to stable/stein rather than master, so we don't get impacted by Train changes like this. -----Original Message----- From: Cordoba Malibran, Erich [mailto:erich.cordoba.malibran@intel.com] Sent: Wednesday, May 08, 2019 9:03 AM To: starlingx-discuss@lists.starlingx.io Subject: [Starlingx-discuss] [Build] Failure building python-django-horizon Hi, Our build failed due a change in horizon[0], I sent this review[1], although it fixes the building I'm not sure of the implications in the functionality of this change. Can you help me to take a look? Thanks. -Erich - [0] https://review.opendev.org/#/c/645515/  - [1] https://review.opendev.org/#/c/657792/ _______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss

Thanks for the patch, Erich . I was wondering if we have these test cases integrated : https://docs.openstack.org/horizon/latest/contributor/testing.html If so, great, if not what kind of test do we have for Horizon? Regards Victor Rodriguez On Wed, May 8, 2019 at 8:03 AM Cordoba Malibran, Erich <erich.cordoba.malibran@intel.com> wrote:

Hi,

Our build failed due a change in horizon[0], I sent this review[1], although it fixes the building I'm not sure of the implications in the functionality of this change.

Can you help me to take a look?

Thanks.

-Erich

- [0] https://review.opendev.org/#/c/645515/  - [1] https://review.opendev.org/#/c/657792/

_______________________________________________ Starlingx-discuss mailing list Starlingx-discuss@lists.starlingx.io http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss