Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code
To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operat... Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I'm responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal
Will do Scott On 2023-08-03 12:41, Khalil, Ghada wrote:
To clarify, we need at @Little, Scott <mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operat...
Regards,
Ghada
*From:* Lal, RafalX <rafalx.lal@intel.com> *Sent:* Thursday, August 3, 2023 11:18 AM *To:* Little, Scott <Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> *Cc:* Khalil, Ghada <Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com> *Subject:* Review of app-intel-ethernet-operator code
*CAUTION: This email comes from a non Wind River email account!* Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hello,
I’m responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change <https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time.
Best Regards
Rafal
I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote:
To clarify, we need at @Little, Scott <mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operat...
Regards,
Ghada
*From:* Lal, RafalX <rafalx.lal@intel.com> *Sent:* Thursday, August 3, 2023 11:18 AM *To:* Little, Scott <Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> *Cc:* Khalil, Ghada <Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com> *Subject:* Review of app-intel-ethernet-operator code
*CAUTION: This email comes from a non Wind River email account!* Do not click links or open attachments unless you recognize the sender and know the content is safe.
Hello,
I’m responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change <https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time.
Best Regards
Rafal
Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com>; Lal, RafalX <rafalx.lal@intel.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operat... Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I’m responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal
It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dc... Regards, Igor ________________________________ From: Pires Soares, Igor <Igor.PiresSoares@windriver.com> Sent: Friday, August 4, 2023 10:53 AM To: Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Lal, RafalX <rafalx.lal@intel.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com>; Lal, RafalX <rafalx.lal@intel.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https://review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$> Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I’m responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal
On 2023-08-04 15:27:50 +0000 (+0000), Pires Soares, Igor wrote:
It seems that I cannot +2 on the intel-ethernet-operator repo. [...]
It looks like a typographical error in the group name was missed in review. The (empty) starlingx-intel-ethernet-operator-core group has code review/approval permissions, while a separate starlingx-app-intel-ethernet-operator-core group (which Scott asked me to add him to) has permission to abandon changes for that repository. I've pushed up a change to switch the review/approval permissions to the starlingx-app-intel-ethernet-operator-core group, if someone can confirm that was the actual intent: https://review.opendev.org/890569 -- Jeremy Stanley
It looks empty to me also. Regards, Rafal From: Pires Soares, Igor <Igor.PiresSoares@windriver.com> Sent: 04 August 2023 17:28 To: Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <ghada.khalil@windriver.com>; Lal, RafalX <rafalx.lal@intel.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <steven.webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io Subject: Re: Review of app-intel-ethernet-operator code It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dc... Regards, Igor ________________________________ From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: Friday, August 4, 2023 10:53 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https:/review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$> Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I'm responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal
On 2023-08-07 18:00:55 +0000 (+0000), Lal, RafalX wrote:
It looks empty to me also. [...]
Please see my earlier reply about this topic. The presumed fix has been waiting since Friday for someone from the StarlingX community to double-check the suspected typographical error in the ACL for that project. If you can confirm the group name was supposed to be starlingx-app-intel-ethernet-operator-core instead of starlingx-intel-ethernet-operator-core then please +1 https://review.opendev.org/890569 and I'll merge it straight away. -- Jeremy Stanley
Thanks Jeremy, LGTM. +1. Regards, Bob From: Jeremy Stanley <fungi@yuggoth.org> Date: Monday, August 7, 2023 at 2:28 PM To: starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. On 2023-08-07 18:00:55 +0000 (+0000), Lal, RafalX wrote:
It looks empty to me also. [...]
Please see my earlier reply about this topic. The presumed fix has been waiting since Friday for someone from the StarlingX community to double-check the suspected typographical error in the ACL for that project. If you can confirm the group name was supposed to be starlingx-app-intel-ethernet-operator-core instead of starlingx-intel-ethernet-operator-core then please +1 https://review.opendev.org/890569 and I'll merge it straight away. -- Jeremy Stanley
On 2023-08-07 22:47:11 +0000 (+0000), Church, Robert wrote:
Thanks Jeremy, LGTM. +1. [...]
And thanks for the extra set of eyeballs on it. Merged and deployed as of about 45 minutes ago, so people should check again whether they can approve changes for that project now (you may need to force refresh your browser tab if you already have Gerrit open in it). -- Jeremy Stanley
@Pires Soares, Igor<mailto:Igor.PiresSoares@windriver.com> @Reed, Joshua<mailto:Joshua.Reed@windriver.com> - is there anything we need to/can help do from the Intel side here ? I see this (with the turn-based set to Joshua I think) [cid:image001.png@01D9C9E8.C5421BE0] From: Lal, RafalX <rafalx.lal@intel.com> Sent: Monday, August 7, 2023 7:01 PM To: Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <ghada.khalil@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <steven.webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io Subject: RE: Review of app-intel-ethernet-operator code It looks empty to me also. Regards, Rafal From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: 04 August 2023 17:28 To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <ghada.khalil@windriver.com<mailto:ghada.khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <steven.webster@windriver.com<mailto:steven.webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: Re: Review of app-intel-ethernet-operator code It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dc... Regards, Igor ________________________________ From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: Friday, August 4, 2023 10:53 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https:/review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$> Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I'm responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
It looks good on the Gerrit side now. I was able to proceed with the review there. Regards, Igor ________________________________ From: Walsh, Richard <richard.walsh@intel.com> Sent: Tuesday, August 8, 2023 7:09 AM To: Lal, RafalX <rafalx.lal@intel.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <Steven.Webster@windriver.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io <starlingx-discuss@lists.starlingx.io>; Kenny, Emma <emma.kenny@intel.com>; Juele, John Rey <john.rey.juele@intel.com>; Halim, Abdul <abdul.halim@intel.com> Subject: RE: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. @Pires Soares, Igor<mailto:Igor.PiresSoares@windriver.com> @Reed, Joshua<mailto:Joshua.Reed@windriver.com> – is there anything we need to/can help do from the Intel side here ? I see this (with the turn-based set to Joshua I think) [cid:image001.png@01D9C9E8.C5421BE0] From: Lal, RafalX <rafalx.lal@intel.com> Sent: Monday, August 7, 2023 7:01 PM To: Pires Soares, Igor <Igor.PiresSoares@windriver.com>; Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <ghada.khalil@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <steven.webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io Subject: RE: Review of app-intel-ethernet-operator code It looks empty to me also. Regards, Rafal From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: 04 August 2023 17:28 To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <ghada.khalil@windriver.com<mailto:ghada.khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <steven.webster@windriver.com<mailto:steven.webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: Re: Review of app-intel-ethernet-operator code It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members<https://urldefense.com/v3/__https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members__;!!AjveYdw8EvQ!daIj2JOoRnSnu-1e8vuWlcgcYplUVwhkEWJJxc_LcjmjFMdzEyV2VfyH0qLy42yxuwG_9JbiUlXvygLgxXDPZdFP1AEd5A$> Regards, Igor ________________________________ From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: Friday, August 4, 2023 10:53 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https:/review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$> Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I’m responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Likewise - I was able to take a pass at this review today. Thanks! -Joshua Reed From: Pires Soares, Igor <Igor.PiresSoares@windriver.com> Sent: Tuesday, August 8, 2023 12:25 PM To: Walsh, Richard <richard.walsh@intel.com>; Lal, RafalX <rafalx.lal@intel.com>; Little, Scott <Scott.Little@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com> Cc: Webster, Steven <Steven.Webster@windriver.com>; Clarke, Kevin <kevin.clarke@intel.com>; starlingx-discuss@lists.starlingx.io; Kenny, Emma <emma.kenny@intel.com>; Juele, John Rey <john.rey.juele@intel.com>; Halim, Abdul <abdul.halim@intel.com> Subject: Re: Review of app-intel-ethernet-operator code It looks good on the Gerrit side now. I was able to proceed with the review there. Regards, Igor ________________________________ From: Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>> Sent: Tuesday, August 8, 2023 7:09 AM To: Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>>; Kenny, Emma <emma.kenny@intel.com<mailto:emma.kenny@intel.com>>; Juele, John Rey <john.rey.juele@intel.com<mailto:john.rey.juele@intel.com>>; Halim, Abdul <abdul.halim@intel.com<mailto:abdul.halim@intel.com>> Subject: RE: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. @Pires Soares, Igor<mailto:Igor.PiresSoares@windriver.com> @Reed, Joshua<mailto:Joshua.Reed@windriver.com> - is there anything we need to/can help do from the Intel side here ? I see this (with the turn-based set to Joshua I think) [cid:image001.png@01D9C9F6.D29FB500] From: Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>> Sent: Monday, August 7, 2023 7:01 PM To: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <ghada.khalil@windriver.com<mailto:ghada.khalil@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <steven.webster@windriver.com<mailto:steven.webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: Review of app-intel-ethernet-operator code It looks empty to me also. Regards, Rafal From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: 04 August 2023 17:28 To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <ghada.khalil@windriver.com<mailto:ghada.khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <steven.webster@windriver.com<mailto:steven.webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: Re: Review of app-intel-ethernet-operator code It seems that I cannot +2 on the intel-ethernet-operator repo. The core group looks empty to me: https://review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members<https://urldefense.com/v3/__https:/review.opendev.org/admin/groups/b654c6ae66bdface82b16ac7e4f322f311dcc71e,members__;!!AjveYdw8EvQ!daIj2JOoRnSnu-1e8vuWlcgcYplUVwhkEWJJxc_LcjmjFMdzEyV2VfyH0qLy42yxuwG_9JbiUlXvygLgxXDPZdFP1AEd5A$> Regards, Igor ________________________________ From: Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>> Sent: Friday, August 4, 2023 10:53 AM To: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: [Starlingx-discuss] Review of app-intel-ethernet-operator code Thanks, Ghada and Scott. I'll be reviewing it shortly. RafalX, in the meantime, feel free to get in touch in case you have any questions about the application framework standards. Best regards, Igor ________________________________ From: Little, Scott <Scott.Little@windriver.com<mailto:Scott.Little@windriver.com>> Sent: Thursday, August 3, 2023 3:19 PM To: Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Lal, RafalX <rafalx.lal@intel.com<mailto:rafalx.lal@intel.com>>; Pires Soares, Igor <Igor.PiresSoares@windriver.com<mailto:Igor.PiresSoares@windriver.com>>; Reed, Joshua <Joshua.Reed@windriver.com<mailto:Joshua.Reed@windriver.com>> Cc: Webster, Steven <Steven.Webster@windriver.com<mailto:Steven.Webster@windriver.com>>; Walsh, Richard <richard.walsh@intel.com<mailto:richard.walsh@intel.com>>; Clarke, Kevin <kevin.clarke@intel.com<mailto:kevin.clarke@intel.com>>; starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> <starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io>> Subject: Re: Review of app-intel-ethernet-operator code I've added the core reviewers per your request. Scott On 2023-08-03 12:41, Khalil, Ghada wrote: To clarify, we need at @Little, Scott<mailto:Scott.Little@windriver.com> to add Steve, Johusa, and Igor as core reviews on the new repo: https://review.opendev.org/q/project:starlingx%252Fapp-intel-ethernet-operator<https://urldefense.com/v3/__https:/review.opendev.org/q/project:starlingx*252Fapp-intel-ethernet-operator__;JQ!!AjveYdw8EvQ!eVcCLq0F7JqXAlL2_Huaoy1GllQDsg-MdPVidsZxlF97aLbtZi4e7oEZNex6524o-3oZ-_lkrnSR4Zp65z040WO3w3YMKL3vz5mraw$> Regards, Ghada From: Lal, RafalX <rafalx.lal@intel.com><mailto:rafalx.lal@intel.com> Sent: Thursday, August 3, 2023 11:18 AM To: Little, Scott <Scott.Little@windriver.com><mailto:Scott.Little@windriver.com>; Pires Soares, Igor <Igor.PiresSoares@windriver.com><mailto:Igor.PiresSoares@windriver.com>; Reed, Joshua <Joshua.Reed@windriver.com><mailto:Joshua.Reed@windriver.com> Cc: Khalil, Ghada <Ghada.Khalil@windriver.com><mailto:Ghada.Khalil@windriver.com>; Webster, Steven <Steven.Webster@windriver.com><mailto:Steven.Webster@windriver.com>; Walsh, Richard <richard.walsh@intel.com><mailto:richard.walsh@intel.com>; Clarke, Kevin <kevin.clarke@intel.com><mailto:kevin.clarke@intel.com> Subject: Review of app-intel-ethernet-operator code CAUTION: This email comes from a non Wind River email account! Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello, I'm responsible for integration of Intel Ethernet Operator into StarlingX 9.0, and we are currently at the stage of pushing application code to opendev/starlingx repository. Review from Steven will be there, but core reviewers are needed to merge this change into the repository. I got suggestion from Ghada that you might be able to do that. This is the mentioned change<https://urldefense.com/v3/__https:/review.opendev.org/c/starlingx/app-intel-ethernet-operator/*/890199__;Kw!!AjveYdw8EvQ!fKzNzQece12g9rmPamZMa2uQhtIKbq1Tag4WeZPcKWTwOwg-3rIdQhpcDdrJP3X62iBvdgv8raiOFK1okCvItlOf$>. I would greatly appreciate if you would have a look at it in your free time. Best Regards Rafal -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
participants (8)
-
Church, Robert
-
Jeremy Stanley
-
Khalil, Ghada
-
Lal, RafalX
-
Pires Soares, Igor
-
Reed, Joshua
-
Scott Little
-
Walsh, Richard