[Starlingx-discuss] stx-ceph patch commit detail: Add .gitreview
Hi Dean, I'm porting stx-ceph/v10.2.6 upgrade patches to be stx-ceph/v13.2.2 Both WindRiver and I have the question about below patch: Add .gitreview https://github.com/starlingx-staging/stx-ceph/commit/9d93e43290d3a2a0399af75... What's the function of the above patch? Do we still need it in stx-ceph/v13.2.2? Regards, Changcheng
Hi Dean, Please help us understand your patch if you're available. B.R. Changcheng From: Liu, Changcheng Sent: Friday, November 23, 2018 3:19 PM To: Troyer, Dean <dean.troyer@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io> Cc: Poncea, Ovidiu <Ovidiu.Poncea@windriver.com> Subject: stx-ceph patch commit detail: Add .gitreview Hi Dean, I'm porting stx-ceph/v10.2.6 upgrade patches to be stx-ceph/v13.2.2 Both WindRiver and I have the question about below patch: Add .gitreview https://github.com/starlingx-staging/stx-ceph/commit/9d93e43290d3a2a0399af75... What's the function of the above patch? Do we still need it in stx-ceph/v13.2.2? Regards, Changcheng
On Tue, 27 Nov 2018, Liu, Changcheng wrote:
Please help us understand your patch if you’re available.
The .gitreview file is only used for repos in OpenStack's Gerrit. I initally added it under the plan that all repos would be there, we ended up with many not in Gerrit, the .gitreview file is not needed now. dt -- Dean Troyer dean.troyer@intel.com
Thanks Dean. We'll abandon this patch. -----Original Message----- From: Troyer, Dean Sent: Wednesday, November 28, 2018 6:49 AM To: Liu, Changcheng <changcheng.liu@intel.com> Cc: Troyer, Dean <dean.troyer@intel.com>; 'starlingx-discuss@lists.starlingx.io' <starlingx-discuss@lists.starlingx.io>; 'Poncea, Ovidiu' <Ovidiu.Poncea@windriver.com> Subject: RE: stx-ceph patch commit detail: Add .gitreview On Tue, 27 Nov 2018, Liu, Changcheng wrote:
Please help us understand your patch if you’re available.
The .gitreview file is only used for repos in OpenStack's Gerrit. I initally added it under the plan that all repos would be there, we ended up with many not in Gerrit, the .gitreview file is not needed now. dt -- Dean Troyer dean.troyer@intel.com
participants (2)
-
Dean Troyer
-
Liu, Changcheng