[Starlingx-discuss] RPM Macros Versions Changed
We have this bug [0] in review still not merged: RPM Macros + Sphinxcontrib Versions Changed [1] which changes the versions to: python2-rpm-macros-3-21.el7.noarch.rpm python2-sphinxcontrib-httpdomain-1.7.0-1.el7.noarch.rpm python-rpm-macros-3-21.el7.noarch.rpm python-srpm-macros-3-21.el7.noarch.rpm In today's build, the python*macros* rpm's version has changed again [2] requiring us: python-srpm-macros-3-22.el7.noarch.rpm python-rpm-macros-3-22.el7.noarch.rpm python2-rpm-macros-3-22.el7.noarch.rpm What is the appropriate option to proceed? 1. Create another patch with Depends-On: [1] 2. Update [1] to modify the newer version number [0] https://storyboard.openstack.org/#!/story/2003124 [1] https://review.openstack.org/#/c/586393/ [2] https://storyboard.openstack.org/#!/story/2003137
On Sat, Jul 28, 2018 at 9:14 AM, Arce Moreno, Abraham <abraham.arce.moreno@intel.com> wrote:
What is the appropriate option to proceed?
1. Create another patch with Depends-On: [1] 2. Update [1] to modify the newer version number
2. Just update it, there isn't a need to preserve the original review for history or anything (sometimes there might be). Also, within the same repo you can 'stack' reviews and not need Depends-On. git-review will ask if you try to submit more than one new commit in a branch. In a long series, it only creates new patchsets starting with the first commit that is different that what is already in Gerrit. dt -- Dean Troyer dtroyer@gmail.com
1. Create another patch with Depends-On: [1] 2. Update [1] to modify the newer version number
2. Just update it, there isn't a need to preserve the original review for history or anything (sometimes there might be).
Done! https://review.openstack.org/#/c/586393/ Added the 2 stories and tasks created.
Also, within the same repo you can 'stack' reviews and not need Depends-On. git-review will ask if you try to submit more than one new commit in a branch. In a long series, it only creates new patchsets starting with the first commit that is different that what is already in Gerrit.
Nice feature, thanks Dean for the explanation :)
participants (2)
-
Arce Moreno, Abraham
-
Dean Troyer