Re: [Starlingx-discuss] CentOS 7.6 rebase feature testing
Hi Shuicheng, Inline responses as well. Symptoms persist as of a pull done today. -Jason From: Lin, Shuicheng <shuicheng.lin@intel.com> Sent: January 28, 2019 8:50 PM To: McKenna, Jason <Jason.McKenna@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Xie, Cindy <cindy.xie@intel.com>; Cabrales, Ada <ada.cabrales@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: CentOS 7.6 rebase feature testing Hi Jason, Please check my comments inline. Best Regards Shuicheng From: McKenna, Jason [mailto:Jason.McKenna@windriver.com] Sent: Tuesday, January 29, 2019 9:18 AM To: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Shuicheng, Cindy, I am currently observing a few build issue with the f/centos76 branch + https://review.openstack.org/633431 - The .lst file in stx-tools which downloads the Mellanox driver is currently downloading the old version, but the source code in stx-integ/networking/mellanox is assuming the new version [lin]: could you help confirm stx-tools switched to centos76 feature branch before mirror creation? The Mellanox driver is upgraded with below patch: https://review.openstack.org/628099 [jm] I misspoke when I said ".lst" files -- the issue is not in the downloading of package, it's in the stx-tools/toCOPY/populate_downloads.sh script which populates the stx/downloads directory from the downloaded packages. The script still copies the 4.3 versions (search for "extra_downloads" in the script file) - The integrity-kmod package (stx-integ/kernel/kernel-modules/integrity) do not build - at build-rpms time, the patches cannot be applied to the source code. [lin]: do you use clean build? Could you have a try with "build-pkgs --clean integrity-kmod" and "build-pkgs integrity-kmod"? [jm]: Clean build fails. I've pasted a segment of the generated error log below. It appears that the Changes-for-CentOS-7.6-support.patch is failing to apply to the code: + cd integrity + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/bin/cat /builddir/build/SOURCES/0001-integrity-kcompat-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0002-integrity-expose-module-params.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0003-integrity-restrict-by-iversion.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0004-integrity-disable-set-xattr-on-imasig.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.4-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.6-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_crypto.c b/integrity/ima/ima_crypto.c |index 802d5d2..3371d13 100644 |--- a/integrity/ima/ima_crypto.c |+++ b/integrity/ima/ima_crypto.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_init.c b/integrity/ima/ima_init.c |index 2967d49..29b72cd 100644 |--- a/integrity/ima/ima_init.c |+++ b/integrity/ima/ima_init.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_queue.c b/integrity/ima/ima_queue.c |index d9aa5ab..9946363 100644 |--- a/integrity/ima/ima_queue.c |+++ b/integrity/ima/ima_queue.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Child return code was: 1 EXCEPTION: [Error()]
Hi Jason, Thanks for the detail sharing. I have fixed both issue with below patches: https://review.openstack.org/633870 https://review.openstack.org/633872 Please help have a try with it. Sorry for the trouble caused. Best Regards Shuicheng From: McKenna, Jason [mailto:Jason.McKenna@windriver.com] Sent: Tuesday, January 29, 2019 10:40 PM To: Lin, Shuicheng <shuicheng.lin@intel.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Xie, Cindy <cindy.xie@intel.com>; Cabrales, Ada <ada.cabrales@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: CentOS 7.6 rebase feature testing Hi Shuicheng, Inline responses as well. Symptoms persist as of a pull done today. -Jason From: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>> Sent: January 28, 2019 8:50 PM To: McKenna, Jason <Jason.McKenna@windriver.com<mailto:Jason.McKenna@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Jason, Please check my comments inline. Best Regards Shuicheng From: McKenna, Jason [mailto:Jason.McKenna@windriver.com] Sent: Tuesday, January 29, 2019 9:18 AM To: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Shuicheng, Cindy, I am currently observing a few build issue with the f/centos76 branch + https://review.openstack.org/633431 - The .lst file in stx-tools which downloads the Mellanox driver is currently downloading the old version, but the source code in stx-integ/networking/mellanox is assuming the new version [lin]: could you help confirm stx-tools switched to centos76 feature branch before mirror creation? The Mellanox driver is upgraded with below patch: https://review.openstack.org/628099 [jm] I misspoke when I said ".lst" files -- the issue is not in the downloading of package, it's in the stx-tools/toCOPY/populate_downloads.sh script which populates the stx/downloads directory from the downloaded packages. The script still copies the 4.3 versions (search for "extra_downloads" in the script file) - The integrity-kmod package (stx-integ/kernel/kernel-modules/integrity) do not build - at build-rpms time, the patches cannot be applied to the source code. [lin]: do you use clean build? Could you have a try with "build-pkgs --clean integrity-kmod" and "build-pkgs integrity-kmod"? [jm]: Clean build fails. I've pasted a segment of the generated error log below. It appears that the Changes-for-CentOS-7.6-support.patch is failing to apply to the code: + cd integrity + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/bin/cat /builddir/build/SOURCES/0001-integrity-kcompat-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0002-integrity-expose-module-params.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0003-integrity-restrict-by-iversion.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0004-integrity-disable-set-xattr-on-imasig.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.4-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.6-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_crypto.c b/integrity/ima/ima_crypto.c |index 802d5d2..3371d13 100644 |--- a/integrity/ima/ima_crypto.c |+++ b/integrity/ima/ima_crypto.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_init.c b/integrity/ima/ima_init.c |index 2967d49..29b72cd 100644 |--- a/integrity/ima/ima_init.c |+++ b/integrity/ima/ima_init.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_queue.c b/integrity/ima/ima_queue.c |index d9aa5ab..9946363 100644 |--- a/integrity/ima/ima_queue.c |+++ b/integrity/ima/ima_queue.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Child return code was: 1 EXCEPTION: [Error()]
Hi Shuicheng, With those two changes in place, I can now build. Thanks! -Jason From: Lin, Shuicheng <shuicheng.lin@intel.com> Sent: January 30, 2019 2:21 AM To: McKenna, Jason <Jason.McKenna@windriver.com>; Khalil, Ghada <Ghada.Khalil@windriver.com>; Xie, Cindy <cindy.xie@intel.com>; Cabrales, Ada <ada.cabrales@intel.com> Cc: starlingx-discuss@lists.starlingx.io Subject: RE: CentOS 7.6 rebase feature testing Hi Jason, Thanks for the detail sharing. I have fixed both issue with below patches: https://review.openstack.org/633870 https://review.openstack.org/633872 Please help have a try with it. Sorry for the trouble caused. Best Regards Shuicheng From: McKenna, Jason [mailto:Jason.McKenna@windriver.com] Sent: Tuesday, January 29, 2019 10:40 PM To: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Shuicheng, Inline responses as well. Symptoms persist as of a pull done today. -Jason From: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>> Sent: January 28, 2019 8:50 PM To: McKenna, Jason <Jason.McKenna@windriver.com<mailto:Jason.McKenna@windriver.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Jason, Please check my comments inline. Best Regards Shuicheng From: McKenna, Jason [mailto:Jason.McKenna@windriver.com] Sent: Tuesday, January 29, 2019 9:18 AM To: Lin, Shuicheng <shuicheng.lin@intel.com<mailto:shuicheng.lin@intel.com>>; Khalil, Ghada <Ghada.Khalil@windriver.com<mailto:Ghada.Khalil@windriver.com>>; Xie, Cindy <cindy.xie@intel.com<mailto:cindy.xie@intel.com>>; Cabrales, Ada <ada.cabrales@intel.com<mailto:ada.cabrales@intel.com>> Cc: starlingx-discuss@lists.starlingx.io<mailto:starlingx-discuss@lists.starlingx.io> Subject: RE: CentOS 7.6 rebase feature testing Hi Shuicheng, Cindy, I am currently observing a few build issue with the f/centos76 branch + https://review.openstack.org/633431 - The .lst file in stx-tools which downloads the Mellanox driver is currently downloading the old version, but the source code in stx-integ/networking/mellanox is assuming the new version [lin]: could you help confirm stx-tools switched to centos76 feature branch before mirror creation? The Mellanox driver is upgraded with below patch: https://review.openstack.org/628099 [jm] I misspoke when I said ".lst" files -- the issue is not in the downloading of package, it's in the stx-tools/toCOPY/populate_downloads.sh script which populates the stx/downloads directory from the downloaded packages. The script still copies the 4.3 versions (search for "extra_downloads" in the script file) - The integrity-kmod package (stx-integ/kernel/kernel-modules/integrity) do not build - at build-rpms time, the patches cannot be applied to the source code. [lin]: do you use clean build? Could you have a try with "build-pkgs --clean integrity-kmod" and "build-pkgs integrity-kmod"? [jm]: Clean build fails. I've pasted a segment of the generated error log below. It appears that the Changes-for-CentOS-7.6-support.patch is failing to apply to the code: + cd integrity + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/bin/cat /builddir/build/SOURCES/0001-integrity-kcompat-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0002-integrity-expose-module-params.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0003-integrity-restrict-by-iversion.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/0004-integrity-disable-set-xattr-on-imasig.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.4-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch + /usr/bin/cat /builddir/build/SOURCES/Changes-for-CentOS-7.6-support.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_crypto.c b/integrity/ima/ima_crypto.c |index 802d5d2..3371d13 100644 |--- a/integrity/ima/ima_crypto.c |+++ b/integrity/ima/ima_crypto.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_init.c b/integrity/ima/ima_init.c |index 2967d49..29b72cd 100644 |--- a/integrity/ima/ima_init.c |+++ b/integrity/ima/ima_init.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored The text leading up to this was: -------------------------- |diff --git a/integrity/ima/ima_queue.c b/integrity/ima/ima_queue.c |index d9aa5ab..9946363 100644 |--- a/integrity/ima/ima_queue.c |+++ b/integrity/ima/ima_queue.c -------------------------- File to patch: Skip this patch? [y] 1 out of 1 hunk ignored RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Bad exit status from /var/tmp/rpm-tmp.np8mTM (%prep) Child return code was: 1 EXCEPTION: [Error()]
participants (2)
-
Lin, Shuicheng
-
McKenna, Jason