[Starlingx-discuss] Request for clarification related to gcc 8

[Eslimi, Dariush]

If that is case Chris, then title of the bug should not be : "fm-common cannot be built with GCC 8 due to string bound checks"

Dariush

-----Original Message-----
From: Chris Friesen [mailto:chris.friesen at windriver.com] 
Sent: August-21-18 3:20 PM
To: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Request for clarification related to gcc 8

On 08/21/2018 01:11 PM, Eslimi, Dariush wrote:
> Bruce I agree on the first on that is a bug, regardless of the tool it 
> is a security issue and should be triaged and assigned a priority to 
> be fixed, but the second one is only an issue if you try to use gcc 8, 
> under currently supported build process that is not a bug. So the 
> second one would be better tracked under a feature that tracks all 
> issues that need to be resolved to support the new compiler.

The second case is a classic strncpy() error scenario, which was why strlcpy() was created.

In the second case, does the code properly handle the scenario where the resulting string has no null terminator?

If the code expects the resulting string to be null-terminated then I think it should be counted as a bug rather than a "support new compiler" feature.

Chris

_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss