[Starlingx-discuss] patch merge approach for starlingx-staging projects ?

[Miller, Frank]

Hi Dean:

There is a request to backport a change from openstack Heat (Rocky) to the starlingx-staging github repo: https://github.com/starlingx-staging/stx-heat/pull/1 

We think we followed the right steps but can you confirm?  And who are the core reviewers for the starlingx-staging projects so we can work on getting the required +2?

Frank
P.S. We know we want to minimize changes in the staging githubs but this is a backport and falls within the guidelines for changes.

-----Original Message-----
From: Wang, Yi C [mailto:yi.c.wang at intel.com] 
Sent: Monday, July 16, 2018 8:44 PM
To: Dean Troyer
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] patch merge approach for starlingx-staging projects ?

Thanks Dean. 
One more question. Who are in the list of core of starlingx-staging projects?

Thanks.
Yi

-----Original Message-----
From: Dean Troyer [mailto:dtroyer at gmail.com]
Sent: Monday, July 16, 2018 11:05 PM
To: Wang, Yi C <yi.c.wang at intel.com>
Cc: starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] patch merge approach for starlingx-staging projects ?

On Mon, Jul 16, 2018 at 2:47 AM, Wang, Yi C <yi.c.wang at intel.com> wrote:
> Considering in some case, like security bug fixing , we still need to 
> make some patches for starlingx-staging projects. Do we have a 
> proposed patch merge approach for them? Thanks.

It is basically the same process, submit a PR, get at least 2 core +2s and merge it.

However, merging things into those repos has a higher bar, at least for anything that should be upstreamed (making our tests run for example are not in this category).  Backports of existing upstream work are easier to justify as is anything new that is also accompanied by an upstream review.

dt

-- 

Dean Troyer
dtroyer at gmail.com
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss