[Starlingx-discuss] Proposal: Basic development guidelines / rules

[Jones, Bruce E]

Cindy, thanks.  What I was trying to say is that since bugs should already be posted to Storyboard by the person who found them, they don't need any additional specs or discussion.

Which isn't always the case, of course, since sometimes fixing a bug can require a big change.

I've updated https://wiki.openstack.org/wiki/StarlingX/Contribution_Guidelines with the feedback from this thread.

        brucej

-----Original Message-----
From: Xie, Cindy 
Sent: Wednesday, June 20, 2018 11:19 PM
To: Arce Moreno, Abraham <abraham.arce.moreno at intel.com>; Jones, Bruce E <bruce.e.jones at intel.com>; starlingx-discuss at lists.starlingx.io
Subject: RE: [Starlingx-discuss] Proposal: Basic development guidelines / rules

I am not quite sure if I understand below:

Code submissions for bug fixes do not need to be reviewed before pushing to gerrit. Bug reports should be posted to Storyboard.

Are you saying that patches for bug fixing do not required code-review + 1, +2 before it merged? Or you just are saying no [RFC] requests in mailing list shall be reviewed before bug-fixing patch got submitted?

Thx. - cindy

-----Original Message-----
From: Arce Moreno, Abraham [mailto:abraham.arce.moreno at intel.com]
Sent: Thursday, June 21, 2018 11:14 AM
To: Jones, Bruce E <bruce.e.jones at intel.com>; starlingx-discuss at lists.starlingx.io
Subject: Re: [Starlingx-discuss] Proposal: Basic development guidelines / rules

> Rule 7: Code submissions for larger development tasks shall be 
> discussed on the mailing list _prior_ to code submission, to allow for 
> community review and feedback.  Post early and often.  Please review 
> (and test!) each other's code.

What is the usual way in OpenStack to review a proposal of a change? 
I have 2 files, one script that downloads from a text file a list tar compressed files, is it ok to post the patch as [RFC] in this mailing list? Etherpad?
Any other?

Thanks for your guidance!
_______________________________________________
Starlingx-discuss mailing list
Starlingx-discuss at lists.starlingx.io
http://lists.starlingx.io/cgi-bin/mailman/listinfo/starlingx-discuss