[Starlingx-discuss] [glance] Analysis of patch c73ab48 (Enhanced-error-messages) for StartlingX upstreaming

[Fang, Liang A]

Hi Daniel and Stefan

Please refer to https://review.openstack.org/#/c/616880/
This patch is to provide detailed exception info when no space in rbd. But in my environment, if rbd has no space, the function call to rbd will not return, there's no exception raised.

Details:
In /usr/local/lib/python2.7/dist-packages/glance_store/_drivers/rbd.py

-          Function call will hang at line 484 (_create_image) if no space to create image at the beginning
[cid:image001.png at 01D47916.203BFA30]

-          Function call will hang at line 506 (image.resize) if no space at the middle of uploading.

[cid:image002.png at 01D47917.1BBFA460]

Could you please give some clue to reproduce this patch (raise rbd.NoSpace)?
Couple of other thought:

1.       This patch is to catch exception at v1 api, but v1 is about to be removed by community.

2.       rbd is just one type of the multiple types of backend, so I think catch specific backend's exception at a common code is not so good. glance_store/rbd.py may be the better place to catch this exception. In fact rbd.py already did similar thing, see:

[cid:image003.png at 01D47919.B20AE9F0]

Thanks
Liang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181110/ae725637/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 2947 bytes
Desc: image001.png
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181110/ae725637/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image002.png
Type: image/png
Size: 1524 bytes
Desc: image002.png
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181110/ae725637/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image003.png
Type: image/png
Size: 8559 bytes
Desc: image003.png
URL: <http://lists.starlingx.io/pipermail/starlingx-discuss/attachments/20181110/ae725637/attachment-0005.png>